From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:5a52:b0:9d0:bf65:29fa with SMTP id my18csp1921913ejc; Tue, 14 Nov 2023 01:51:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCVcGX9xbnlZsd0a6c1zVIFv5gKghZLdmkYqM55KVf6Rje/KlbzPbz5PP5Lf/2MSUZPB8q X-Received: by 2002:a05:622a:1a1d:b0:41b:773c:184f with SMTP id f29-20020a05622a1a1d00b0041b773c184fmr2329519qtb.10.1699955505674; Tue, 14 Nov 2023 01:51:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699955505; cv=none; d=google.com; s=arc-20160816; b=BFB33mobanyYdI7yd0WdZIq7MYuDePMiCtgWeXBaeSk1PLmjLlCEuywQFcXQc41vt9 ta9m4+/XEt9ROS1qV2WuLZGX0uUiS1csDkJRANp0dWUXtTGr0ujhUScdnJNZhwtTOtcU pe/gCTaVsojrttzKpve99bH0VRqVJyU3llOdkODSlX+vUOwN7OCo7rAYS02sV1GJvGPx bNjS68+4dJWYmvBMedlhgfw4hL/L3HpKfoITzsEZJkfwsLbl7iRDRsDtWCcyG88akbGF vo8nxJsOucbU663ex4GFXZT/InkTn7FG94V+58XH8dOKQPl0gvVnAgX6DIreFeO/AHd3 AZwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:dkim-signature; bh=FUfVVyxKxp8nmPIUQXIY5bF6nOriVH/SuR23saAG9D0=; fh=oRlrhcT7o3lQbKACSVGG7cT31qulr1N603BcGkCirhA=; b=N7s44TTIN5dcNG0G/dK4jROMeLQzf4nfu5dw+ypDWJB6SllA3n5zC8FQLbAHPPfRWM /MfEphSFqtQUSw98D5U50jzmYrr0gg1xDL+IiORhQdvTaMEexuUfuPn+kFC9S2P568zs 2zk43q42owwsnsu2CY+9IenFUPV4cPLNoSYY6aiO5GlWMNY1GnP+VMdxMsyJisllRNua uo7/s5XaeBi1Cu3Kgb7x0hjbyYSC4zrvlEglqq/ByKPSf93LnuIJ6JSFKbM1DwxXWb0x lH6V4R8uZyz0CM3FQkw4ilhBGKm/kPUP0AF1Vv+Myh5pQRQv9KhjbznCy5/CiwYBeU1x FZNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Exh7NhG+; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h3-20020a05622a170300b00419579dd7a8si6230327qtk.308.2023.11.14.01.51.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Nov 2023 01:51:45 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Exh7NhG+; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2q4k-0000Sb-RX; Tue, 14 Nov 2023 04:51:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2q4i-0000S9-Mu for qemu-devel@nongnu.org; Tue, 14 Nov 2023 04:51:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2q4g-0001pM-OR for qemu-devel@nongnu.org; Tue, 14 Nov 2023 04:51:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699955473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FUfVVyxKxp8nmPIUQXIY5bF6nOriVH/SuR23saAG9D0=; b=Exh7NhG+s17/76K6oMLXQL71CZfTD4L+6eK/+pFJg+LL25fFMvbt6NVJOAU/9YUb+69uwy 1DJDlugPKvfQBxBxa9ZGeJpDj9nh3INU7NgaC5hIsGSe4XHOGelStasbo5gUDvL8+cbiBF qDzN9/OJ77Z19uw72+HbegJN7Hqg0sI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-geuh3tAAPOuCYHrqRg2vEg-1; Tue, 14 Nov 2023 04:51:09 -0500 X-MC-Unique: geuh3tAAPOuCYHrqRg2vEg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3D18A82B9D4; Tue, 14 Nov 2023 09:51:09 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0562F1C060AE; Tue, 14 Nov 2023 09:51:09 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0C0FE21E6A1F; Tue, 14 Nov 2023 10:51:08 +0100 (CET) From: Markus Armbruster To: Thomas Huth Cc: Daniel P. =?utf-8?Q?Berrang=C3=A9?= , qemu-devel@nongnu.org, alistair@alistair23.me, edgar.iglesias@gmail.com, peter.maydell@linaro.org, francisco.iglesias@amd.com, qemu-arm@nongnu.org, Paolo Bonzini , Eduardo Habkost Subject: Re: [PATCH 0/2] Replace anti-social QOM type names (again) References: <20231113134344.1195478-1-armbru@redhat.com> <87y1f0hjdh.fsf@pond.sub.org> Date: Tue, 14 Nov 2023 10:51:08 +0100 In-Reply-To: (Thomas Huth's message of "Tue, 14 Nov 2023 09:06:13 +0100") Message-ID: <871qcsfysz.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: HfHxOqOA72Vb Thomas Huth writes: > On 14/11/2023 08.41, Markus Armbruster wrote: >> Cc: the other QOM maintainers >> Daniel P. Berrang=C3=A9 writes: >>=20 >>> On Mon, Nov 13, 2023 at 02:43:42PM +0100, Markus Armbruster wrote: >>>> We got rid of QOM type names containing ',' in 6.0, but some have >>>> crept back in. Replace them just like we did in 6.0. >>> >>> It is practical to add >>> >>> assert(strchr(name, ',') =3D=3D NULL) >>> >>> to some place in QOM to stop them coming back yet again ? >> >> This adds a naming rule to QOM. Right now, QOM has none whatsoever, >> which I've long called out as a mistake. >> >> I'm all for correcting that mistake, but I'd go further than just >> outlawing ','. > > What prevents us from fixing this "mistake"? 1. Having to clean up the naming messes we made. This involves backward compatibility arguments and work-arounds. 2. Inertia. > Is there any compelling reason for keeping the current lax naming rules o= f QOM? Can't think of any but avoiding 1. > Would there be migration issues if we'd rename the current offenders? (an= d even if so, couldn't we simply fix that issue by curating an allowlist of= old names?) I believe migration should not be affected, since migration section names are entirely separate. Mind, I'm no migration expert.