All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: "Martin Zeiser \(mzeiser\)" <mzeiser@cisco.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/3 v2] pkg-download: add option to enforce hash checking
Date: Tue, 07 Nov 2023 11:48:17 +0100	[thread overview]
Message-ID: <871qd1yh3i.fsf@48ers.dk> (raw)
In-Reply-To: <c4cb742e3bd2d4c18b6a21338167c17b50fe4986.1699297749.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Mon, 6 Nov 2023 20:09:14 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Currently, when a pacakge is downloaded from a custom location or
 > version, Buildroot excludes such a package from the mandatory integrity
 > check with hashes, because it was until now not possible to have such
 > hashes.

 > We now have a mechanism which users can leverage to provide additional
 > hashes, and so custom versions or locations can now be checked too.

 > Buildroot has no way to know that hashes have indeed been provided for
 > a custom location/version, and so will still happilly ignore an
 > unchecked package.

 > However, users who do provide extra hashes most probably do expect that
 > no download is done without an integrity check, and thus expect that a
 > missing hash not be ignored.

 > Add an option that users can select to make Buildroot forcibly require
 > at least one valid hash, and no invalid hash, for all downloads.

 > Reported-by: "Martin Zeiser (mzeiser)" <mzeiser@cisco.com>
 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-11-07 10:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06 19:09 [Buildroot] [PATCH 0/3 v2] support/download: accept user-provided list of extra hash files (branch yem/multi-hash) Yann E. MORIN
2023-11-06 19:09 ` [Buildroot] [PATCH 1/3 v2] support/download: teach dl-wrapper to handle more than one hash file Yann E. MORIN
2023-11-07 10:46   ` Peter Korsgaard
2023-11-10 13:36     ` Peter Korsgaard
2023-11-06 19:09 ` [Buildroot] [PATCH 2/3 v2] package/pkg-download: lookup hash files in global-patch-dir Yann E. MORIN
2023-11-07 10:47   ` Peter Korsgaard
2023-11-10 13:36   ` Peter Korsgaard
2023-11-06 19:09 ` [Buildroot] [PATCH 3/3 v2] pkg-download: add option to enforce hash checking Yann E. MORIN
2023-11-07 10:48   ` Peter Korsgaard [this message]
2023-11-10 13:36   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qd1yh3i.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=mzeiser@cisco.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.