From: Jani Nikula <jani.nikula@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH 00/25] Framework for display parameters
Date: Thu, 12 Oct 2023 18:04:23 +0300 [thread overview]
Message-ID: <871qdz287c.fsf@intel.com> (raw)
In-Reply-To: <20231010114120.2504103-1-jouni.hogander@intel.com>
On Tue, 10 Oct 2023, Jouni Högander <jouni.hogander@intel.com> wrote:
> Currently all module parameters are handled by i915_param.c/h. This
> is a problem for display parameters when Xe driver is used.
>
> This patch set adds a mechanism to add parameters specific to the
> display. This is mainly copied from existing i915 parameters
> implementation with some naming changes and taking into account
> varying driver name.
>
> Also all display specific module parameters are moved under display and the
> module parameter are all converted as non-writable. This should be ok
> as we have writable device parameters under debugfs.
I did not do a detailed review, but quickly glanced through the series,
and I think the approach is fine.
Acked-by: Jani Nikula <jani.nikula@intel.com>
But needs a detailed review.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Jouni Högander (25):
> drm/i915/display: Add framework to add parameters specific to display
> drm/i915/display: Dump also display parameters into GPU error dump
> drm/i915/display: Move enable_fbc module parameter under display
> drm/i915/display: Move psr related module parameters under display
> drm/i915/display: Move vbt_firmware module parameter under display
> drm/i915/display: Move lvds_channel_mode module parameter under
> display
> drm/i915/display: Move panel_use_ssc module parameter under display
> drm/i915/display: Move vbt_sdvo_panel_type module parameter under
> display
> drm/i915/display: Move enable_dc module parameter under display
> drm/i915/display: Move enable_dpt module parameter under display
> drm/i915/display: Move enable_sagv module parameter under display
> drm/i915/display: Move disable_power_well module parameter under
> display
> drm/i915/display: Move enable_ips module parameter under display
> drm/i915/display: Move invert_brightness module parameter under
> display
> drm/i915/display: Move edp_vswing module parameter under display
> drm/i915/display: Move fastboot module parameter under display
> drm/i915/display: Move enable_dpcd_backlightmodule parameter under
> display
> drm/i915/display: Move load_detect_test parameter under display
> drm/i915/display: Move force_reset_modeset_test parameter under
> display
> drm/i915/display: Move disable_display parameter under display
> drm/i915/display: Use device parameters instead of module in
> I915_STATE_WARN
> drm/i915/display: Move verbose_state_checks under display
> drm/i915/display: Move nuclear_pageflip under display
> drm/i915/display: Move enable_dp_mst under display
> drm/i915/display: Use same permissions for enable_sagv as for rest
>
> drivers/gpu/drm/i915/Makefile | 2 +
> drivers/gpu/drm/i915/display/hsw_ips.c | 4 +-
> drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +-
> .../gpu/drm/i915/display/intel_backlight.c | 9 +-
> drivers/gpu/drm/i915/display/intel_bios.c | 6 +-
> drivers/gpu/drm/i915/display/intel_crt.c | 4 +-
> drivers/gpu/drm/i915/display/intel_display.c | 4 +-
> drivers/gpu/drm/i915/display/intel_display.h | 2 +-
> .../gpu/drm/i915/display/intel_display_core.h | 2 +
> .../drm/i915/display/intel_display_debugfs.c | 2 +
> .../display/intel_display_debugfs_params.c | 176 ++++++++++++++
> .../display/intel_display_debugfs_params.h | 14 ++
> .../drm/i915/display/intel_display_device.c | 13 +-
> .../drm/i915/display/intel_display_device.h | 1 +
> .../drm/i915/display/intel_display_params.c | 221 ++++++++++++++++++
> .../drm/i915/display/intel_display_params.h | 62 +++++
> .../drm/i915/display/intel_display_power.c | 14 +-
> .../drm/i915/display/intel_display_reset.c | 2 +-
> drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
> .../drm/i915/display/intel_dp_aux_backlight.c | 4 +-
> drivers/gpu/drm/i915/display/intel_dpt.c | 6 +-
> drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
> drivers/gpu/drm/i915/display/intel_fbc.c | 10 +-
> drivers/gpu/drm/i915/display/intel_lvds.c | 4 +-
> drivers/gpu/drm/i915/display/intel_opregion.c | 2 +-
> drivers/gpu/drm/i915/display/intel_panel.c | 4 +-
> drivers/gpu/drm/i915/display/intel_psr.c | 14 +-
> .../drm/i915/display/skl_universal_plane.c | 2 +-
> drivers/gpu/drm/i915/display/skl_watermark.c | 5 +-
> drivers/gpu/drm/i915/i915_driver.c | 2 +
> drivers/gpu/drm/i915/i915_gpu_error.c | 3 +
> drivers/gpu/drm/i915/i915_gpu_error.h | 2 +
> drivers/gpu/drm/i915/i915_params.c | 94 --------
> drivers/gpu/drm/i915/i915_params.h | 23 --
> 34 files changed, 553 insertions(+), 170 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_debugfs_params.h
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_display_params.h
--
Jani Nikula, Intel
prev parent reply other threads:[~2023-10-12 15:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 11:40 [Intel-gfx] [PATCH 00/25] Framework for display parameters Jouni Högander
2023-10-10 11:40 ` [Intel-gfx] [PATCH 01/25] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-10 11:40 ` [Intel-gfx] [PATCH 02/25] drm/i915/display: Dump also display parameters into GPU error dump Jouni Högander
2023-10-12 7:38 ` Hogander, Jouni
2023-10-10 11:40 ` [Intel-gfx] [PATCH 03/25] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-10 11:40 ` [Intel-gfx] [PATCH 04/25] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 05/25] drm/i915/display: Move vbt_firmware module parameter " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 06/25] drm/i915/display: Move lvds_channel_mode " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 07/25] drm/i915/display: Move panel_use_ssc " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 08/25] drm/i915/display: Move vbt_sdvo_panel_type " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 09/25] drm/i915/display: Move enable_dc " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 10/25] drm/i915/display: Move enable_dpt " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 11/25] drm/i915/display: Move enable_sagv " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 12/25] drm/i915/display: Move disable_power_well " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 13/25] drm/i915/display: Move enable_ips " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 14/25] drm/i915/display: Move invert_brightness " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 15/25] drm/i915/display: Move edp_vswing " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 16/25] drm/i915/display: Move fastboot " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 17/25] drm/i915/display: Move enable_dpcd_backlightmodule " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 18/25] drm/i915/display: Move load_detect_test " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 19/25] drm/i915/display: Move force_reset_modeset_test " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 20/25] drm/i915/display: Move disable_display " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 21/25] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 22/25] drm/i915/display: Move verbose_state_checks under display Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 23/25] drm/i915/display: Move nuclear_pageflip " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 24/25] drm/i915/display: Move enable_dp_mst " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 25/25] drm/i915/display: Use same permissions for enable_sagv as for rest Jouni Högander
2023-10-10 22:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Framework for display parameters (rev2) Patchwork
2023-10-10 22:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-10 22:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-11 10:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-10-12 15:04 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qdz287c.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.