From: Fabiano Rosas <farosas@suse.de>
To: Het Gala <het.gala@nutanix.com>, qemu-devel@nongnu.org
Cc: prerna.saxena@nutanix.com, quintela@redhat.com,
dgilbert@redhat.com, pbonzini@redhat.com, berrange@redhat.com,
armbru@redhat.com, eblake@redhat.com, manish.mishra@nutanix.com,
aravind.retnakaran@nutanix.com, Het Gala <het.gala@nutanix.com>
Subject: Re: [PATCH v11 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration
Date: Wed, 04 Oct 2023 10:33:07 -0300 [thread overview]
Message-ID: <871qea5x7w.fsf@suse.de> (raw)
In-Reply-To: <20231004075851.219173-1-het.gala@nutanix.com>
Het Gala <het.gala@nutanix.com> writes:
> This is v11 patchset of modified 'migrate' and 'migrate-incoming' QAPI design
> for upstream review.
>
> Update: Daniel has reviewed all patches and is okay with them. Markus has also
> given Acked-by tag for patches related to QAPI syntax change.
> Fabiano, Juan and other migration maintainers, let me know if there are still
> improvements to be made in this patchset series.
>
> Link to previous upstream community patchset links:
> v1: https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg04339.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg02106.html
> v3: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg02473.html
> v4: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg03064.html
> v5: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04845.html
> v6: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg01251.html
> v7: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg02027.html
> v8: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg02770.html
> v9: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg04216.html
> v10: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg05022.html
>
> v10 -> v11 changelog:
> -------------------
> - Resolved make check errors as its been almost two months since v10
> version of this patchset series went out. Till date migration workflow
> might have changed which caused make check errors.
Sorry, there must be a misunderstanding here. This series still has
problems. Just look at patch 6 that adds the "channel-type" parameter and
patch 10 that uses "channeltype" in the test (without hyphen). This
cannot work.
There's also several instances of g_autoptr being used incorrectly. I
could comment on every patch individually, but this series cannot have
passed make check.
Please resend this with the issues fixed and drop the Reviewed-bys from
the affected patches.
Summary of Failures:
1/418 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test ERROR 0.44s killed by signal 6 SIGABRT
7/418 qemu:qtest+qtest-i386 / qtest-i386/migration-test ERROR 0.47s killed by signal 6 SIGABRT
121/418 qemu:qtest+qtest-x86_64 / qtest-x86_64/tpm-crb-swtpm-test ERROR 0.55s killed by signal 6 SIGABRT
128/418 qemu:qtest+qtest-x86_64 / qtest-x86_64/tpm-tis-swtpm-test ERROR 0.72s killed by signal 6 SIGABRT
131/418 qemu:qtest+qtest-i386 / qtest-i386/ahci-test ERROR 12.53s killed by signal 6 SIGABRT
134/418 qemu:qtest+qtest-x86_64 / qtest-x86_64/ahci-test ERROR 13.04s killed by signal 6 SIGABRT
143/418 qemu:qtest+qtest-x86_64 / qtest-x86_64/virtio-net-failover ERROR 2.95s killed by signal 6 SIGABRT
147/418 qemu:qtest+qtest-i386 / qtest-i386/qos-test ERROR 16.12s killed by signal 6 SIGABRT
148/418 qemu:qtest+qtest-x86_64 / qtest-x86_64/qos-test ERROR 16.15s killed by signal 6 SIGABRT
177/418 qemu:qtest+qtest-i386 / qtest-i386/tpm-crb-swtpm-test ERROR 0.55s killed by signal 6 SIGABRT
180/418 qemu:qtest+qtest-i386 / qtest-i386/tpm-tis-swtpm-test ERROR 0.59s killed by signal 6 SIGABRT
197/418 qemu:qtest+qtest-i386 / qtest-i386/virtio-net-failover ERROR 2.38s killed by signal 6 SIGABRT
305/418 qemu:block / io-qcow2-181 ERROR 0.52s exit status 1
312/418 qemu:block / io-qcow2-060 ERROR 9.89s exit status 1
316/418 qemu:block / io-qcow2-203 ERROR 0.84s exit status 1
next prev parent reply other threads:[~2023-10-04 13:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 7:58 [PATCH v11 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration Het Gala
2023-10-04 7:58 ` [PATCH v11 01/10] migration: New QAPI type 'MigrateAddress' Het Gala
2023-10-04 7:58 ` [PATCH v11 02/10] migration: convert migration 'uri' into 'MigrateAddress' Het Gala
2023-10-04 11:48 ` Juan Quintela
2023-10-04 11:52 ` Juan Quintela
2023-10-04 14:43 ` Fabiano Rosas
2023-10-04 17:58 ` Daniel P. Berrangé
2023-10-04 18:12 ` Fabiano Rosas
2023-10-07 11:35 ` Het Gala
2023-10-09 14:13 ` Fabiano Rosas
2023-10-09 15:06 ` Het Gala
2023-10-07 9:01 ` Het Gala
2023-10-04 7:58 ` [PATCH v11 03/10] migration: convert socket backend to accept MigrateAddress Het Gala
2023-10-04 7:58 ` [PATCH v11 04/10] migration: convert rdma " Het Gala
2023-10-04 7:58 ` [PATCH v11 05/10] migration: convert exec " Het Gala
2023-10-04 14:55 ` Fabiano Rosas
2023-10-07 12:36 ` Het Gala
2023-10-04 7:58 ` [PATCH v11 06/10] migration: New migrate and migrate-incoming argument 'channels' Het Gala
2023-10-04 7:58 ` [PATCH v11 07/10] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax Het Gala
2023-10-04 7:58 ` [PATCH v11 08/10] migration: Implement MigrateChannelList to qmp migration flow Het Gala
2023-10-04 15:21 ` Fabiano Rosas
2023-10-07 16:25 ` Het Gala
2023-10-09 14:29 ` Fabiano Rosas
2023-10-10 5:17 ` Het Gala
2023-10-04 7:58 ` [PATCH v11 09/10] migration: Implement MigrateChannelList to hmp " Het Gala
2023-10-04 15:25 ` Fabiano Rosas
2023-10-07 16:56 ` Het Gala
2023-10-09 14:35 ` Fabiano Rosas
2023-10-10 5:20 ` Het Gala
2023-10-04 7:58 ` [PATCH v11 10/10] migration: modify test_multifd_tcp_none() to use new QAPI syntax Het Gala
2023-10-04 15:25 ` Fabiano Rosas
2023-10-09 13:17 ` Het Gala
2023-10-04 13:33 ` Fabiano Rosas [this message]
2023-10-04 13:45 ` [PATCH v11 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration Het Gala
2023-10-04 14:03 ` Fabiano Rosas
2023-10-04 15:32 ` Fabiano Rosas
2023-10-09 13:25 ` Het Gala
2023-10-06 16:17 ` Het Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qea5x7w.fsf@suse.de \
--to=farosas@suse.de \
--cc=aravind.retnakaran@nutanix.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=het.gala@nutanix.com \
--cc=manish.mishra@nutanix.com \
--cc=pbonzini@redhat.com \
--cc=prerna.saxena@nutanix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.