From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Vincent Fazio <vfazio@xes-inc.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/5] support/download: generate even more reproducible tarballs
Date: Sun, 24 Sep 2023 18:05:00 +0200 [thread overview]
Message-ID: <871qenlfpv.fsf@48ers.dk> (raw)
In-Reply-To: <87ecf117f50e4758946f6b0ce54436f09435f4bc.1694556946.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Wed, 13 Sep 2023 00:15:49 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> When we generate the taballs off a local working copy of a VCS tree,
> the umask is the one that we enforce in out top-level Makefile.
> However, it is possible that a user manually tinkers in said working
> copy (e.g. to check an upstream bug fix, or regression). If the user
> umask is different from the one Buildroot enfirces, such tinkering
> can impact the mode bits of the files, even if their content is not
> modified.
> When we eventually need to create a tarball from said working copy,
> the VCS (e.g. git) will only be interested in checking whether the
> content of the files have changed before chcking them out, and will
> not look at, and restore/fix the mode bits.
> As a consequence, we may create non-reproducible archives.
> We fix that by enforcing the mode bits on the files before we create
> the tarball: we disable the write and execute bits, and only set the
> execute bit if the user execute bit is set.
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Vincent Fazio <vfazio@xes-inc.com>
Committed to 2023.02.x, 2023.05.x and 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-24 16:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 22:15 [Buildroot] [PATCH 0/5] support/downloaf/git: add support for git attirbutes (branch yem/git-attributes) Yann E. MORIN
2023-09-12 22:15 ` [Buildroot] [PATCH 1/5] package/qt5: fix upstream git trees Yann E. MORIN
2023-09-13 9:45 ` Thomas Petazzoni via buildroot
2023-09-13 9:55 ` Yann E. MORIN
2023-09-14 21:03 ` Thomas Petazzoni via buildroot
2023-09-17 6:45 ` Peter Korsgaard
2023-09-12 22:15 ` [Buildroot] [PATCH 2/5] support/download: generate even more reproducible tarballs Yann E. MORIN
2023-09-24 16:05 ` Peter Korsgaard [this message]
2023-09-12 22:15 ` [Buildroot] [PATCH 3/5] support/download/git: properly catch failures Yann E. MORIN
2023-09-24 16:05 ` Peter Korsgaard
2023-09-12 22:15 ` [Buildroot] [PATCH 4/5] support/download/git: fix shellcheck errors Yann E. MORIN
2023-09-24 16:05 ` Peter Korsgaard
2023-09-12 22:15 ` [Buildroot] [PATCH 5/5] support/download/git: handle git attributes Yann E. MORIN
2023-09-14 21:07 ` Thomas Petazzoni via buildroot
2023-09-15 7:50 ` Yann E. MORIN
2023-09-17 17:52 ` Arnout Vandecappelle via buildroot
2023-09-17 19:00 ` Yann E. MORIN
2023-09-18 7:38 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qenlfpv.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=vfazio@xes-inc.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.