From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A5D5EE57C1 for ; Fri, 8 Sep 2023 04:30:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 00CF310E85F; Fri, 8 Sep 2023 04:30:08 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id CBD0210E85F for ; Fri, 8 Sep 2023 04:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694147405; x=1725683405; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=vWFAAoVI9IXNrPLJazPn3gFrF4GKNVa4kCpx895HZZw=; b=err4Cfn/20N9P8oE8C13hoc4COBNycKCtOFl7q4hyGE11afQLqc9wMFj eFbYHDA/I20cb04fkp+Mt/NuRElerPy9KoS+2DBcVGCMy3O/XGez+2vF8 DPN5+lyJ44/fzTJVe9l/wgSGvfeASZkPWGfWqnQnCoLM5/YBqsu5B7/q7 wEbg7BXTIx/DdoKtbRoPHJJqaMH5j3wQZfIqzS9xBlExOkxPRoF28AlIq QBT1pe7FronEXhGiEcmHELRMfgQ8T2iOTKF4sX0hUHBDxT4cQWtnc3ce4 Qw9uEbSgOInQsAtXYXYCx83CregAGjcr4SZ92akpB16mEokvQtRJ7wrRL w==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="377462588" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="377462588" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 21:30:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="807852888" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="807852888" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.97.168]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 21:30:04 -0700 Date: Thu, 07 Sep 2023 21:30:03 -0700 Message-ID: <871qf9s2wk.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Vivi, Rodrigo" In-Reply-To: References: <20230808013159.38811-1-ashutosh.dixit@intel.com> <20230808013159.38811-2-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH 01/10] drm/xe/oa: Introduce OA uapi X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dugast, Francois" , "intel-xe@lists.freedesktop.org" Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 31 Aug 2023 12:55:14 -0700, Vivi, Rodrigo wrote: > Rodrigo/Francois, > On Tue, Aug 22, 2023 at 10:31:06AM +0200, Francois Dugast wrote: > > Hi Ashutosh, > > > > On Mon, Aug 07, 2023 at 06:31:50PM -0700, Ashutosh Dixit wrote: > > > OA uapi allows userspace to: > > > * Read streams of performance counters written by hardware > > > * Configure (and reconfigure) which sets of perf counters are captured as > > > part of OA streams > > > * Configure other properties (such as format and periodicity) of such > > > captures. > > > * Query associated parameters such as OA unit timestamp freq, oa_unit_id's > > > for hw engines and OA ioctl version > > > > Also it would be nice to explicit somewhere what OA stands for, maybe > > in the commit message as well. I've added what OA stands for to the commit message of Patch 1. https://patchwork.freedesktop.org/series/121084/#rev5 > > Please document the uapi structures, not only their members. > > Besides that, we need true API like documentation with examples showing > how this is used. Please! We are rapidly changing the OA uapi. uapi changes will be reviewed (including UMD's) and accepted or rejected. I will add such documentation after the uapi is close to being frozen. Thanks. -- Ashutosh