From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF54EB64D8 for ; Wed, 21 Jun 2023 13:08:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232273AbjFUNIj (ORCPT ); Wed, 21 Jun 2023 09:08:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232269AbjFUNIi (ORCPT ); Wed, 21 Jun 2023 09:08:38 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36D951739; Wed, 21 Jun 2023 06:08:37 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QmP2R0Rwzz4wj7; Wed, 21 Jun 2023 23:08:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1687352912; bh=zMmz8eNhn1LuA/bMCpwWPyDta4A4p5omDG9jWVnrIhA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IELwl0a2CcWKtHQYpyrr7sFEKemIZwDa+P3WaQzNRjWOBtKHns7YRnhc4zJ61CtTe VtiNmWT/MSjxIcsMk0GFLElYIRQShuSOZETFrGgT4P/ghqCTLzPcLsUEq+LB9bTV+G ezXrX5eHiHuzHhgKJjcPGV4IhZoXJpyYiZGALWIB3CtTTFesoWwLyio6BWgifN4m/A Hc70Kn6muoGgmoZg4dh2jIQMqgSmiTjtGgniOT6wnQEbMbSiAeTGQxJDLRveCIyS/p RshmiYJ+tckcsHareuzZsBA7Thn4UtJZrdFKcOpxw0gcOY9CUtwyNJDvio492P5yOT 3xClQ4DFwCJvg== From: Michael Ellerman To: Petr Mladek , Andrew Morton , Douglas Anderson Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , sparclinux@vger.kernel.org, "David S . Miller" , linux-perf-users@vger.kernel.org, Petr Mladek Subject: Re: [PATCH v2 6/6] watchdog/hardlockup: Define HARDLOCKUP_DETECTOR_ARCH In-Reply-To: <20230616150618.6073-7-pmladek@suse.com> References: <20230616150618.6073-1-pmladek@suse.com> <20230616150618.6073-7-pmladek@suse.com> Date: Wed, 21 Jun 2023 23:08:26 +1000 Message-ID: <871qi5otdh.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Petr Mladek writes: > The HAVE_ prefix means that the code could be enabled. Add another > variable for HAVE_HARDLOCKUP_DETECTOR_ARCH without this prefix. > It will be set when it should be built. It will make it compatible > with the other hardlockup detectors. > > The change allows to clean up dependencies of PPC_WATCHDOG > and HAVE_HARDLOCKUP_DETECTOR_PERF definitions for powerpc. > > As a result HAVE_HARDLOCKUP_DETECTOR_PERF has the same dependencies > on arm, x86, powerpc architectures. > > Signed-off-by: Petr Mladek > Reviewed-by: Douglas Anderson > --- > arch/powerpc/Kconfig | 5 ++--- > include/linux/nmi.h | 2 +- > lib/Kconfig.debug | 9 +++++++++ > 3 files changed, 12 insertions(+), 4 deletions(-) Something in this patch is breaking the powerpc g5_defconfig, I don't immediately see what though. ../arch/powerpc/kernel/stacktrace.c: In function =E2=80=98handle_backtrace_= ipi=E2=80=99: ../arch/powerpc/kernel/stacktrace.c:171:9: error: implicit declaration of f= unction =E2=80=98nmi_cpu_backtrace=E2=80=99 [-Werror=3Dimplicit-function-de= claration] 171 | nmi_cpu_backtrace(regs); | ^~~~~~~~~~~~~~~~~ ../arch/powerpc/kernel/stacktrace.c: In function =E2=80=98arch_trigger_cpum= ask_backtrace=E2=80=99: ../arch/powerpc/kernel/stacktrace.c:226:9: error: implicit declaration of f= unction =E2=80=98nmi_trigger_cpumask_backtrace=E2=80=99; did you mean =E2= =80=98arch_trigger_cpumask_backtrace=E2=80=99? [-Werror=3Dimplicit-function= -declaration] 226 | nmi_trigger_cpumask_backtrace(mask, exclude_self, raise_bac= ktrace_ipi); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | arch_trigger_cpumask_backtrace cc1: all warnings being treated as errors cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47993EB64D7 for ; Wed, 21 Jun 2023 13:09:29 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=IELwl0a2; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QmP3W2Mc1z3bpk for ; Wed, 21 Jun 2023 23:09:27 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=IELwl0a2; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QmP2W1rXGz30K1 for ; Wed, 21 Jun 2023 23:08:35 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QmP2R0Rwzz4wj7; Wed, 21 Jun 2023 23:08:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1687352912; bh=zMmz8eNhn1LuA/bMCpwWPyDta4A4p5omDG9jWVnrIhA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IELwl0a2CcWKtHQYpyrr7sFEKemIZwDa+P3WaQzNRjWOBtKHns7YRnhc4zJ61CtTe VtiNmWT/MSjxIcsMk0GFLElYIRQShuSOZETFrGgT4P/ghqCTLzPcLsUEq+LB9bTV+G ezXrX5eHiHuzHhgKJjcPGV4IhZoXJpyYiZGALWIB3CtTTFesoWwLyio6BWgifN4m/A Hc70Kn6muoGgmoZg4dh2jIQMqgSmiTjtGgniOT6wnQEbMbSiAeTGQxJDLRveCIyS/p RshmiYJ+tckcsHareuzZsBA7Thn4UtJZrdFKcOpxw0gcOY9CUtwyNJDvio492P5yOT 3xClQ4DFwCJvg== From: Michael Ellerman To: Petr Mladek , Andrew Morton , Douglas Anderson Subject: Re: [PATCH v2 6/6] watchdog/hardlockup: Define HARDLOCKUP_DETECTOR_ARCH In-Reply-To: <20230616150618.6073-7-pmladek@suse.com> References: <20230616150618.6073-1-pmladek@suse.com> <20230616150618.6073-7-pmladek@suse.com> Date: Wed, 21 Jun 2023 23:08:26 +1000 Message-ID: <871qi5otdh.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Nicholas Piggin , sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Petr Mladek writes: > The HAVE_ prefix means that the code could be enabled. Add another > variable for HAVE_HARDLOCKUP_DETECTOR_ARCH without this prefix. > It will be set when it should be built. It will make it compatible > with the other hardlockup detectors. > > The change allows to clean up dependencies of PPC_WATCHDOG > and HAVE_HARDLOCKUP_DETECTOR_PERF definitions for powerpc. > > As a result HAVE_HARDLOCKUP_DETECTOR_PERF has the same dependencies > on arm, x86, powerpc architectures. > > Signed-off-by: Petr Mladek > Reviewed-by: Douglas Anderson > --- > arch/powerpc/Kconfig | 5 ++--- > include/linux/nmi.h | 2 +- > lib/Kconfig.debug | 9 +++++++++ > 3 files changed, 12 insertions(+), 4 deletions(-) Something in this patch is breaking the powerpc g5_defconfig, I don't immediately see what though. ../arch/powerpc/kernel/stacktrace.c: In function =E2=80=98handle_backtrace_= ipi=E2=80=99: ../arch/powerpc/kernel/stacktrace.c:171:9: error: implicit declaration of f= unction =E2=80=98nmi_cpu_backtrace=E2=80=99 [-Werror=3Dimplicit-function-de= claration] 171 | nmi_cpu_backtrace(regs); | ^~~~~~~~~~~~~~~~~ ../arch/powerpc/kernel/stacktrace.c: In function =E2=80=98arch_trigger_cpum= ask_backtrace=E2=80=99: ../arch/powerpc/kernel/stacktrace.c:226:9: error: implicit declaration of f= unction =E2=80=98nmi_trigger_cpumask_backtrace=E2=80=99; did you mean =E2= =80=98arch_trigger_cpumask_backtrace=E2=80=99? [-Werror=3Dimplicit-function= -declaration] 226 | nmi_trigger_cpumask_backtrace(mask, exclude_self, raise_bac= ktrace_ipi); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | arch_trigger_cpumask_backtrace cc1: all warnings being treated as errors cheers