From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6FE9EB64D0 for ; Tue, 13 Jun 2023 13:32:46 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=ecExd3Id; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QgTy51st5z30ff for ; Tue, 13 Jun 2023 23:32:45 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=ecExd3Id; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QgTx51m8vz301c for ; Tue, 13 Jun 2023 23:31:53 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QgTww0NYGz4x4F; Tue, 13 Jun 2023 23:31:43 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1686663112; bh=26xyDyXLr2R9oIQudjRYuumJylpFB2DfYjVBeh6Bfjo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ecExd3IdIr19iytscT8t47baEmFlYjtzeoR4KlaOZcdUtKZeRK4gIAlWkrmJnS+4a GG+21ow407VloXJ6EC0uC6MFNKmjV/6HpTI3DK3OVCM5g5V2VOEJtzRxHI338f7Elm Ng/ar2ndwAnnhazUlq7LOpsJe9Mi9eUtS2B06diFiw4KkSFZYwswcR3R+Le7fcKG1G BhEHlzH7INj+uFvqNAry5BR8IY7pC57shGOiAp6w+6VA8BU+4ttXTEtb/NjMmcPjbD P/yynncDng/VvFvpvSrIpVkcXD6S87Gqct1OHBZv3lk4F63mGLsHK4yK/QgulLJQ26 VP+Jb/nOUYmzQ== From: Michael Ellerman To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Benjamin Herrenschmidt Subject: Re: [PATCH] macintosh: Switch i2c drivers back to use .probe() In-Reply-To: <20230613072044.gqyzostj4yu6yxo4@pengutronix.de> References: <20230523195053.464138-1-u.kleine-koenig@pengutronix.de> <20230613072044.gqyzostj4yu6yxo4@pengutronix.de> Date: Tue, 13 Jun 2023 23:31:39 +1000 Message-ID: <871qifh4jo.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Heikki Krogerus , Ajay Gupta , Peter Senna Tschudin , Sebastian Reichel , Srinivas Pandruvada , Liang He , Jean Delvare , Javier Martinez Canillas , Adrien Grassein , Nathan Chancellor , Colin Leroy , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Jonathan Cameron , Petr Machata , Maximilian Luz , Dmitry Torokhov , Wolfram Sang , kernel@pengutronix.de, Hans Verkuil , linuxppc-dev@lists.ozlabs.org, Peter Rosin Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Uwe Kleine-K=C3=B6nig writes: > On Tue, May 23, 2023 at 09:50:53PM +0200, Uwe Kleine-K=C3=B6nig wrote: >> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() >> call-back type"), all drivers being converted to .probe_new() and then >> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert >> back to (the new) .probe() to be able to eventually drop .probe_new() fr= om >> struct i2c_driver. >>=20 >> Signed-off-by: Uwe Kleine-K=C3=B6nig >> --- >> Hello, >>=20 >> this patch was generated using coccinelle, but I aligned the result to >> the per-file indention. >>=20 >> I chose to convert all drivers below drivers/macintosh in a single >> patch, but if you prefer I can split by driver. >>=20 >> v6.4-rc1 was taken as a base, as there are no commits in next touching >> drivers/macintosh I don't expect problems when applying this patch. If >> conflicts arise until this is applied, feel free to just drop the files >> with conflicts from this patch. I'll care about the fallout later then. >>=20 >> Also note there is no coordination necessary with the i2c tree. Dropping >> .probe_new() will happen only when all (or most) drivers are converted, >> which will happen after v6.5-rc1 for sure. > > Can someone still pick up this patch for v6.5-rc1? Yes, I will. cheers