All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org,  pbonzini@redhat.com,  leobras@redhat.com,
	peterx@redhat.com,  yc-core@yandex-team.ru
Subject: Re: [PATCH 0/5] Restore vmstate on cancelled/failed migration
Date: Thu, 18 May 2023 13:23:56 +0200	[thread overview]
Message-ID: <871qjdevcj.fsf@secure.mitica> (raw)
In-Reply-To: <20230517123752.21615-1-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Wed, 17 May 2023 15:37:47 +0300")

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> Hi all.
>
> The problem I want to solve is that guest-panicked state may be lost
> when migration is failed (or cancelled) after source stop.
>
> Still, I try to go further and restore all possible paused states in the
> same way. The key patch is the last one and others are refactoring and
> preparation.

Hi

I like and agree with the spirit of the series in general.  But I think
that we need to drop the "never fail in global_state_store()".  We
shouldn't kill a guest because we found a bug on migration.

Later, Juan.



  parent reply	other threads:[~2023-05-18 11:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 12:37 [PATCH 0/5] Restore vmstate on cancelled/failed migration Vladimir Sementsov-Ogievskiy
2023-05-17 12:37 ` [PATCH 1/5] runstate: add runstate_get() Vladimir Sementsov-Ogievskiy
2023-05-18 11:13   ` Juan Quintela
2023-05-17 12:37 ` [PATCH 2/5] migration: never fail in global_state_store() Vladimir Sementsov-Ogievskiy
2023-05-18 11:18   ` Juan Quintela
2023-05-18 14:43     ` Vladimir Sementsov-Ogievskiy
2023-05-26  8:28   ` Juan Quintela
2023-05-17 12:37 ` [PATCH 3/5] runstate: drop unused runstate_store() Vladimir Sementsov-Ogievskiy
2023-05-18 11:19   ` Juan Quintela
2023-05-17 12:37 ` [PATCH 4/5] migration: switch from .vm_was_running to .vm_old_state Vladimir Sementsov-Ogievskiy
2023-05-18 11:20   ` Juan Quintela
2023-05-17 12:37 ` [PATCH 5/5] migration: restore vmstate on migration failure Vladimir Sementsov-Ogievskiy
2023-05-18 11:22   ` Juan Quintela
2023-05-18 11:23 ` Juan Quintela [this message]
2023-05-18 14:49   ` [PATCH 0/5] Restore vmstate on cancelled/failed migration Vladimir Sementsov-Ogievskiy
2023-05-26  7:59     ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qjdevcj.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=leobras@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    --cc=yc-core@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.