From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [RFC PATCH] target/arm: properly document FEAT_CRC32
Date: Wed, 22 Feb 2023 13:37:09 +0000 [thread overview]
Message-ID: <871qmhrfby.fsf@linaro.org> (raw)
In-Reply-To: <df642e1c-3c74-5cfc-b1bb-091dfe147fc2@linaro.org>
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 22/2/23 12:01, Alex Bennée wrote:
>> This is a mandatory feature for Armv8.1 architectures but we don't
>> state the feature clearly in our emulation list.
>
> Split in 2 patches?
Its all pretty much a NOP aside from the comments. I split the isar code
just to check my working.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>> While checking verify
>> our cortex-a76 model matches up with the current TRM by breaking out
>> the long form isar into a more modern readable FIELD_DP code.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> docs/system/arm/emulation.rst | 1 +
>> target/arm/cpu64.c | 29 ++++++++++++++++++++++++++---
>> target/arm/cpu_tcg.c | 2 +-
>> 3 files changed, 28 insertions(+), 4 deletions(-)
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-02-22 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 11:01 [RFC PATCH] target/arm: properly document FEAT_CRC32 Alex Bennée
2023-02-22 11:13 ` Philippe Mathieu-Daudé
2023-02-22 13:37 ` Alex Bennée [this message]
2023-02-23 23:01 ` Richard Henderson
2023-02-23 23:22 ` Philippe Mathieu-Daudé
2023-02-23 23:27 ` Richard Henderson
2023-02-24 10:28 ` Philippe Mathieu-Daudé
2023-02-24 9:59 ` Peter Maydell
2023-02-24 15:27 ` Alex Bennée
2023-02-24 13:14 ` Alex Bennée
2023-08-21 15:26 ` Peter Maydell
2023-08-24 7:54 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qmhrfby.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.