All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v1 1/3] arm64/sysreg: Add definition for ICC_NMIAR1_EL1
Date: Wed, 07 Dec 2022 18:33:26 +0000	[thread overview]
Message-ID: <871qpbt66h.wl-maz@kernel.org> (raw)
In-Reply-To: <Y5DYatg7CiOTuClw@sirena.org.uk>

On Wed, 07 Dec 2022 18:16:10 +0000,
Mark Brown <broonie@kernel.org> wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> On Wed, Dec 07, 2022 at 03:08:48PM +0000, Marc Zyngier wrote:
> > Mark Brown <broonie@kernel.org> wrote:
> 
> > > Given the textual conflict with the ISR patch and the fact that the NMI
> > > series needs both anyway it seemed more productive to just carry them
> > > both in the cleanup series even if this one isn't immediately used.
> 
> > I thought the point of this series was to extract stuff that was
> > otherwise useful, independently of the NMI series.
> 
> I tend to view the system register definitions as just generally useful,
> this being system register definitions plus a cleanup that could be done
> on top.

I tend to view the *unused* system register definition as pointless
churn. We'll have to agree to disagree on that one.

> 
> > I must have misunderstood its purpose. This is instead making things
> > harder to follow. Oh well.
> 
> I am hopeful that the extra cognative load of an additional register
> definition will be managable.

You never know.

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v1 1/3] arm64/sysreg: Add definition for ICC_NMIAR1_EL1
Date: Wed, 07 Dec 2022 18:33:26 +0000	[thread overview]
Message-ID: <871qpbt66h.wl-maz@kernel.org> (raw)
In-Reply-To: <Y5DYatg7CiOTuClw@sirena.org.uk>

On Wed, 07 Dec 2022 18:16:10 +0000,
Mark Brown <broonie@kernel.org> wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> On Wed, Dec 07, 2022 at 03:08:48PM +0000, Marc Zyngier wrote:
> > Mark Brown <broonie@kernel.org> wrote:
> 
> > > Given the textual conflict with the ISR patch and the fact that the NMI
> > > series needs both anyway it seemed more productive to just carry them
> > > both in the cleanup series even if this one isn't immediately used.
> 
> > I thought the point of this series was to extract stuff that was
> > otherwise useful, independently of the NMI series.
> 
> I tend to view the system register definitions as just generally useful,
> this being system register definitions plus a cleanup that could be done
> on top.

I tend to view the *unused* system register definition as pointless
churn. We'll have to agree to disagree on that one.

> 
> > I must have misunderstood its purpose. This is instead making things
> > harder to follow. Oh well.
> 
> I am hopeful that the extra cognative load of an additional register
> definition will be managable.

You never know.

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-07 18:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 13:11 [PATCH v1 0/3] arm64/sysreg: ISR register conversions Mark Brown
2022-12-06 13:11 ` Mark Brown
2022-12-06 13:11 ` [PATCH v1 1/3] arm64/sysreg: Add definition for ICC_NMIAR1_EL1 Mark Brown
2022-12-06 13:11   ` Mark Brown
2022-12-07 11:17   ` Marc Zyngier
2022-12-07 11:17     ` Marc Zyngier
2022-12-07 14:39     ` Mark Brown
2022-12-07 14:39       ` Mark Brown
2022-12-07 15:08       ` Marc Zyngier
2022-12-07 15:08         ` Marc Zyngier
2022-12-07 18:16         ` Mark Brown
2022-12-07 18:16           ` Mark Brown
2022-12-07 18:33           ` Marc Zyngier [this message]
2022-12-07 18:33             ` Marc Zyngier
2022-12-06 13:11 ` [PATCH v1 2/3] arm64/sysreg: Add definition of ISR_EL1 Mark Brown
2022-12-06 13:11   ` Mark Brown
2022-12-07 11:17   ` Marc Zyngier
2022-12-07 11:17     ` Marc Zyngier
2022-12-06 13:11 ` [PATCH v1 3/3] KVM: arm64: Use symbolic definition for ISR_EL1.A Mark Brown
2022-12-06 13:11   ` Mark Brown
2022-12-07 11:18   ` Marc Zyngier
2022-12-07 11:18     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qpbt66h.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.