From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C8FCC433FE for ; Fri, 18 Nov 2022 21:56:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBC7910E7DE; Fri, 18 Nov 2022 21:56:32 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id C14E410E7DE; Fri, 18 Nov 2022 21:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668808589; x=1700344589; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=bH0EyRDARlVdRuETRqimsQP/vP4MaOdCZcffacdIu9A=; b=a2BqArIBcEZIEsxBLKmrsZ4WozDKRO1jo8eMWBI5w2d0vU+6wGYUWqWQ 5q18vq0hpVWowsl1AL1uRBmJdKrbIoEBbwXT18VLrw6Ugq8xvaYlyV8lh jvHZoL+EmDBJWSIkK/J4IH9jsLPBYtzaqHb6GQkvx0gbHmGFtWP2W7eMK uGxXNUo1/g3Kx8vFKO6xIvf7eN+5W3ol1V2lu/VIKVUucEt9Fb0xC+tIS 5vm/Tym5Dd2jRM6jWQ8LiPOXAOpj1mpovU662DWtKAfnFAQuYQwYkiPhT e/81xmDXbnDPIMm9BLtjkbKVZe9nMvzsf1aoNw+rOHuMzCb8otdDd1Neo g==; X-IronPort-AV: E=McAfee;i="6500,9779,10535"; a="313272962" X-IronPort-AV: E=Sophos;i="5.96,175,1665471600"; d="scan'208";a="313272962" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 13:56:29 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10535"; a="703894079" X-IronPort-AV: E=Sophos;i="5.96,175,1665471600"; d="scan'208";a="703894079" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.0.78]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 13:56:28 -0800 Date: Fri, 18 Nov 2022 13:37:31 -0800 Message-ID: <871qq0q6zo.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Vivi, Rodrigo" In-Reply-To: References: <20221118183354.1047829-1-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 18 Nov 2022 10:37:37 -0800, Vivi, Rodrigo wrote: > > On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > > From: Vinay Belgaumkar > > > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > > entry on media tile idle messaging need to be enabled. > > > > v2: > > =A0- Fix review comments (Vinay) > > =A0- Set GSC idle hysteresis as per spec (Badal) > > v3: > > =A0- Fix review comments (Rodrigo) > > > > Bspec: 71496 > > > > Cc: Daniele Ceraolo Spurio > > Signed-off-by: Vinay Belgaumkar > > Signed-off-by: Badal Nilawar > > Reviewed-by: Vinay Belgaumkar > > He is the author of the patch, no?! > or you can remove this or change the author to be you and keep his > reviewed-by... > > or I can just remove his rv-b while merging.. just let me know.. Not sure if that is the case here, but when multiple people contribute to a patch, the original author can review changes by others and add his Reviewed-by, no? Or are we saying it is redundant for the author to add his R-b? Similarly, are S-o-b and R-b by the same person ok? I add changes to someone's patch so add my S-o-b but also review other's changes so add my R-b? Sometimes finding a 3rd person to add a R-b is hard. But two poeple can contribute to a patch and review each other's changes so add both their S-o-b's and R-b's or no? :) Ashutosh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73328C4332F for ; Fri, 18 Nov 2022 21:56:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 55C8910E7E0; Fri, 18 Nov 2022 21:56:33 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id C14E410E7DE; Fri, 18 Nov 2022 21:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668808589; x=1700344589; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=bH0EyRDARlVdRuETRqimsQP/vP4MaOdCZcffacdIu9A=; b=a2BqArIBcEZIEsxBLKmrsZ4WozDKRO1jo8eMWBI5w2d0vU+6wGYUWqWQ 5q18vq0hpVWowsl1AL1uRBmJdKrbIoEBbwXT18VLrw6Ugq8xvaYlyV8lh jvHZoL+EmDBJWSIkK/J4IH9jsLPBYtzaqHb6GQkvx0gbHmGFtWP2W7eMK uGxXNUo1/g3Kx8vFKO6xIvf7eN+5W3ol1V2lu/VIKVUucEt9Fb0xC+tIS 5vm/Tym5Dd2jRM6jWQ8LiPOXAOpj1mpovU662DWtKAfnFAQuYQwYkiPhT e/81xmDXbnDPIMm9BLtjkbKVZe9nMvzsf1aoNw+rOHuMzCb8otdDd1Neo g==; X-IronPort-AV: E=McAfee;i="6500,9779,10535"; a="313272962" X-IronPort-AV: E=Sophos;i="5.96,175,1665471600"; d="scan'208";a="313272962" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 13:56:29 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10535"; a="703894079" X-IronPort-AV: E=Sophos;i="5.96,175,1665471600"; d="scan'208";a="703894079" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.0.78]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 13:56:28 -0800 Date: Fri, 18 Nov 2022 13:37:31 -0800 Message-ID: <871qq0q6zo.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Vivi, Rodrigo" Subject: Re: [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS In-Reply-To: References: <20221118183354.1047829-1-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gupta, Anshuman" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "Ewins, Jon" , "Ceraolo Spurio, Daniele" , "Nilawar, Badal" , "Belgaumkar, Vinay" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 18 Nov 2022 10:37:37 -0800, Vivi, Rodrigo wrote: > > On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > > From: Vinay Belgaumkar > > > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > > entry on media tile idle messaging need to be enabled. > > > > v2: > > =A0- Fix review comments (Vinay) > > =A0- Set GSC idle hysteresis as per spec (Badal) > > v3: > > =A0- Fix review comments (Rodrigo) > > > > Bspec: 71496 > > > > Cc: Daniele Ceraolo Spurio > > Signed-off-by: Vinay Belgaumkar > > Signed-off-by: Badal Nilawar > > Reviewed-by: Vinay Belgaumkar > > He is the author of the patch, no?! > or you can remove this or change the author to be you and keep his > reviewed-by... > > or I can just remove his rv-b while merging.. just let me know.. Not sure if that is the case here, but when multiple people contribute to a patch, the original author can review changes by others and add his Reviewed-by, no? Or are we saying it is redundant for the author to add his R-b? Similarly, are S-o-b and R-b by the same person ok? I add changes to someone's patch so add my S-o-b but also review other's changes so add my R-b? Sometimes finding a 3rd person to add a R-b is hard. But two poeple can contribute to a patch and review each other's changes so add both their S-o-b's and R-b's or no? :) Ashutosh