From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFAC7C4332F for ; Mon, 17 Oct 2022 09:58:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231311AbiJQJ63 (ORCPT ); Mon, 17 Oct 2022 05:58:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231514AbiJQJ62 (ORCPT ); Mon, 17 Oct 2022 05:58:28 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD0E25D700; Mon, 17 Oct 2022 02:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666000706; x=1697536706; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=zxbYmgJ1tFJXZUq2wDDYpxgs+/4K8DC3Ye2JTdPk2dI=; b=kgmcE0tZPcS2PXV7vpHunmlGC1cwB9/0X9xfZ4z9ojlX6h6xWpOuw4jx DpsELBkKSt+hU7DEfPuOKWdbTzmQeLuzNHLOdqPQ2lP4ezEJGtaXXrb2Y fZguvN7K8Q7/XSOebEG53I8pGBeWO7CPmta4uVs8o8hFq1xSpnypwmOJo 5shE6JRSH5kl8mciQBzHsi6x3adALvU4F5MBImKpiuyv5QrAC0CQNozNU kqULGOuigWG4QqIyHSaHb3DMPNwHQhboK5MSpExK/WMcfz4oKcr49o8SS Le3tjjQ4HehYWSxSXiSKQhwadcwUmQ/Ja21eeWmhMFNExD8uweh70tA9I w==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="285480892" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="285480892" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 02:58:26 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="630627154" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="630627154" Received: from cgarnier-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.44.27]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 02:58:23 -0700 From: Jani Nikula To: Inki Dae , hongao , jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, daniel@ffwll.ch, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi In-Reply-To: <4e8d94c9-7dc0-039f-7d67-36f6c099ab75@samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220616072233.8302-1-hongao@uniontech.com> <4e8d94c9-7dc0-039f-7d67-36f6c099ab75@samsung.com> Date: Mon, 17 Oct 2022 12:59:03 +0300 Message-ID: <871qr6srdk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Fri, 24 Jun 2022, Inki Dae wrote: > 22. 6. 16. 16:22=EC=97=90 hongao =EC=9D=B4(=EA=B0=80) =EC=93=B4 =EA=B8=80: >> Once EDID is parsed, the monitor HDMI support information is available >> through drm_display_info.is_hdmi. >>=20 >> This driver calls drm_detect_hdmi_monitor() to receive the same >> information, which is less efficient. >>=20 >> Avoid calling drm_detect_hdmi_monitor() and use drm_display_info.is_hdmi >> instead. >>=20 > > Applied. Sorry, but this is broken. The commit message contains the clue: "Once EDID is parsed". drm_get_edid() does not parse the EDID, you need to call drm_connector_update_edid_property() first. This is what I posted some time ago [1] but apparently was working on a different baseline. BR, Jani. [1] https://patchwork.freedesktop.org/patch/msgid/f21588dcb93bdb6cf76724506= 063bdfcdb0a6bb4.1662036058.git.jani.nikula@intel.com > > Thanks, > Inki Dae > >> Signed-off-by: hongao >> --- >> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exyn= os/exynos_hdmi.c >> index 7655142a4651..17e9f5efbcfc 100644 >> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c >> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c >> @@ -893,7 +893,7 @@ static int hdmi_get_modes(struct drm_connector *conn= ector) >> if (!edid) >> return -ENODEV; >>=20=20 >> - hdata->dvi_mode =3D !drm_detect_hdmi_monitor(edid); >> + hdata->dvi_mode =3D !connector->display_info.is_hdmi; >> DRM_DEV_DEBUG_KMS(hdata->dev, "%s : width[%d] x height[%d]\n", >> (hdata->dvi_mode ? "dvi monitor" : "hdmi monitor"), >> edid->width_cm, edid->height_cm); --=20 Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7761AC433FE for ; Mon, 17 Oct 2022 09:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8IPLiIata9ZORVOa25dD2vJBoQxWOqW1gvvQ1EUe1cc=; b=StKGyjoolbccAL sVKsoNPCo9gUf54ejNK8bO16gPEr2Im/mhTa0IAR5O2EBc9hjJ+xRX3zYQeW9nJsddqcwkQGRFtYb hnzLwzZ7Xh68gHl3AvBzHW0VvLqADTl7yRK3Q1Yl4gDd1TJuzrSGHvuBmyxNVZHbyI1F9i4A7lmUG hsFNiK0t1s6g6hkptsw4GzoggYHMq9nYFjrTV0IU7C4iPmDpQW+XLSG7P7bFe+8R45FKtkqVGO/z6 wmTKmKShu1cYgeX8rW0h537raJaQSG2phARn0IEnNgL0PO3WEae+lj4oNqEL3TQh1s3BRnQUd2pnu OVXtK2URNLEz9U6qPYnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okMtG-00A7hc-IC; Mon, 17 Oct 2022 09:58:34 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okMtB-00A7R9-JU for linux-arm-kernel@lists.infradead.org; Mon, 17 Oct 2022 09:58:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666000709; x=1697536709; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=zxbYmgJ1tFJXZUq2wDDYpxgs+/4K8DC3Ye2JTdPk2dI=; b=kUILLeC/D6gZTPnKR5VnEPyS/6ROMsFiGbhU1pB5Viw65AF84L8/D9ml nLIKTOYnkGeVLjA/9iZ1Tj25ZjRAfAkH9gPdPktTGT8LSVweiIq3NVxs+ 2Wg3QQ9FSz2FO4f2fBA3De9Xa00zcftJwSp2FA/v7+X6rL2KErsT/bqJc G2aJhIXvAPEMjQifPWDBU5/SfqnFvzTqKRD/WB9brLbBb4HCJDeszzMhZ 3ZWE7AoQKvLGgx5pM3aslvdct/v/FHgvs1nRAvIlY8FnAltwf1sc5684F MWLqDHG/7WUc3MVCsvPLICs1SS1Zb4AYYmZsZR+bNuPZZ9y+4DefODR8i A==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="285480893" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="285480893" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 02:58:26 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="630627154" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="630627154" Received: from cgarnier-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.44.27]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 02:58:23 -0700 From: Jani Nikula To: Inki Dae , hongao , jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, daniel@ffwll.ch, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi In-Reply-To: <4e8d94c9-7dc0-039f-7d67-36f6c099ab75@samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220616072233.8302-1-hongao@uniontech.com> <4e8d94c9-7dc0-039f-7d67-36f6c099ab75@samsung.com> Date: Mon, 17 Oct 2022 12:59:03 +0300 Message-ID: <871qr6srdk.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221017_025829_683201_4CF23981 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyNCBKdW4gMjAyMiwgSW5raSBEYWUgPGlua2kuZGFlQHNhbXN1bmcuY29tPiB3cm90 ZToKPiAyMi4gNi4gMTYuIDE2OjIy7JeQIGhvbmdhbyDsnbQo6rCAKSDsk7Qg6riAOgo+PiBPbmNl IEVESUQgaXMgcGFyc2VkLCB0aGUgbW9uaXRvciBIRE1JIHN1cHBvcnQgaW5mb3JtYXRpb24gaXMg YXZhaWxhYmxlCj4+IHRocm91Z2ggZHJtX2Rpc3BsYXlfaW5mby5pc19oZG1pLgo+PiAKPj4gVGhp cyBkcml2ZXIgY2FsbHMgZHJtX2RldGVjdF9oZG1pX21vbml0b3IoKSB0byByZWNlaXZlIHRoZSBz YW1lCj4+IGluZm9ybWF0aW9uLCB3aGljaCBpcyBsZXNzIGVmZmljaWVudC4KPj4gCj4+IEF2b2lk IGNhbGxpbmcgZHJtX2RldGVjdF9oZG1pX21vbml0b3IoKSBhbmQgdXNlIGRybV9kaXNwbGF5X2lu Zm8uaXNfaGRtaQo+PiBpbnN0ZWFkLgo+PiAKPgo+IEFwcGxpZWQuCgpTb3JyeSwgYnV0IHRoaXMg aXMgYnJva2VuLiBUaGUgY29tbWl0IG1lc3NhZ2UgY29udGFpbnMgdGhlIGNsdWU6ICJPbmNlCkVE SUQgaXMgcGFyc2VkIi4gZHJtX2dldF9lZGlkKCkgZG9lcyBub3QgcGFyc2UgdGhlIEVESUQsIHlv dSBuZWVkIHRvCmNhbGwgZHJtX2Nvbm5lY3Rvcl91cGRhdGVfZWRpZF9wcm9wZXJ0eSgpIGZpcnN0 LgoKVGhpcyBpcyB3aGF0IEkgcG9zdGVkIHNvbWUgdGltZSBhZ28gWzFdIGJ1dCBhcHBhcmVudGx5 IHdhcyB3b3JraW5nIG9uIGEKZGlmZmVyZW50IGJhc2VsaW5lLgoKQlIsCkphbmkuCgoKWzFdIGh0 dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9tc2dpZC9mMjE1ODhkY2I5M2Jk YjZjZjc2NzI0NTA2MDYzYmRmY2RiMGE2YmI0LjE2NjIwMzYwNTguZ2l0LmphbmkubmlrdWxhQGlu dGVsLmNvbQoKCj4KPiBUaGFua3MsCj4gSW5raSBEYWUKPgo+PiBTaWduZWQtb2ZmLWJ5OiBob25n YW8gPGhvbmdhb0B1bmlvbnRlY2guY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9leHlu b3MvZXh5bm9zX2hkbWkuYyB8IDIgKy0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgMSBkZWxldGlvbigtKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlu b3MvZXh5bm9zX2hkbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2hkbWkuYwo+ PiBpbmRleCA3NjU1MTQyYTQ2NTEuLjE3ZTlmNWVmYmNmYyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2V4eW5vcy9leHlub3NfaGRtaS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9l eHlub3MvZXh5bm9zX2hkbWkuYwo+PiBAQCAtODkzLDcgKzg5Myw3IEBAIHN0YXRpYyBpbnQgaGRt aV9nZXRfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPj4gIAlpZiAoIWVk aWQpCj4+ICAJCXJldHVybiAtRU5PREVWOwo+PiAgCj4+IC0JaGRhdGEtPmR2aV9tb2RlID0gIWRy bV9kZXRlY3RfaGRtaV9tb25pdG9yKGVkaWQpOwo+PiArCWhkYXRhLT5kdmlfbW9kZSA9ICFjb25u ZWN0b3ItPmRpc3BsYXlfaW5mby5pc19oZG1pOwo+PiAgCURSTV9ERVZfREVCVUdfS01TKGhkYXRh LT5kZXYsICIlcyA6IHdpZHRoWyVkXSB4IGhlaWdodFslZF1cbiIsCj4+ICAJCQkgIChoZGF0YS0+ ZHZpX21vZGUgPyAiZHZpIG1vbml0b3IiIDogImhkbWkgbW9uaXRvciIpLAo+PiAgCQkJICBlZGlk LT53aWR0aF9jbSwgZWRpZC0+aGVpZ2h0X2NtKTsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3Bl biBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FAD2C4332F for ; Mon, 17 Oct 2022 09:58:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7265C10E06E; Mon, 17 Oct 2022 09:58:33 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5179410E06E for ; Mon, 17 Oct 2022 09:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666000707; x=1697536707; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=zxbYmgJ1tFJXZUq2wDDYpxgs+/4K8DC3Ye2JTdPk2dI=; b=M9AzgdokEvj0J9GSDgW/QUb9+r8XcakrqC6BuIpk5rHNOO4pMXVlVcUU bMjALR1bhVKr2PluamYm2bWnArSDjUH8Pp3pYvk+RCdlmE4YNg1wz9RoT soL9aE7n98kOsArJTNYfGuIRrfG3F1y9AMmta/RIJg+L+x/ZXM2tiFJrH Y+5Lf2gso0w561M6RdpshOn2lOB+TX+hZ2+xBZGfqd504SiTBLolm1dii u1PJC80i84NBx/nx4YdT3rOQYDTlYA3og/jmX4q3SNFsZarlY34b8Lqe5 SXHR7tLXcfYOFU+qYNq5ZldoEy35cwB6EZrYAGp85fi3DIE3N+aPoXR1O Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="286146963" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="286146963" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 02:58:26 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="630627154" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="630627154" Received: from cgarnier-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.44.27]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 02:58:23 -0700 From: Jani Nikula To: Inki Dae , hongao , jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, daniel@ffwll.ch, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com Subject: Re: [PATCH] drm/exynos: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi In-Reply-To: <4e8d94c9-7dc0-039f-7d67-36f6c099ab75@samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220616072233.8302-1-hongao@uniontech.com> <4e8d94c9-7dc0-039f-7d67-36f6c099ab75@samsung.com> Date: Mon, 17 Oct 2022 12:59:03 +0300 Message-ID: <871qr6srdk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 24 Jun 2022, Inki Dae wrote: > 22. 6. 16. 16:22=EC=97=90 hongao =EC=9D=B4(=EA=B0=80) =EC=93=B4 =EA=B8=80: >> Once EDID is parsed, the monitor HDMI support information is available >> through drm_display_info.is_hdmi. >>=20 >> This driver calls drm_detect_hdmi_monitor() to receive the same >> information, which is less efficient. >>=20 >> Avoid calling drm_detect_hdmi_monitor() and use drm_display_info.is_hdmi >> instead. >>=20 > > Applied. Sorry, but this is broken. The commit message contains the clue: "Once EDID is parsed". drm_get_edid() does not parse the EDID, you need to call drm_connector_update_edid_property() first. This is what I posted some time ago [1] but apparently was working on a different baseline. BR, Jani. [1] https://patchwork.freedesktop.org/patch/msgid/f21588dcb93bdb6cf76724506= 063bdfcdb0a6bb4.1662036058.git.jani.nikula@intel.com > > Thanks, > Inki Dae > >> Signed-off-by: hongao >> --- >> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exyn= os/exynos_hdmi.c >> index 7655142a4651..17e9f5efbcfc 100644 >> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c >> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c >> @@ -893,7 +893,7 @@ static int hdmi_get_modes(struct drm_connector *conn= ector) >> if (!edid) >> return -ENODEV; >>=20=20 >> - hdata->dvi_mode =3D !drm_detect_hdmi_monitor(edid); >> + hdata->dvi_mode =3D !connector->display_info.is_hdmi; >> DRM_DEV_DEBUG_KMS(hdata->dev, "%s : width[%d] x height[%d]\n", >> (hdata->dvi_mode ? "dvi monitor" : "hdmi monitor"), >> edid->width_cm, edid->height_cm); --=20 Jani Nikula, Intel Open Source Graphics Center