All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	kuba@kernel.org, miguel.ojeda.sandonis@gmail.com,
	ojeda@kernel.org, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, asml.silence@gmail.com, imagedong@tencent.com,
	luiz.von.dentz@intel.com, vasily.averin@linux.dev,
	jk@codeconstruct.com.au, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, kernel test robot <lkp@intel.com>,
	linux-toolchains <linux-toolchains@vger.kernel.org>
Subject: Re: [PATCH net-next v4] net: skb: prevent the split of kfree_skb_reason() by gcc
Date: Mon, 22 Aug 2022 10:01:46 +0200	[thread overview]
Message-ID: <871qt86711.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CADxym3Y-=6pRP=CunxRomfwXf58k0LyLm510WGtzsBnzjqdD4g@mail.gmail.com> (Menglong Dong's message of "Sat, 20 Aug 2022 19:00:41 +0800")

* Menglong Dong:

> /*
>  * Used by functions that use '__builtin_return_address'. These function
>  * don't want to be splited or made inline, which can make
>  * the '__builtin_return_address' got unexpected address.
>  */
> #define __fix_address noinline __noclone

You need something on the function *declaration* as well, to inhibit
sibcalls.

Thanks,
Florian


  reply	other threads:[~2022-08-22  8:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16  3:28 [PATCH net-next v4] net: skb: prevent the split of kfree_skb_reason() by gcc menglong8.dong
2022-08-16  9:02 ` Miguel Ojeda
2022-08-17  2:20   ` Menglong Dong
2022-08-17  5:54     ` Miguel Ojeda
2022-08-17 15:54 ` Nick Desaulniers
2022-08-18 16:31   ` Menglong Dong
2022-08-18 16:58     ` Segher Boessenkool
2022-08-19 14:55       ` Menglong Dong
2022-08-19 15:21         ` Segher Boessenkool
2022-08-20 11:00           ` Menglong Dong
2022-08-22  8:01             ` Florian Weimer [this message]
2022-08-23 16:23               ` Menglong Dong
2022-09-06 12:37                 ` Florian Weimer
2022-09-06 15:30                   ` Segher Boessenkool
2022-09-07 18:59                     ` Florian Weimer
2022-09-07 19:47                       ` Segher Boessenkool
2022-08-18 17:09 ` Jakub Kicinski
2022-08-19 15:17   ` Menglong Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qt86711.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=asml.silence@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=imagedong@tencent.com \
    --cc=jk@codeconstruct.com.au \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-toolchains@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=luiz.von.dentz@intel.com \
    --cc=menglong8.dong@gmail.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=pabeni@redhat.com \
    --cc=segher@kernel.crashing.org \
    --cc=vasily.averin@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.