From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72D97C433EF for ; Thu, 23 Jun 2022 17:00:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B1E8210E134; Thu, 23 Jun 2022 17:00:51 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BD1A10E134; Thu, 23 Jun 2022 17:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656003650; x=1687539650; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=J9s/LpFILeLPTlseYxUrJteIVRlhiZdWHoHvHoBnIYU=; b=lro7qkdeGo3BFuiX4LytnMZ8C9e3/vrt1S+Re5Te5IvtIGNmIUZQg+Ce s3U5TVZjgK9lc+2aSC7oT/ztIQHKkTYL9UXjbiM+XYKZsDrZQJ0uXRhPd RftWyIFbLxFzhyWzDoRwrPeH2Kcdy3mAlX6erVl/gR4Mu8+YZvUAcrADI MfCC6d9oQ1Sf/QvSRxDbpcxx5sCq+KDxkHbo3z2WBgQJJSUuxXJdmeIBs 3TW2QgWT84yxMNuxEypeesTKEELEh6hU8JPgo+l+ysHeZd6OE8qi4cfv3 KPnUd9951nmCQcUIszwdk9v0mcLwjCTujLQ2DpdlqRhT83kpR3xA8WqmA A==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="261209487" X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="261209487" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:00:20 -0700 X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="834723685" Received: from anefedov-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.38.20]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:00:15 -0700 From: Jani Nikula To: Jiang Jian , airlied@linux.ie, daniel@ffwll.ch In-Reply-To: <20220623101113.28470-1-jiangjian@cdjrlc.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220623101113.28470-1-jiangjian@cdjrlc.com> Date: Thu, 23 Jun 2022 20:00:11 +0300 Message-ID: <871qvfnwmc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] GPU: drm: i915: drop unexpected word 'for' in comments X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jiang Jian , rodrigo.vivi@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 23 Jun 2022, Jiang Jian wrote: > there is an unexpected word 'for' in the comments that need to be dropped While it's also unexpected, it's really *duplicated* word. > file - drivers/gpu/drm/i915/i915_reg.h > line - 2537 > > * Please check the detailed lore in the commit message for for experimental > > changed to: > > * Please check the detailed lore in the commit message for experimental > The above is just duplication of the patch itself, and completely unnecessary. The patch subject prefix should be something like "drm/i915:" or "drm/i915/reg:". Pro-tip for figuring out good guesses of what the subject prefix should be: $ git log --since={5-year} --no-merges --pretty=format:%s -- drivers/gpu/drm/i915/i915_reg.h | sed 's/:.*//' | sort | uniq -c | sort -rn | head 312 drm/i915 113 drm/i915/icl 57 drm/i915/tgl 26 drm/i915/cnl 25 drm/i915/display 22 drm/i915/dg2 16 drm/i915/psr 14 drm/i915/gt 14 drm/i915/adl_p 12 drm/i915/dg1 The patch itself is fine, but I'm nitpicking on the commit message because I've seen lots of patches like this, with the same kind of stuff in the commit messages. BR, Jani. > Signed-off-by: Jiang Jian > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 616164fa2e32..738c020396af 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -2534,7 +2534,7 @@ > * HDMI/DP bits are g4x+ > * > * WARNING: Bspec for hpd status bits on gen4 seems to be completely confused. > - * Please check the detailed lore in the commit message for for experimental > + * Please check the detailed lore in the commit message for experimental > * evidence. > */ > /* Bspec says GM45 should match G4X/VLV/CHV, but reality disagrees */ -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14582CCA47C for ; Thu, 23 Jun 2022 17:00:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C79D810E25F; Thu, 23 Jun 2022 17:00:51 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BD1A10E134; Thu, 23 Jun 2022 17:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656003650; x=1687539650; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=J9s/LpFILeLPTlseYxUrJteIVRlhiZdWHoHvHoBnIYU=; b=lro7qkdeGo3BFuiX4LytnMZ8C9e3/vrt1S+Re5Te5IvtIGNmIUZQg+Ce s3U5TVZjgK9lc+2aSC7oT/ztIQHKkTYL9UXjbiM+XYKZsDrZQJ0uXRhPd RftWyIFbLxFzhyWzDoRwrPeH2Kcdy3mAlX6erVl/gR4Mu8+YZvUAcrADI MfCC6d9oQ1Sf/QvSRxDbpcxx5sCq+KDxkHbo3z2WBgQJJSUuxXJdmeIBs 3TW2QgWT84yxMNuxEypeesTKEELEh6hU8JPgo+l+ysHeZd6OE8qi4cfv3 KPnUd9951nmCQcUIszwdk9v0mcLwjCTujLQ2DpdlqRhT83kpR3xA8WqmA A==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="261209487" X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="261209487" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:00:20 -0700 X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="834723685" Received: from anefedov-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.38.20]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:00:15 -0700 From: Jani Nikula To: Jiang Jian , airlied@linux.ie, daniel@ffwll.ch Subject: Re: [PATCH] GPU: drm: i915: drop unexpected word 'for' in comments In-Reply-To: <20220623101113.28470-1-jiangjian@cdjrlc.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220623101113.28470-1-jiangjian@cdjrlc.com> Date: Thu, 23 Jun 2022 20:00:11 +0300 Message-ID: <871qvfnwmc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jiang Jian , rodrigo.vivi@intel.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 23 Jun 2022, Jiang Jian wrote: > there is an unexpected word 'for' in the comments that need to be dropped While it's also unexpected, it's really *duplicated* word. > file - drivers/gpu/drm/i915/i915_reg.h > line - 2537 > > * Please check the detailed lore in the commit message for for experimental > > changed to: > > * Please check the detailed lore in the commit message for experimental > The above is just duplication of the patch itself, and completely unnecessary. The patch subject prefix should be something like "drm/i915:" or "drm/i915/reg:". Pro-tip for figuring out good guesses of what the subject prefix should be: $ git log --since={5-year} --no-merges --pretty=format:%s -- drivers/gpu/drm/i915/i915_reg.h | sed 's/:.*//' | sort | uniq -c | sort -rn | head 312 drm/i915 113 drm/i915/icl 57 drm/i915/tgl 26 drm/i915/cnl 25 drm/i915/display 22 drm/i915/dg2 16 drm/i915/psr 14 drm/i915/gt 14 drm/i915/adl_p 12 drm/i915/dg1 The patch itself is fine, but I'm nitpicking on the commit message because I've seen lots of patches like this, with the same kind of stuff in the commit messages. BR, Jani. > Signed-off-by: Jiang Jian > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 616164fa2e32..738c020396af 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -2534,7 +2534,7 @@ > * HDMI/DP bits are g4x+ > * > * WARNING: Bspec for hpd status bits on gen4 seems to be completely confused. > - * Please check the detailed lore in the commit message for for experimental > + * Please check the detailed lore in the commit message for experimental > * evidence. > */ > /* Bspec says GM45 should match G4X/VLV/CHV, but reality disagrees */ -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAD4C433EF for ; Thu, 23 Jun 2022 17:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233493AbiFWRUT (ORCPT ); Thu, 23 Jun 2022 13:20:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233970AbiFWRSa (ORCPT ); Thu, 23 Jun 2022 13:18:30 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89A789B550 for ; Thu, 23 Jun 2022 10:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656003624; x=1687539624; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=J9s/LpFILeLPTlseYxUrJteIVRlhiZdWHoHvHoBnIYU=; b=gc7Wx7vCmeJZE0/Wb6nF63L3okTIW8USO6hva5J5G1MY0STnW3VqVguP KtWwrAwcPEifNqPp57Zqw/gSIzuqR0xztpQ/P9YytI1eOqDJzL5gG40V/ rYDxZzJZi7VO/sf26np0Ij83r5OhD7TCLfdvfGCmDPoLBAYnyG1Ll7iQV 15fl5DQnllCAY6e1M85VVZ9zAP81FvqXQAMOsg4gcMxifXc0R44KXJYAm HXqfNgUV7Zj1giGl+EdzpEPUFH9B0dwCUQ5PrzvX87t6boWP32FrJqjDp DfCiqJrrPIXIPtMfoOZd3uUv5ngkSuEZGPT2RCVCNh96xm9SzP766QpQn w==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="279544659" X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="279544659" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:00:20 -0700 X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="834723685" Received: from anefedov-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.38.20]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 10:00:15 -0700 From: Jani Nikula To: Jiang Jian , airlied@linux.ie, daniel@ffwll.ch Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiang Jian Subject: Re: [PATCH] GPU: drm: i915: drop unexpected word 'for' in comments In-Reply-To: <20220623101113.28470-1-jiangjian@cdjrlc.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220623101113.28470-1-jiangjian@cdjrlc.com> Date: Thu, 23 Jun 2022 20:00:11 +0300 Message-ID: <871qvfnwmc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Jun 2022, Jiang Jian wrote: > there is an unexpected word 'for' in the comments that need to be dropped While it's also unexpected, it's really *duplicated* word. > file - drivers/gpu/drm/i915/i915_reg.h > line - 2537 > > * Please check the detailed lore in the commit message for for experimental > > changed to: > > * Please check the detailed lore in the commit message for experimental > The above is just duplication of the patch itself, and completely unnecessary. The patch subject prefix should be something like "drm/i915:" or "drm/i915/reg:". Pro-tip for figuring out good guesses of what the subject prefix should be: $ git log --since={5-year} --no-merges --pretty=format:%s -- drivers/gpu/drm/i915/i915_reg.h | sed 's/:.*//' | sort | uniq -c | sort -rn | head 312 drm/i915 113 drm/i915/icl 57 drm/i915/tgl 26 drm/i915/cnl 25 drm/i915/display 22 drm/i915/dg2 16 drm/i915/psr 14 drm/i915/gt 14 drm/i915/adl_p 12 drm/i915/dg1 The patch itself is fine, but I'm nitpicking on the commit message because I've seen lots of patches like this, with the same kind of stuff in the commit messages. BR, Jani. > Signed-off-by: Jiang Jian > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 616164fa2e32..738c020396af 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -2534,7 +2534,7 @@ > * HDMI/DP bits are g4x+ > * > * WARNING: Bspec for hpd status bits on gen4 seems to be completely confused. > - * Please check the detailed lore in the commit message for for experimental > + * Please check the detailed lore in the commit message for experimental > * evidence. > */ > /* Bspec says GM45 should match G4X/VLV/CHV, but reality disagrees */ -- Jani Nikula, Intel Open Source Graphics Center