All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Emily Shaffer" <emilyshaffer@google.com>,
	"René Scharfe" <l.s.r@web.de>, "Jeff King" <peff@github.com>,
	"Phillip Wood" <phillip.wood123@gmail.com>
Subject: ab/config-based-hooks-1
Date: Fri, 01 Oct 2021 17:07:34 +0200	[thread overview]
Message-ID: <871r54rd9c.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqh7e18soj.fsf@gitster.g>


On Thu, Sep 30 2021, Junio C Hamano wrote:

> * ab/config-based-hooks-1 (2021-09-27) 8 commits
>  - hook-list.h: add a generated list of hooks, like config-list.h
>  - hook.c users: use "hook_exists()" instead of "find_hook()"
>  - hook.c: add a hook_exists() wrapper and use it in bugreport.c
>  - hook.[ch]: move find_hook() from run-command.c to hook.c
>  - Makefile: remove an out-of-date comment
>  - Makefile: don't perform "mv $@+ $@" dance for $(GENERATED_H)
>  - Makefile: stop hardcoding {command,config}-list.h
>  - Makefile: mark "check" target as .PHONY
>
>  Mostly preliminary clean-up in the hook API.

I think this has gotten some thorough review from René & Phillip at this
point[1][2]. I think th consensus on the v2 is to just keep the "sed"
invocation I have as-is.

As you know the greater configurable hook topic is pending on this
moving forward, so starting to get at least some of it merged down
before 2.34 would be great. I was hoping we'd have a release with at
least the simpler hooks running via the new hook library (and perhaps
the --stdin cases too).

1. https://lore.kernel.org/git/0e07cee4-079a-af12-880f-d4a99300df28@web.de/
2. https://lore.kernel.org/git/6e7d5945-d64f-9511-9668-b453c20c086c@gmail.com/

      parent reply	other threads:[~2021-10-01 15:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01  1:01 What's cooking in git.git (Sep 2021, #09; Thu, 30) Junio C Hamano
2021-10-01  6:20 ` en/removing-untracked-fixes [Was: Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)] Elijah Newren
2021-10-01  8:51   ` Ævar Arnfjörð Bjarmason
2021-10-01 17:05   ` en/removing-untracked-fixes [ Junio C Hamano
2021-10-01  6:31 ` en/remerge-diff [Was: Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)] Elijah Newren
2021-10-01  7:01   ` Jeff King
2021-10-01 12:05 ` What's cooking in git.git (Sep 2021, #09; Thu, 30) Ævar Arnfjörð Bjarmason
2021-10-01 12:08 ` ab/fsck-unexpected-type Ævar Arnfjörð Bjarmason
2021-10-01 14:32 ` ab/parse-options-cleanup Ævar Arnfjörð Bjarmason
2021-10-01 14:35 ` ab/sanitize-leak-ci & more leak fixes soon-or-not Ævar Arnfjörð Bjarmason
2021-10-01 14:48 ` ab/refs-errno-cleanup Ævar Arnfjörð Bjarmason
2021-10-01 14:56 ` What's cooking in git.git (Sep 2021, #09; Thu, 30) Jeff Hostetler
2021-10-01 15:01 ` ab/align-parse-options-help & ab/help-config-vars Ævar Arnfjörð Bjarmason
2021-10-01 15:05 ` ab/lib-subtest Ævar Arnfjörð Bjarmason
2021-10-01 15:07 ` Ævar Arnfjörð Bjarmason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r54rd9c.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=l.s.r@web.de \
    --cc=peff@github.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.