All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Arjun Melkaveri <arjun.melkaveri@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Resolve missing context for independent subtest
Date: Mon, 30 Aug 2021 11:43:00 -0700	[thread overview]
Message-ID: <871r6awz7v.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20210829201559.656-1-arjun.melkaveri@intel.com>

On Sun, 29 Aug 2021 13:15:59 -0700, Arjun Melkaveri wrote:
>
> @@ -380,22 +381,24 @@ static void independent(int fd, const intel_ctx_t *ctx, unsigned int engine,
>		if (!gem_class_can_store_dword(fd, e->class))
>			continue;
>
> +		tmp_ctx = intel_ctx_create(fd, &ctx->cfg);
>		if (spin == NULL) {
>			spin = __igt_spin_new(fd,
>					      .ahnd = ahnd,
> -					      .ctx = ctx,
> +					      .ctx = tmp_ctx,
>					      .engine = e->flags,
>					      .flags = flags);
>		} else {
>			struct drm_i915_gem_execbuffer2 eb = {
>				.buffer_count = 1,
>				.buffers_ptr = to_user_pointer(&spin->obj[IGT_SPIN_BATCH]),
> +				.rsvd1 = tmp_ctx->id,

.rsvd1 is definitely missing which should explain the assert for
gem_execbuf, but looks like we should not need a new "tmp_ctx" but should
be able to submit against the original "ctx", so all we need is:

				.rsvd1 = ctx->id,

  parent reply	other threads:[~2021-08-30 18:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29 20:15 [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Resolve missing context for independent subtest Arjun Melkaveri
2021-08-29 21:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-08-29 22:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-08-30 18:43 ` Dixit, Ashutosh [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-30 19:59 [igt-dev] [PATCH i-g-t] " Arjun Melkaveri
2021-08-30 20:00 Arjun Melkaveri
2021-08-30 20:47 ` Dixit, Ashutosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r6awz7v.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=arjun.melkaveri@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.