From: Thomas Gleixner <tglx@linutronix.de>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Bjorn Helgaas <bhelgaas@google.com>,
x86@kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] x86/pci: Add missing forward declaration for pci_numachip_init()
Date: Thu, 12 Aug 2021 17:05:59 +0200 [thread overview]
Message-ID: <871r6yityg.ffs@tglx> (raw)
In-Reply-To: <20210729234059.1509820-1-kw@linux.com>
On Thu, Jul 29 2021 at 23:40, Krzysztof Wilczyński wrote:
> At the moment, the function pci_numachip_init() is defined in the
> numachip.c file. Since this function has users outside of this file,
> add missing foward declaration to the pci_x86.h file.
>
> This resolves the following sparse and compile time warning:
>
> arch/x86/pci/numachip.c:108:12: warning: no previous prototype for function 'pci_numachip_init' [-Wmissing-prototypes]
> arch/x86/pci/numachip.c:108:12: warning: symbol 'pci_numachip_init'
> was not declared. Should it be static?
No. arch/x86/pci/numachip.c simply lacks
#include <asm/numachip/numachip.h>
Thanks,
tglx
prev parent reply other threads:[~2021-08-12 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 23:40 [PATCH] x86/pci: Add missing forward declaration for pci_numachip_init() Krzysztof Wilczyński
2021-07-30 21:19 ` Bjorn Helgaas
2021-08-12 15:14 ` Thomas Gleixner
2021-08-12 16:11 ` Krzysztof Wilczyński
2021-08-12 15:05 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r6yityg.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.