From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mDKyD-0006gc-DB for mharc-qemu-riscv@gnu.org; Tue, 10 Aug 2021 02:10:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKyC-0006cN-9z for qemu-riscv@nongnu.org; Tue, 10 Aug 2021 02:10:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKy6-0006qF-Gs for qemu-riscv@nongnu.org; Tue, 10 Aug 2021 02:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628575829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=58RL47eWZyCzhgKuqtiABHxb0t+kFvojCVqufK2R/OA=; b=EeDf4e5GqGDTeOOUuFpV5iTIw3AmR4MwZ5qg791iHhsvkKvDzTO+TkW+UefAUC8gjQGqqF HSVF1I4NXw+C35F+ZH0GbpQHd9l/2Ht1oDw7TGwvXfvv+SGfasHcJ82D9HCwdVDZ5zEBi0 8NlWrlAxRNJ5co766klXQV50Ic5UsHY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-GRn88WI7OIuByXOBbE3BTw-1; Tue, 10 Aug 2021 02:10:28 -0400 X-MC-Unique: GRn88WI7OIuByXOBbE3BTw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BB211853038; Tue, 10 Aug 2021 06:10:24 +0000 (UTC) Received: from localhost (unknown [10.39.192.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30ADB5D9C6; Tue, 10 Aug 2021 06:09:57 +0000 (UTC) From: Cornelia Huck To: Eduardo Habkost , qemu-devel@nongnu.org Cc: "Daniel P. Berrange" , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Patrick Venture , Thomas Huth , "Michael S. Tsirkin" , Igor Mammedov , Alexander Bulekov , Bandan Das , Stefan Hajnoczi , Keith Busch , Klaus Jensen , Halil Pasic , Christian Borntraeger , Richard Henderson , David Hildenbrand , Gerd Hoffmann , Havard Skinnemoen , Tyrone Ting , Vijai Kumar K , Alistair Francis , Bin Meng , Palmer Dabbelt , "Edgar E. Iglesias" , Peter Maydell , Laurent Vivier , =?utf-8?Q?C=C3=A9dric?= Le Goater , Andrew Jeffery , Joel Stanley , Jason Wang , Vikram Garhwal , Francisco Iglesias , David Gibson , Greg Kurz , Bastian Koppelmann , Taylor Simpson , qemu-block@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org Subject: Re: [PATCH for-6.2 07/12] [automated] Use DECLARE_*CHECKER* macros when possible In-Reply-To: <20210806211127.646908-8-ehabkost@redhat.com> Organization: Red Hat GmbH References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-8-ehabkost@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 10 Aug 2021 08:09:55 +0200 Message-ID: <871r71ygng.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) DKIMWL_WL_HIGH=-0.702, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2021 06:10:36 -0000 On Fri, Aug 06 2021, Eduardo Habkost wrote: > Converting existing QOM types to OBJECT_DECLARE_TYPE is not > always trivial (due to inconsistent type/macro naming schemes), > but at least converting existing manual QOM type checking macros > to use DECLARE_*CHECKER* is a simpler process, and should at > least discourage people from defining new QOM type checker macros > manually. > > Generated using: > > $ ./scripts/codeconverter/converter.py -i \ > --pattern=3DTypeCheckMacro $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > Cc: "Marc-Andr=C3=A9 Lureau" > Cc: Paolo Bonzini > Cc: Patrick Venture > Cc: Thomas Huth > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Alexander Bulekov > Cc: Bandan Das > Cc: Stefan Hajnoczi > Cc: Keith Busch > Cc: Klaus Jensen > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: Gerd Hoffmann > Cc: Havard Skinnemoen > Cc: Tyrone Ting > Cc: Vijai Kumar K > Cc: Alistair Francis > Cc: Bin Meng > Cc: Palmer Dabbelt > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: Laurent Vivier > Cc: "C=C3=A9dric Le Goater" > Cc: Andrew Jeffery > Cc: Joel Stanley > Cc: Jason Wang > Cc: Vikram Garhwal > Cc: Francisco Iglesias > Cc: David Gibson > Cc: Greg Kurz > Cc: Bastian Koppelmann > Cc: Taylor Simpson > Cc: qemu-devel@nongnu.org > Cc: qemu-block@nongnu.org > Cc: qemu-s390x@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-ppc@nongnu.org > --- > hw/nvme/nvme.h | 12 ++++++------ > hw/usb/hcd-xhci-pci.h | 4 ++-- > hw/usb/hcd-xhci-sysbus.h | 4 ++-- > hw/usb/u2f.h | 8 ++------ > include/hw/adc/npcm7xx_adc.h | 4 ++-- > include/hw/arm/npcm7xx.h | 15 ++++----------- > include/hw/char/shakti_uart.h | 4 ++-- > include/hw/dma/sifive_pdma.h | 4 ++-- > include/hw/dma/xlnx_csu_dma.h | 4 ++-- > include/hw/gpio/npcm7xx_gpio.h | 4 ++-- > include/hw/i2c/npcm7xx_smbus.h | 4 ++-- > include/hw/intc/m68k_irqc.h | 4 ++-- > include/hw/intc/sifive_clint.h | 4 ++-- > include/hw/mem/npcm7xx_mc.h | 3 ++- > include/hw/misc/aspeed_lpc.h | 3 ++- > include/hw/misc/mchp_pfsoc_dmc.h | 10 ++++------ > include/hw/misc/mchp_pfsoc_ioscb.h | 4 ++-- > include/hw/misc/mchp_pfsoc_sysreg.h | 5 ++--- > include/hw/misc/npcm7xx_clk.h | 3 ++- > include/hw/misc/npcm7xx_gcr.h | 3 ++- > include/hw/misc/npcm7xx_mft.h | 4 ++-- > include/hw/misc/npcm7xx_pwm.h | 4 ++-- > include/hw/misc/npcm7xx_rng.h | 3 ++- > include/hw/misc/xlnx-versal-xramc.h | 4 ++-- > include/hw/net/npcm7xx_emc.h | 4 ++-- > include/hw/net/xlnx-zynqmp-can.h | 4 ++-- > include/hw/nvram/npcm7xx_otp.h | 3 ++- > include/hw/ppc/spapr_drc.h | 13 ++++--------- > include/hw/ppc/spapr_xive.h | 7 ++----- > include/hw/riscv/microchip_pfsoc.h | 9 ++++----- > include/hw/riscv/shakti_c.h | 8 ++++---- > include/hw/riscv/sifive_e.h | 8 ++++---- > include/hw/riscv/sifive_u.h | 8 ++++---- > include/hw/sd/cadence_sdhci.h | 4 ++-- > include/hw/ssi/npcm7xx_fiu.h | 3 ++- > include/hw/ssi/sifive_spi.h | 3 ++- > include/hw/timer/npcm7xx_timer.h | 4 ++-- > include/hw/tricore/tricore_testdevice.h | 4 ++-- > include/hw/usb/hcd-dwc3.h | 4 ++-- > include/hw/usb/xlnx-usb-subsystem.h | 4 ++-- > include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 4 ++-- > include/hw/watchdog/sbsa_gwdt.h | 4 ++-- > include/qemu/accel.h | 8 ++------ > target/hexagon/cpu.h | 8 ++------ > chardev/char-parallel.c | 6 ++---- > hw/i2c/i2c_mux_pca954x.c | 4 ++-- > hw/m68k/mcf5206.c | 3 ++- > hw/mem/sparse-mem.c | 3 ++- > hw/misc/sbsa_ec.c | 3 ++- > hw/s390x/vhost-user-fs-ccw.c | 4 ++-- > hw/sensor/adm1272.c | 3 ++- > hw/sensor/max34451.c | 3 ++- > hw/usb/u2f-emulated.c | 4 ++-- > hw/usb/u2f-passthru.c | 4 ++-- > 54 files changed, 126 insertions(+), 146 deletions(-) Acked-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:c144:0:0:0:0:0 with SMTP id r65csp1021970lff; Mon, 9 Aug 2021 23:11:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy66APxq7hcDsUF5xbKQamlgFcrJQdA4QtosCxXPata2DF+j6676KQyhD2egCXvXMkzmU7D X-Received: by 2002:a02:1d04:: with SMTP id 4mr381240jaj.98.1628575866542; Mon, 09 Aug 2021 23:11:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628575866; cv=none; d=google.com; s=arc-20160816; b=YD+IaVM3KbcGitMJC0IRODTBurybyIDSK8NAolhaOTO/WJu1lnH91PClVPrPCHpGGG cfrpkU0bZaAn+RSWPRgIqBSGcZZ/Wa1/+BFMmy6ojX2uyoCCgLalDR3hBhf18+bhFOJL tC7cmrG9IFbuc6yGAz36hAgfmW/q3OH4BR9QRO9lQPwsPjQcq76EBcUMsvCUPzcc9VOV U/lQ1AuHoMJuZjmOjv/uYdtMsLlEJYPDfeYmwzJNo7fJkNOzr1fzCqMpNvjuyPB+M+6g RNHhP1HR4CE/a8bGzKFHk2KSTrIGTYPDjcIhaCmwrxkjSGboXzt3EPRfpEtErI8Ze64N RCfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:user-agent:references:organization :in-reply-to:subject:to:from:dkim-signature; bh=58RL47eWZyCzhgKuqtiABHxb0t+kFvojCVqufK2R/OA=; b=vt8eNSXda29+jxUUA0pC8WYJec3lXp6HIbIr1NnD2ZKsLSlym/KliAgXqzqWPmI4DL I+oCCk6MK6IKdykP4QKL16KUF+HwseW3PgPuGMvaX/XVeAplQE4yyd7IH3K6s9Niw5/D NCgh01PCFimMCiYtzls25Ho4lMF+jQORYeboGnpM4DxhwqieR8apYzTm1SgdOUjDLuq1 85TP/RTfsI36CVRNbZl6QzYOJHRtNQvGcDsu9uWkgAc0y1ImadCNdPETYPEiZgnk616D qlj/3FQg7Ra+hbJtk7eQdOJSDN2G7rO3/rVxAuRvOJPgEUPLMy/etYwH3sbmJdNNnMY9 dy/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=EeDf4e5G; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p14si76934ils.84.2021.08.09.23.11.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Aug 2021 23:11:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=EeDf4e5G; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:47740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDKyf-0007QY-Rg for alex.bennee@linaro.org; Tue, 10 Aug 2021 02:11:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKy8-0006UK-CC for qemu-arm@nongnu.org; Tue, 10 Aug 2021 02:10:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42139) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKy6-0006qG-DH for qemu-arm@nongnu.org; Tue, 10 Aug 2021 02:10:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628575829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=58RL47eWZyCzhgKuqtiABHxb0t+kFvojCVqufK2R/OA=; b=EeDf4e5GqGDTeOOUuFpV5iTIw3AmR4MwZ5qg791iHhsvkKvDzTO+TkW+UefAUC8gjQGqqF HSVF1I4NXw+C35F+ZH0GbpQHd9l/2Ht1oDw7TGwvXfvv+SGfasHcJ82D9HCwdVDZ5zEBi0 8NlWrlAxRNJ5co766klXQV50Ic5UsHY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-GRn88WI7OIuByXOBbE3BTw-1; Tue, 10 Aug 2021 02:10:28 -0400 X-MC-Unique: GRn88WI7OIuByXOBbE3BTw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BB211853038; Tue, 10 Aug 2021 06:10:24 +0000 (UTC) Received: from localhost (unknown [10.39.192.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30ADB5D9C6; Tue, 10 Aug 2021 06:09:57 +0000 (UTC) From: Cornelia Huck To: Eduardo Habkost , qemu-devel@nongnu.org Subject: Re: [PATCH for-6.2 07/12] [automated] Use DECLARE_*CHECKER* macros when possible In-Reply-To: <20210806211127.646908-8-ehabkost@redhat.com> Organization: Red Hat GmbH References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-8-ehabkost@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 10 Aug 2021 08:09:55 +0200 Message-ID: <871r71ygng.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.702, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Andrew Jeffery , Jason Wang , Bin Meng , Vijai Kumar K , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Klaus Jensen , Vikram Garhwal , qemu-block@nongnu.org, qemu-ppc@nongnu.org, David Hildenbrand , Havard Skinnemoen , Halil Pasic , Christian Borntraeger , Joel Stanley , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-s390x@nongnu.org, Richard Henderson , Greg Kurz , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Stefan Hajnoczi , Paolo Bonzini , Keith Busch , qemu-riscv@nongnu.org, David Gibson , "Daniel P. Berrange" , Francisco Iglesias , Thomas Huth , Patrick Venture , Laurent Vivier , Tyrone Ting , Palmer Dabbelt , Bastian Koppelmann , Igor Mammedov Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: mySqxubHoFH0 On Fri, Aug 06 2021, Eduardo Habkost wrote: > Converting existing QOM types to OBJECT_DECLARE_TYPE is not > always trivial (due to inconsistent type/macro naming schemes), > but at least converting existing manual QOM type checking macros > to use DECLARE_*CHECKER* is a simpler process, and should at > least discourage people from defining new QOM type checker macros > manually. > > Generated using: > > $ ./scripts/codeconverter/converter.py -i \ > --pattern=3DTypeCheckMacro $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > Cc: "Marc-Andr=C3=A9 Lureau" > Cc: Paolo Bonzini > Cc: Patrick Venture > Cc: Thomas Huth > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Alexander Bulekov > Cc: Bandan Das > Cc: Stefan Hajnoczi > Cc: Keith Busch > Cc: Klaus Jensen > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: Gerd Hoffmann > Cc: Havard Skinnemoen > Cc: Tyrone Ting > Cc: Vijai Kumar K > Cc: Alistair Francis > Cc: Bin Meng > Cc: Palmer Dabbelt > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: Laurent Vivier > Cc: "C=C3=A9dric Le Goater" > Cc: Andrew Jeffery > Cc: Joel Stanley > Cc: Jason Wang > Cc: Vikram Garhwal > Cc: Francisco Iglesias > Cc: David Gibson > Cc: Greg Kurz > Cc: Bastian Koppelmann > Cc: Taylor Simpson > Cc: qemu-devel@nongnu.org > Cc: qemu-block@nongnu.org > Cc: qemu-s390x@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-ppc@nongnu.org > --- > hw/nvme/nvme.h | 12 ++++++------ > hw/usb/hcd-xhci-pci.h | 4 ++-- > hw/usb/hcd-xhci-sysbus.h | 4 ++-- > hw/usb/u2f.h | 8 ++------ > include/hw/adc/npcm7xx_adc.h | 4 ++-- > include/hw/arm/npcm7xx.h | 15 ++++----------- > include/hw/char/shakti_uart.h | 4 ++-- > include/hw/dma/sifive_pdma.h | 4 ++-- > include/hw/dma/xlnx_csu_dma.h | 4 ++-- > include/hw/gpio/npcm7xx_gpio.h | 4 ++-- > include/hw/i2c/npcm7xx_smbus.h | 4 ++-- > include/hw/intc/m68k_irqc.h | 4 ++-- > include/hw/intc/sifive_clint.h | 4 ++-- > include/hw/mem/npcm7xx_mc.h | 3 ++- > include/hw/misc/aspeed_lpc.h | 3 ++- > include/hw/misc/mchp_pfsoc_dmc.h | 10 ++++------ > include/hw/misc/mchp_pfsoc_ioscb.h | 4 ++-- > include/hw/misc/mchp_pfsoc_sysreg.h | 5 ++--- > include/hw/misc/npcm7xx_clk.h | 3 ++- > include/hw/misc/npcm7xx_gcr.h | 3 ++- > include/hw/misc/npcm7xx_mft.h | 4 ++-- > include/hw/misc/npcm7xx_pwm.h | 4 ++-- > include/hw/misc/npcm7xx_rng.h | 3 ++- > include/hw/misc/xlnx-versal-xramc.h | 4 ++-- > include/hw/net/npcm7xx_emc.h | 4 ++-- > include/hw/net/xlnx-zynqmp-can.h | 4 ++-- > include/hw/nvram/npcm7xx_otp.h | 3 ++- > include/hw/ppc/spapr_drc.h | 13 ++++--------- > include/hw/ppc/spapr_xive.h | 7 ++----- > include/hw/riscv/microchip_pfsoc.h | 9 ++++----- > include/hw/riscv/shakti_c.h | 8 ++++---- > include/hw/riscv/sifive_e.h | 8 ++++---- > include/hw/riscv/sifive_u.h | 8 ++++---- > include/hw/sd/cadence_sdhci.h | 4 ++-- > include/hw/ssi/npcm7xx_fiu.h | 3 ++- > include/hw/ssi/sifive_spi.h | 3 ++- > include/hw/timer/npcm7xx_timer.h | 4 ++-- > include/hw/tricore/tricore_testdevice.h | 4 ++-- > include/hw/usb/hcd-dwc3.h | 4 ++-- > include/hw/usb/xlnx-usb-subsystem.h | 4 ++-- > include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 4 ++-- > include/hw/watchdog/sbsa_gwdt.h | 4 ++-- > include/qemu/accel.h | 8 ++------ > target/hexagon/cpu.h | 8 ++------ > chardev/char-parallel.c | 6 ++---- > hw/i2c/i2c_mux_pca954x.c | 4 ++-- > hw/m68k/mcf5206.c | 3 ++- > hw/mem/sparse-mem.c | 3 ++- > hw/misc/sbsa_ec.c | 3 ++- > hw/s390x/vhost-user-fs-ccw.c | 4 ++-- > hw/sensor/adm1272.c | 3 ++- > hw/sensor/max34451.c | 3 ++- > hw/usb/u2f-emulated.c | 4 ++-- > hw/usb/u2f-passthru.c | 4 ++-- > 54 files changed, 126 insertions(+), 146 deletions(-) Acked-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD63C4338F for ; Tue, 10 Aug 2021 06:11:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8DAB60F55 for ; Tue, 10 Aug 2021 06:11:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B8DAB60F55 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:49052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDKz2-0008Iw-JE for qemu-devel@archiver.kernel.org; Tue, 10 Aug 2021 02:11:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKyA-0006XW-6x for qemu-devel@nongnu.org; Tue, 10 Aug 2021 02:10:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDKy6-0006qJ-J4 for qemu-devel@nongnu.org; Tue, 10 Aug 2021 02:10:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628575829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=58RL47eWZyCzhgKuqtiABHxb0t+kFvojCVqufK2R/OA=; b=EeDf4e5GqGDTeOOUuFpV5iTIw3AmR4MwZ5qg791iHhsvkKvDzTO+TkW+UefAUC8gjQGqqF HSVF1I4NXw+C35F+ZH0GbpQHd9l/2Ht1oDw7TGwvXfvv+SGfasHcJ82D9HCwdVDZ5zEBi0 8NlWrlAxRNJ5co766klXQV50Ic5UsHY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-GRn88WI7OIuByXOBbE3BTw-1; Tue, 10 Aug 2021 02:10:28 -0400 X-MC-Unique: GRn88WI7OIuByXOBbE3BTw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BB211853038; Tue, 10 Aug 2021 06:10:24 +0000 (UTC) Received: from localhost (unknown [10.39.192.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30ADB5D9C6; Tue, 10 Aug 2021 06:09:57 +0000 (UTC) From: Cornelia Huck To: Eduardo Habkost , qemu-devel@nongnu.org Subject: Re: [PATCH for-6.2 07/12] [automated] Use DECLARE_*CHECKER* macros when possible In-Reply-To: <20210806211127.646908-8-ehabkost@redhat.com> Organization: Red Hat GmbH References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-8-ehabkost@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 10 Aug 2021 08:09:55 +0200 Message-ID: <871r71ygng.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.702, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Andrew Jeffery , Jason Wang , Bin Meng , Vijai Kumar K , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Klaus Jensen , "Edgar E. Iglesias" , Vikram Garhwal , qemu-block@nongnu.org, qemu-ppc@nongnu.org, David Hildenbrand , Havard Skinnemoen , Halil Pasic , Christian Borntraeger , Joel Stanley , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-s390x@nongnu.org, Richard Henderson , Greg Kurz , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Stefan Hajnoczi , Paolo Bonzini , Keith Busch , qemu-riscv@nongnu.org, David Gibson , "Daniel P. Berrange" , Francisco Iglesias , Thomas Huth , Patrick Venture , Laurent Vivier , Tyrone Ting , Palmer Dabbelt , Bastian Koppelmann , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Aug 06 2021, Eduardo Habkost wrote: > Converting existing QOM types to OBJECT_DECLARE_TYPE is not > always trivial (due to inconsistent type/macro naming schemes), > but at least converting existing manual QOM type checking macros > to use DECLARE_*CHECKER* is a simpler process, and should at > least discourage people from defining new QOM type checker macros > manually. > > Generated using: > > $ ./scripts/codeconverter/converter.py -i \ > --pattern=3DTypeCheckMacro $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > Cc: "Marc-Andr=C3=A9 Lureau" > Cc: Paolo Bonzini > Cc: Patrick Venture > Cc: Thomas Huth > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Alexander Bulekov > Cc: Bandan Das > Cc: Stefan Hajnoczi > Cc: Keith Busch > Cc: Klaus Jensen > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Richard Henderson > Cc: David Hildenbrand > Cc: Gerd Hoffmann > Cc: Havard Skinnemoen > Cc: Tyrone Ting > Cc: Vijai Kumar K > Cc: Alistair Francis > Cc: Bin Meng > Cc: Palmer Dabbelt > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: Laurent Vivier > Cc: "C=C3=A9dric Le Goater" > Cc: Andrew Jeffery > Cc: Joel Stanley > Cc: Jason Wang > Cc: Vikram Garhwal > Cc: Francisco Iglesias > Cc: David Gibson > Cc: Greg Kurz > Cc: Bastian Koppelmann > Cc: Taylor Simpson > Cc: qemu-devel@nongnu.org > Cc: qemu-block@nongnu.org > Cc: qemu-s390x@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-ppc@nongnu.org > --- > hw/nvme/nvme.h | 12 ++++++------ > hw/usb/hcd-xhci-pci.h | 4 ++-- > hw/usb/hcd-xhci-sysbus.h | 4 ++-- > hw/usb/u2f.h | 8 ++------ > include/hw/adc/npcm7xx_adc.h | 4 ++-- > include/hw/arm/npcm7xx.h | 15 ++++----------- > include/hw/char/shakti_uart.h | 4 ++-- > include/hw/dma/sifive_pdma.h | 4 ++-- > include/hw/dma/xlnx_csu_dma.h | 4 ++-- > include/hw/gpio/npcm7xx_gpio.h | 4 ++-- > include/hw/i2c/npcm7xx_smbus.h | 4 ++-- > include/hw/intc/m68k_irqc.h | 4 ++-- > include/hw/intc/sifive_clint.h | 4 ++-- > include/hw/mem/npcm7xx_mc.h | 3 ++- > include/hw/misc/aspeed_lpc.h | 3 ++- > include/hw/misc/mchp_pfsoc_dmc.h | 10 ++++------ > include/hw/misc/mchp_pfsoc_ioscb.h | 4 ++-- > include/hw/misc/mchp_pfsoc_sysreg.h | 5 ++--- > include/hw/misc/npcm7xx_clk.h | 3 ++- > include/hw/misc/npcm7xx_gcr.h | 3 ++- > include/hw/misc/npcm7xx_mft.h | 4 ++-- > include/hw/misc/npcm7xx_pwm.h | 4 ++-- > include/hw/misc/npcm7xx_rng.h | 3 ++- > include/hw/misc/xlnx-versal-xramc.h | 4 ++-- > include/hw/net/npcm7xx_emc.h | 4 ++-- > include/hw/net/xlnx-zynqmp-can.h | 4 ++-- > include/hw/nvram/npcm7xx_otp.h | 3 ++- > include/hw/ppc/spapr_drc.h | 13 ++++--------- > include/hw/ppc/spapr_xive.h | 7 ++----- > include/hw/riscv/microchip_pfsoc.h | 9 ++++----- > include/hw/riscv/shakti_c.h | 8 ++++---- > include/hw/riscv/sifive_e.h | 8 ++++---- > include/hw/riscv/sifive_u.h | 8 ++++---- > include/hw/sd/cadence_sdhci.h | 4 ++-- > include/hw/ssi/npcm7xx_fiu.h | 3 ++- > include/hw/ssi/sifive_spi.h | 3 ++- > include/hw/timer/npcm7xx_timer.h | 4 ++-- > include/hw/tricore/tricore_testdevice.h | 4 ++-- > include/hw/usb/hcd-dwc3.h | 4 ++-- > include/hw/usb/xlnx-usb-subsystem.h | 4 ++-- > include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 4 ++-- > include/hw/watchdog/sbsa_gwdt.h | 4 ++-- > include/qemu/accel.h | 8 ++------ > target/hexagon/cpu.h | 8 ++------ > chardev/char-parallel.c | 6 ++---- > hw/i2c/i2c_mux_pca954x.c | 4 ++-- > hw/m68k/mcf5206.c | 3 ++- > hw/mem/sparse-mem.c | 3 ++- > hw/misc/sbsa_ec.c | 3 ++- > hw/s390x/vhost-user-fs-ccw.c | 4 ++-- > hw/sensor/adm1272.c | 3 ++- > hw/sensor/max34451.c | 3 ++- > hw/usb/u2f-emulated.c | 4 ++-- > hw/usb/u2f-passthru.c | 4 ++-- > 54 files changed, 126 insertions(+), 146 deletions(-) Acked-by: Cornelia Huck