From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C98EC2B9F4 for ; Tue, 22 Jun 2021 15:51:16 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C554B61075 for ; Tue, 22 Jun 2021 15:51:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C554B61075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5041D4A17F; Tue, 22 Jun 2021 11:51:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5vrMlPIzVcDa; Tue, 22 Jun 2021 11:51:14 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2EEBD40870; Tue, 22 Jun 2021 11:51:14 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4E5424080B for ; Tue, 22 Jun 2021 11:51:13 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cqCwvriIdY01 for ; Tue, 22 Jun 2021 11:51:11 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 3B5EA404F8 for ; Tue, 22 Jun 2021 11:51:11 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29C9560233; Tue, 22 Jun 2021 15:51:10 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lvig6-009Cui-3O; Tue, 22 Jun 2021 16:51:06 +0100 Date: Tue, 22 Jun 2021 16:51:05 +0100 Message-ID: <871r8tdhjq.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH v4 0/9] KVM: arm64: Initial host support for the Apple M1 In-Reply-To: <9bc0923c-5c3b-eeac-86ee-c3234c486955@arm.com> References: <20210601104005.81332-1-maz@kernel.org> <9bc0923c-5c3b-eeac-86ee-c3234c486955@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com, eric.auger@redhat.com, marcan@marcan.st, mark.rutland@arm.com, yuzenghui@huawei.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, Hector Martin , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgQWxleCwKCk9uIFR1ZSwgMjIgSnVuIDIwMjEgMTY6Mzk6MTEgKzAxMDAsCkFsZXhhbmRydSBF bGlzZWkgPGFsZXhhbmRydS5lbGlzZWlAYXJtLmNvbT4gd3JvdGU6Cj4gCj4gSGkgTWFyYywKPiAK PiBPbiA2LzEvMjEgMTE6MzkgQU0sIE1hcmMgWnluZ2llciB3cm90ZToKPiA+IFRoaXMgaXMgYSBu ZXcgdmVyc2lvbiBvZiB0aGUgc2VyaWVzIHByZXZpb3VzbHkgcG9zdGVkIGF0IFszXSwgcmV3b3Jr aW5nCj4gPiB0aGUgdkdJQyBhbmQgdGltZXIgY29kZSB0byBjb3BlIHdpdGggdGhlIE0xIGJyYWlu ZGVhZF5XYW11c2luZyBuYXR1cmUuCj4gPgo+ID4gSGFyZGx5IGFueSBjaGFuZ2UgdGhpcyB0aW1l IGFyb3VuZCwgbW9zdGx5IHJlYmFzZWQgb24gdG9wIG9mIHVwc3RyZWFtCj4gPiBub3cgdGhhdCB0 aGUgZGVwZW5kZW5jaWVzIGhhdmUgbWFkZSBpdCBpbi4KPiA+Cj4gPiBUZXN0ZWQgd2l0aCBtdWx0 aXBsZSBjb25jdXJyZW50IFZNcyBydW5uaW5nIGZyb20gYW4gaW5pdHJhbWZzLgo+ID4KPiA+IFVu dGlsIHNvbWVvbmUgc2hvdXRzIGxvdWRseSBub3csIEknbGwgdGFrZSB0aGlzIGludG8gNS4xNCAo YW5kIGluCj4gPiAtbmV4dCBmcm9tIHRvbW9ycm93KS4KPiAKPiBJIGFtIG5vdCBmYW1pbGlhciB3 aXRoIGlycWRvbWFpbnMgb3Igd2l0aCB0aGUgaXJxY2hpcAo+IGluZnJhc3RydWN0dXJlLCBzbyBJ IGNhbid0IHJlYWxseSBjb21tZW50IG9uIHBhdGNoICM4Lgo+IAo+IEkgdHJpZWQgdGVzdGluZyB0 aGlzIHdpdGggYSBHSUN2MyBieSBtb2RpZnlpbmcgdGhlIGRyaXZlciB0byBzZXQKPiBub19od19k ZWFjdGl2YXRpb24gYW5kIG5vX21haW50X2lycV9tYXNrOgo+IAo+IGRpZmYgLS1naXQgYS9hcmNo L2FybTY0L2t2bS92Z2ljL3ZnaWMtaW5pdC5jIGIvYXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLWlu aXQuYwo+IGluZGV4IDM0MGM1MWQ4NzY3Ny4uZDBjNmY4MDhkN2Y0IDEwMDY0NAo+IC0tLSBhL2Fy Y2gvYXJtNjQva3ZtL3ZnaWMvdmdpYy1pbml0LmMKPiArKysgYi9hcmNoL2FybTY0L2t2bS92Z2lj L3ZnaWMtaW5pdC5jCj4gQEAgLTU2NSw4ICs1NjUsMTAgQEAgaW50IGt2bV92Z2ljX2h5cF9pbml0 KHZvaWQpCj4gwqDCoMKgwqDCoMKgwqAgaWYgKHJldCkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgcmV0dXJuIHJldDsKPiDCoAo+ICvCoMKgwqDCoMKgwqAgLyoKPiDCoMKgwqDCoMKg wqDCoCBpZiAoIWhhc19tYXNrKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1 cm4gMDsKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqLwo+IMKgCj4gwqDCoMKgwqDC oMKgwqAgcmV0ID0gcmVxdWVzdF9wZXJjcHVfaXJxKGt2bV92Z2ljX2dsb2JhbF9zdGF0ZS5tYWlu dF9pcnEsCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCB2Z2ljX21haW50ZW5hbmNlX2hhbmRsZXIsCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLmMgYi9kcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12 My5jCj4gaW5kZXggNDUzZmM0MjVlZWRlLi45Y2U0ZGVlMjA2NTUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9pcnFjaGlwL2lycS1naWMtdjMuYwo+ICsrKyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtZ2lj LXYzLmMKPiBAQCAtMTg1MCw2ICsxODUwLDEyIEBAIHN0YXRpYyB2b2lkIF9faW5pdCBnaWNfb2Zf c2V0dXBfa3ZtX2luZm8oc3RydWN0IGRldmljZV9ub2RlCj4gKm5vZGUpCj4gwqDCoMKgwqDCoMKg wqAgaWYgKCFyZXQpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdpY192M19rdm1f aW5mby52Y3B1ID0gcjsKPiDCoAo+ICvCoMKgwqDCoMKgwqAgZ2ljX3YzX2t2bV9pbmZvLm5vX2h3 X2RlYWN0aXZhdGlvbiA9IHRydWU7CgpCbGluay4uLgoKPiArwqDCoMKgwqDCoMKgIGdpY192M19r dm1faW5mby5ub19tYWludF9pcnFfbWFzayA9IHRydWU7Cj4gKwo+ICvCoMKgwqDCoMKgwqAgdmdp Y19zZXRfa3ZtX2luZm8oJmdpY192M19rdm1faW5mbyk7Cj4gK8KgwqDCoMKgwqDCoCByZXR1cm47 Cj4gKwo+IMKgwqDCoMKgwqDCoMKgIGdpY192M19rdm1faW5mby5oYXNfdjQgPSBnaWNfZGF0YS5y ZGlzdHMuaGFzX3ZscGlzOwo+IMKgwqDCoMKgwqDCoMKgIGdpY192M19rdm1faW5mby5oYXNfdjRf MSA9IGdpY19kYXRhLnJkaXN0cy5oYXNfcnZwZWlkOwo+IMKgwqDCoMKgwqDCoMKgIHZnaWNfc2V0 X2t2bV9pbmZvKCZnaWNfdjNfa3ZtX2luZm8pOwo+IAo+IEtlcHQgdGhlIG1haW50ZW5hbmNlIGly cSBJRCBzbyB0aGUgSVJRIGdldHMgZW5hYmxlZCBhdCB0aGUKPiBSZWRpc3RyaWJ1dG9yIGxldmVs LiBJIGRvbid0IGtub3cgaWYgSSBtYW5hZ2VkIHRvIGJyZWFrIHNvbWV0aGluZwo+IHdpdGggdGhv c2UgY2hhbmdlcywgYnV0IHdoZW4gdGVzdGluZyBvbiB0aGUgbW9kZWwgYW5kIG9uIGEgcm9ja3By bzY0Cj4gKHdpdGggdGhlIHBhdGNoZXMgY2hlcnJ5LXBpY2tlZCBvbiB0b3Agb2YgdjUuMTMtcmM3 KSBJIGtlcHQgc2VlaW5nCj4gcmN1IHN0YWxscy4gSSBhc3N1bWUgSSBkaWQgc29tZXRoaW5nIHdy b25nLgoKSWYgeW91IGRvIHRoYXQsIHRoZSBpbnRlcnJ1cHRzIHRoYXQgYXJlIGZvcndhcmRlZCB0 byB0aGUgZ3Vlc3QKKHRpbWVycykgd2lsbCBuZXZlciBiZSBkZWFjdGl2YXRlZCwgYW5kIHdpbGwg YmUgbGVmdCBkYW5nbGluZyBhZnRlcgp0aGUgZmlyc3QgaW5qZWN0aW9uLiBUaGlzIGlzIGJvdW5k IHRvIGNyZWF0ZSBoYXZvYywgYXMgd2Ugd2lsbCB0aGVuCnVzZSBtYXNrL3VubWFzayB0byBjb250 cm9sIHRoZSB0aW1lciBkZWxpdmVyeSAocmVtZW1iZXIgdGhhdCB0aGUKQWN0aXZlIHN0YXRlIGlz IGp1c3QgYW5vdGhlciBmb3JtIG9mIGF1dG8tbWFza2luZyBvbiB0b3Agb2YgdGhlCnN0YW5kYXJk IGVuYWJsZSBiaXQpCgpPbiB0aGUgY29udHJhcnksIHRoZSBBSUMgb25seSBoYXMgYSBzaW5nbGUg Yml0IHRvIGNvbnRyb2wgdGhlIHRpbWVyCih1c2VkIGFzIGEgbWFzayksIHdoaWNoIGlzIHdoYXQg dGhlIGlycWRvbWFpbiBzdHVmZiBpbXBsZW1lbnRzIHRvCm1pbWljIHRoZSBhY3RpdmUgc3RhdGUu CgpUaGFua3MsCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9n cmVzcyBpcyBub3QgcG9zc2libGUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlh LmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFy bQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6587C2B9F4 for ; Tue, 22 Jun 2021 15:52:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A614960233 for ; Tue, 22 Jun 2021 15:52:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A614960233 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8jiSKyOklU1SGABYQ4OnMh3SaveVfkTiMjKfIpo5zT8=; b=NgLLI71J7VkZ/h Bqw20LA/OMf4cTxZkoQ5ANXfCTpkCZBmUcyi9rUyKwm4Pqs86Ih9Nl6gs2N912skluOeyyNoQGuuV U5HnOKU8U4F4Xu6YUdwSJD9iNwCD86taCCGKUVIEcZtnhaZsNJzBNgpI+cuWYVtjfmotSaLMxKQg4 boN8u3/3M0c0nfweXgdebxU/rxlFW7gOaktibY0/4qx8NR1bGQBE1DQi9u/k05k+5H3CSPrZ+5tSr agwfu/gfsJcr3rys0Qd42WNBI4tcoKwLaCgVkCuiFxvHic+XQvxTnGAOZrlFxXBQFF7e+bRJ0okHm YkL74BAfXzVkNpGaSIdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvigE-007nLy-C0; Tue, 22 Jun 2021 15:51:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvigA-007nLH-HB for linux-arm-kernel@lists.infradead.org; Tue, 22 Jun 2021 15:51:11 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29C9560233; Tue, 22 Jun 2021 15:51:10 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lvig6-009Cui-3O; Tue, 22 Jun 2021 16:51:06 +0100 Date: Tue, 22 Jun 2021 16:51:05 +0100 Message-ID: <871r8tdhjq.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, James Morse , Suzuki K Poulose , Eric Auger , Hector Martin , Mark Rutland , Zenghui Yu , kernel-team@android.com Subject: Re: [PATCH v4 0/9] KVM: arm64: Initial host support for the Apple M1 In-Reply-To: <9bc0923c-5c3b-eeac-86ee-c3234c486955@arm.com> References: <20210601104005.81332-1-maz@kernel.org> <9bc0923c-5c3b-eeac-86ee-c3234c486955@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com, eric.auger@redhat.com, marcan@marcan.st, mark.rutland@arm.com, yuzenghui@huawei.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_085110_647659_F7D79A37 X-CRM114-Status: GOOD ( 33.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQWxleCwKCk9uIFR1ZSwgMjIgSnVuIDIwMjEgMTY6Mzk6MTEgKzAxMDAsCkFsZXhhbmRydSBF bGlzZWkgPGFsZXhhbmRydS5lbGlzZWlAYXJtLmNvbT4gd3JvdGU6Cj4gCj4gSGkgTWFyYywKPiAK PiBPbiA2LzEvMjEgMTE6MzkgQU0sIE1hcmMgWnluZ2llciB3cm90ZToKPiA+IFRoaXMgaXMgYSBu ZXcgdmVyc2lvbiBvZiB0aGUgc2VyaWVzIHByZXZpb3VzbHkgcG9zdGVkIGF0IFszXSwgcmV3b3Jr aW5nCj4gPiB0aGUgdkdJQyBhbmQgdGltZXIgY29kZSB0byBjb3BlIHdpdGggdGhlIE0xIGJyYWlu ZGVhZF5XYW11c2luZyBuYXR1cmUuCj4gPgo+ID4gSGFyZGx5IGFueSBjaGFuZ2UgdGhpcyB0aW1l IGFyb3VuZCwgbW9zdGx5IHJlYmFzZWQgb24gdG9wIG9mIHVwc3RyZWFtCj4gPiBub3cgdGhhdCB0 aGUgZGVwZW5kZW5jaWVzIGhhdmUgbWFkZSBpdCBpbi4KPiA+Cj4gPiBUZXN0ZWQgd2l0aCBtdWx0 aXBsZSBjb25jdXJyZW50IFZNcyBydW5uaW5nIGZyb20gYW4gaW5pdHJhbWZzLgo+ID4KPiA+IFVu dGlsIHNvbWVvbmUgc2hvdXRzIGxvdWRseSBub3csIEknbGwgdGFrZSB0aGlzIGludG8gNS4xNCAo YW5kIGluCj4gPiAtbmV4dCBmcm9tIHRvbW9ycm93KS4KPiAKPiBJIGFtIG5vdCBmYW1pbGlhciB3 aXRoIGlycWRvbWFpbnMgb3Igd2l0aCB0aGUgaXJxY2hpcAo+IGluZnJhc3RydWN0dXJlLCBzbyBJ IGNhbid0IHJlYWxseSBjb21tZW50IG9uIHBhdGNoICM4Lgo+IAo+IEkgdHJpZWQgdGVzdGluZyB0 aGlzIHdpdGggYSBHSUN2MyBieSBtb2RpZnlpbmcgdGhlIGRyaXZlciB0byBzZXQKPiBub19od19k ZWFjdGl2YXRpb24gYW5kIG5vX21haW50X2lycV9tYXNrOgo+IAo+IGRpZmYgLS1naXQgYS9hcmNo L2FybTY0L2t2bS92Z2ljL3ZnaWMtaW5pdC5jIGIvYXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLWlu aXQuYwo+IGluZGV4IDM0MGM1MWQ4NzY3Ny4uZDBjNmY4MDhkN2Y0IDEwMDY0NAo+IC0tLSBhL2Fy Y2gvYXJtNjQva3ZtL3ZnaWMvdmdpYy1pbml0LmMKPiArKysgYi9hcmNoL2FybTY0L2t2bS92Z2lj L3ZnaWMtaW5pdC5jCj4gQEAgLTU2NSw4ICs1NjUsMTAgQEAgaW50IGt2bV92Z2ljX2h5cF9pbml0 KHZvaWQpCj4gwqDCoMKgwqDCoMKgwqAgaWYgKHJldCkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgcmV0dXJuIHJldDsKPiDCoAo+ICvCoMKgwqDCoMKgwqAgLyoKPiDCoMKgwqDCoMKg wqDCoCBpZiAoIWhhc19tYXNrKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1 cm4gMDsKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqLwo+IMKgCj4gwqDCoMKgwqDC oMKgwqAgcmV0ID0gcmVxdWVzdF9wZXJjcHVfaXJxKGt2bV92Z2ljX2dsb2JhbF9zdGF0ZS5tYWlu dF9pcnEsCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCB2Z2ljX21haW50ZW5hbmNlX2hhbmRsZXIsCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLmMgYi9kcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12 My5jCj4gaW5kZXggNDUzZmM0MjVlZWRlLi45Y2U0ZGVlMjA2NTUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9pcnFjaGlwL2lycS1naWMtdjMuYwo+ICsrKyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtZ2lj LXYzLmMKPiBAQCAtMTg1MCw2ICsxODUwLDEyIEBAIHN0YXRpYyB2b2lkIF9faW5pdCBnaWNfb2Zf c2V0dXBfa3ZtX2luZm8oc3RydWN0IGRldmljZV9ub2RlCj4gKm5vZGUpCj4gwqDCoMKgwqDCoMKg wqAgaWYgKCFyZXQpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdpY192M19rdm1f aW5mby52Y3B1ID0gcjsKPiDCoAo+ICvCoMKgwqDCoMKgwqAgZ2ljX3YzX2t2bV9pbmZvLm5vX2h3 X2RlYWN0aXZhdGlvbiA9IHRydWU7CgpCbGluay4uLgoKPiArwqDCoMKgwqDCoMKgIGdpY192M19r dm1faW5mby5ub19tYWludF9pcnFfbWFzayA9IHRydWU7Cj4gKwo+ICvCoMKgwqDCoMKgwqAgdmdp Y19zZXRfa3ZtX2luZm8oJmdpY192M19rdm1faW5mbyk7Cj4gK8KgwqDCoMKgwqDCoCByZXR1cm47 Cj4gKwo+IMKgwqDCoMKgwqDCoMKgIGdpY192M19rdm1faW5mby5oYXNfdjQgPSBnaWNfZGF0YS5y ZGlzdHMuaGFzX3ZscGlzOwo+IMKgwqDCoMKgwqDCoMKgIGdpY192M19rdm1faW5mby5oYXNfdjRf MSA9IGdpY19kYXRhLnJkaXN0cy5oYXNfcnZwZWlkOwo+IMKgwqDCoMKgwqDCoMKgIHZnaWNfc2V0 X2t2bV9pbmZvKCZnaWNfdjNfa3ZtX2luZm8pOwo+IAo+IEtlcHQgdGhlIG1haW50ZW5hbmNlIGly cSBJRCBzbyB0aGUgSVJRIGdldHMgZW5hYmxlZCBhdCB0aGUKPiBSZWRpc3RyaWJ1dG9yIGxldmVs LiBJIGRvbid0IGtub3cgaWYgSSBtYW5hZ2VkIHRvIGJyZWFrIHNvbWV0aGluZwo+IHdpdGggdGhv c2UgY2hhbmdlcywgYnV0IHdoZW4gdGVzdGluZyBvbiB0aGUgbW9kZWwgYW5kIG9uIGEgcm9ja3By bzY0Cj4gKHdpdGggdGhlIHBhdGNoZXMgY2hlcnJ5LXBpY2tlZCBvbiB0b3Agb2YgdjUuMTMtcmM3 KSBJIGtlcHQgc2VlaW5nCj4gcmN1IHN0YWxscy4gSSBhc3N1bWUgSSBkaWQgc29tZXRoaW5nIHdy b25nLgoKSWYgeW91IGRvIHRoYXQsIHRoZSBpbnRlcnJ1cHRzIHRoYXQgYXJlIGZvcndhcmRlZCB0 byB0aGUgZ3Vlc3QKKHRpbWVycykgd2lsbCBuZXZlciBiZSBkZWFjdGl2YXRlZCwgYW5kIHdpbGwg YmUgbGVmdCBkYW5nbGluZyBhZnRlcgp0aGUgZmlyc3QgaW5qZWN0aW9uLiBUaGlzIGlzIGJvdW5k IHRvIGNyZWF0ZSBoYXZvYywgYXMgd2Ugd2lsbCB0aGVuCnVzZSBtYXNrL3VubWFzayB0byBjb250 cm9sIHRoZSB0aW1lciBkZWxpdmVyeSAocmVtZW1iZXIgdGhhdCB0aGUKQWN0aXZlIHN0YXRlIGlz IGp1c3QgYW5vdGhlciBmb3JtIG9mIGF1dG8tbWFza2luZyBvbiB0b3Agb2YgdGhlCnN0YW5kYXJk IGVuYWJsZSBiaXQpCgpPbiB0aGUgY29udHJhcnksIHRoZSBBSUMgb25seSBoYXMgYSBzaW5nbGUg Yml0IHRvIGNvbnRyb2wgdGhlIHRpbWVyCih1c2VkIGFzIGEgbWFzayksIHdoaWNoIGlzIHdoYXQg dGhlIGlycWRvbWFpbiBzdHVmZiBpbXBsZW1lbnRzIHRvCm1pbWljIHRoZSBhY3RpdmUgc3RhdGUu CgpUaGFua3MsCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9n cmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78BE7C2B9F4 for ; Tue, 22 Jun 2021 15:51:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5914E61040 for ; Tue, 22 Jun 2021 15:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231876AbhFVPx0 convert rfc822-to-8bit (ORCPT ); Tue, 22 Jun 2021 11:53:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:46760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232252AbhFVPx0 (ORCPT ); Tue, 22 Jun 2021 11:53:26 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29C9560233; Tue, 22 Jun 2021 15:51:10 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lvig6-009Cui-3O; Tue, 22 Jun 2021 16:51:06 +0100 Date: Tue, 22 Jun 2021 16:51:05 +0100 Message-ID: <871r8tdhjq.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, James Morse , Suzuki K Poulose , Eric Auger , Hector Martin , Mark Rutland , Zenghui Yu , kernel-team@android.com Subject: Re: [PATCH v4 0/9] KVM: arm64: Initial host support for the Apple M1 In-Reply-To: <9bc0923c-5c3b-eeac-86ee-c3234c486955@arm.com> References: <20210601104005.81332-1-maz@kernel.org> <9bc0923c-5c3b-eeac-86ee-c3234c486955@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com, eric.auger@redhat.com, marcan@marcan.st, mark.rutland@arm.com, yuzenghui@huawei.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Alex, On Tue, 22 Jun 2021 16:39:11 +0100, Alexandru Elisei wrote: > > Hi Marc, > > On 6/1/21 11:39 AM, Marc Zyngier wrote: > > This is a new version of the series previously posted at [3], reworking > > the vGIC and timer code to cope with the M1 braindead^Wamusing nature. > > > > Hardly any change this time around, mostly rebased on top of upstream > > now that the dependencies have made it in. > > > > Tested with multiple concurrent VMs running from an initramfs. > > > > Until someone shouts loudly now, I'll take this into 5.14 (and in > > -next from tomorrow). > > I am not familiar with irqdomains or with the irqchip > infrastructure, so I can't really comment on patch #8. > > I tried testing this with a GICv3 by modifying the driver to set > no_hw_deactivation and no_maint_irq_mask: > > diff --git a/arch/arm64/kvm/vgic/vgic-init.c b/arch/arm64/kvm/vgic/vgic-init.c > index 340c51d87677..d0c6f808d7f4 100644 > --- a/arch/arm64/kvm/vgic/vgic-init.c > +++ b/arch/arm64/kvm/vgic/vgic-init.c > @@ -565,8 +565,10 @@ int kvm_vgic_hyp_init(void) >         if (ret) >                 return ret; >   > +       /* >         if (!has_mask) >                 return 0; > +               */ >   >         ret = request_percpu_irq(kvm_vgic_global_state.maint_irq, >                                  vgic_maintenance_handler, > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 453fc425eede..9ce4dee20655 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -1850,6 +1850,12 @@ static void __init gic_of_setup_kvm_info(struct device_node > *node) >         if (!ret) >                 gic_v3_kvm_info.vcpu = r; >   > +       gic_v3_kvm_info.no_hw_deactivation = true; Blink... > +       gic_v3_kvm_info.no_maint_irq_mask = true; > + > +       vgic_set_kvm_info(&gic_v3_kvm_info); > +       return; > + >         gic_v3_kvm_info.has_v4 = gic_data.rdists.has_vlpis; >         gic_v3_kvm_info.has_v4_1 = gic_data.rdists.has_rvpeid; >         vgic_set_kvm_info(&gic_v3_kvm_info); > > Kept the maintenance irq ID so the IRQ gets enabled at the > Redistributor level. I don't know if I managed to break something > with those changes, but when testing on the model and on a rockpro64 > (with the patches cherry-picked on top of v5.13-rc7) I kept seeing > rcu stalls. I assume I did something wrong. If you do that, the interrupts that are forwarded to the guest (timers) will never be deactivated, and will be left dangling after the first injection. This is bound to create havoc, as we will then use mask/unmask to control the timer delivery (remember that the Active state is just another form of auto-masking on top of the standard enable bit) On the contrary, the AIC only has a single bit to control the timer (used as a mask), which is what the irqdomain stuff implements to mimic the active state. Thanks, M. -- Without deviation from the norm, progress is not possible.