From: Chen Li <chenli@uniontech.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Christian Brauner <christian.brauner@ubuntu.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ramfs: skip mknod if inode already exists.【请注意，邮件由viro@ftp.linux.org.uk代发】
Date: Thu, 17 Jun 2021 09:13:52 +0800 [thread overview]
Message-ID: <871r91gunj.wl-chenli@uniontech.com> (raw)
In-Reply-To: <YMnrutsyVKD4Ar2z@zeniv-ca.linux.org.uk>
On Wed, 16 Jun 2021 20:16:58 +0800,
Al Viro wrote:
>
> On Wed, Jun 16, 2021 at 10:53:12AM +0800, Chen Li wrote:
> >
> > It's possible we try to mknod a dentry, which have
> > already bound to an inode, just skip it.
>
> Caller should have checked may_create(), which includes EEXIST handling.
> NAKed-by: Al Viro <viro@zeniv.linux.org.uk>
Don't know may_create before, thanks!
>
> Incidentally, if it ever had been called that way, your variant would
> leak inode. Not the main problem, though...
>
>
prev parent reply other threads:[~2021-06-17 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 2:53 [PATCH] ramfs: skip mknod if inode already exists Chen Li
2021-06-16 5:10 ` Christoph Hellwig
2021-06-16 8:11 ` [PATCH] ramfs: skip mknod if inode already exists.【请注意，邮件由batv+ae8989e1668f84a74d37+6506+infradead.org+hch@casper.srs.infradead.org代发】 Chen Li
2021-06-16 12:16 ` [PATCH] ramfs: skip mknod if inode already exists Al Viro
2021-06-17 1:13 ` Chen Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r91gunj.wl-chenli@uniontech.com \
--to=chenli@uniontech.com \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.