From: Felipe Balbi <balbi@kernel.org>
To: Sven Peter <sven@svenpeter.dev>, linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Sven Peter <sven@svenpeter.dev>
Subject: Re: [PATCH v3] usb: dwc3: support 64 bit DMA in platform driver
Date: Thu, 10 Jun 2021 12:24:28 +0300 [thread overview]
Message-ID: <871r9a2htf.fsf@kernel.org> (raw)
In-Reply-To: <20210607061751.89752-1-sven@svenpeter.dev>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Hi,
Sven Peter <sven@svenpeter.dev> writes:
> Currently, the dwc3 platform driver does not explicitly ask for
> a DMA mask. This makes it fall back to the default 32-bit mask which
> breaks the driver on systems that only have RAM starting above the
> first 4G like the Apple M1 SoC.
>
> Fix this by calling dma_set_mask_and_coherent with a 64bit mask.
>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
Acked-by: Felipe Balbi <balbi@kernel.org>
> ---
>
> Third time's a charm I hope - this time much simpler :)
>
> I still think this change should be fairly low risk.
>
> Unfortunately I only have the Apple M1 to test this on but here
wait a minute. The M1 includes a dwc3? That's awesome. Mind sharing a
regdump? Should be in debugfs.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next prev parent reply other threads:[~2021-06-10 9:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 6:17 [PATCH v3] usb: dwc3: support 64 bit DMA in platform driver Sven Peter
2021-06-07 7:25 ` Arnd Bergmann
2021-06-07 8:01 ` Sven Peter
2021-06-07 8:22 ` Arnd Bergmann
2021-06-07 9:06 ` Sven Peter
2021-06-07 9:17 ` Arnd Bergmann
2021-06-07 10:04 ` Christoph Hellwig
2021-06-07 10:05 ` Christoph Hellwig
2021-06-10 9:24 ` Felipe Balbi [this message]
2021-06-10 15:24 ` Sven Peter
2021-06-11 13:17 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r9a2htf.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.