From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 328F2C48BCF for ; Wed, 9 Jun 2021 11:16:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A26B4600D1 for ; Wed, 9 Jun 2021 11:16:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A26B4600D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 569356E5CF; Wed, 9 Jun 2021 11:16:54 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id D76C36E5CF; Wed, 9 Jun 2021 11:16:52 +0000 (UTC) IronPort-SDR: ocNkKiRsqUDb2nez9Xhz2x5y9Efrp2VgKU4XuflILo1frjUyGNRAqNvzBgrY6hnQHzMSr9oOii kW87JAZOUUFg== X-IronPort-AV: E=McAfee;i="6200,9189,10009"; a="192160292" X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="192160292" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 04:16:52 -0700 IronPort-SDR: U6fbddEJv5cOiIk7cxc8wYmoj05vfgSyUf9GZSeYJVrLGgpQjF+XHPWl5d+1V+xlBg4O9i7TZS fOWneR9uhZew== X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="482344477" Received: from ochaldek-mobl.ger.corp.intel.com (HELO localhost) ([10.252.34.111]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 04:16:49 -0700 From: Jani Nikula To: Simon Ser , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/sysfs: introduce drm_sysfs_connector_hotplug_event In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 09 Jun 2021 14:16:46 +0300 Message-ID: <871r9b1e5d.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexander.deucher@amd.com, michel@daenzer.net, pekka.paalanen@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, 09 Jun 2021, Simon Ser wrote: > This function sends a hotplug uevent with a CONNECTOR property. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_sysfs.c | 25 +++++++++++++++++++++++++ > include/drm/drm_sysfs.h | 1 + > 2 files changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c > index 968a9560b4aa..6b52a53c0c3e 100644 > --- a/drivers/gpu/drm/drm_sysfs.c > +++ b/drivers/gpu/drm/drm_sysfs.c > @@ -343,6 +343,31 @@ void drm_sysfs_hotplug_event(struct drm_device *dev) > } > EXPORT_SYMBOL(drm_sysfs_hotplug_event); > > +/** > + * drm_sysfs_connector_hotplug_event - generate a DRM uevent for any connector > + * change > + * @connector: connector which has changed > + * > + * Send a uevent for the DRM connector specified by @connector. This will send > + * a uevent with the properties HOTPLUG=1 and CONNECTOR. > + */ > +void drm_sysfs_connector_hotplug_event(struct drm_connector *connector) > +{ > + struct drm_device *dev = connector->dev; > + char hotplug_str[] = "HOTPLUG=1", conn_id[21]; > + char *envp[] = { hotplug_str, conn_id, NULL }; > + > + snprintf(conn_id, ARRAY_SIZE(conn_id), Semantically should be sizeof(conn_id) though the result is the same. (I guess this is copy-paste from drm_sysfs_connector_status_event().) > + "CONNECTOR=%u", connector->base.id); > + > + drm_dbg(connector->dev, drm_dbg_kms? > + "generating hotplug event for [CONNECTOR:%d:%s]\n", > + connector->base.id, connector->name); A matter of taste, but seems like in a lot of places we tend to stick the [CONNECTOR:%d:%s] at the beginning of the string. So if you have back-to-back messages related to the same connector, they get aligned and are easy to spot. BR, Jani. > + > + kobject_uevent_env(&dev->primary->kdev->kobj, KOBJ_CHANGE, envp); > +} > +EXPORT_SYMBOL(drm_sysfs_connector_hotplug_event); > + > /** > * drm_sysfs_connector_status_event - generate a DRM uevent for connector > * property status change > diff --git a/include/drm/drm_sysfs.h b/include/drm/drm_sysfs.h > index d454ef617b2c..6273cac44e47 100644 > --- a/include/drm/drm_sysfs.h > +++ b/include/drm/drm_sysfs.h > @@ -11,6 +11,7 @@ int drm_class_device_register(struct device *dev); > void drm_class_device_unregister(struct device *dev); > > void drm_sysfs_hotplug_event(struct drm_device *dev); > +void drm_sysfs_connector_hotplug_event(struct drm_connector *connector); > void drm_sysfs_connector_status_event(struct drm_connector *connector, > struct drm_property *property); > #endif -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D268C48BCD for ; Wed, 9 Jun 2021 11:16:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFE80600D1 for ; Wed, 9 Jun 2021 11:16:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFE80600D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 064A86E7EF; Wed, 9 Jun 2021 11:16:55 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id D76C36E5CF; Wed, 9 Jun 2021 11:16:52 +0000 (UTC) IronPort-SDR: ocNkKiRsqUDb2nez9Xhz2x5y9Efrp2VgKU4XuflILo1frjUyGNRAqNvzBgrY6hnQHzMSr9oOii kW87JAZOUUFg== X-IronPort-AV: E=McAfee;i="6200,9189,10009"; a="192160292" X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="192160292" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 04:16:52 -0700 IronPort-SDR: U6fbddEJv5cOiIk7cxc8wYmoj05vfgSyUf9GZSeYJVrLGgpQjF+XHPWl5d+1V+xlBg4O9i7TZS fOWneR9uhZew== X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="482344477" Received: from ochaldek-mobl.ger.corp.intel.com (HELO localhost) ([10.252.34.111]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 04:16:49 -0700 From: Jani Nikula To: Simon Ser , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/sysfs: introduce drm_sysfs_connector_hotplug_event In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 09 Jun 2021 14:16:46 +0300 Message-ID: <871r9b1e5d.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexander.deucher@amd.com, michel@daenzer.net, pekka.paalanen@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 09 Jun 2021, Simon Ser wrote: > This function sends a hotplug uevent with a CONNECTOR property. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_sysfs.c | 25 +++++++++++++++++++++++++ > include/drm/drm_sysfs.h | 1 + > 2 files changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c > index 968a9560b4aa..6b52a53c0c3e 100644 > --- a/drivers/gpu/drm/drm_sysfs.c > +++ b/drivers/gpu/drm/drm_sysfs.c > @@ -343,6 +343,31 @@ void drm_sysfs_hotplug_event(struct drm_device *dev) > } > EXPORT_SYMBOL(drm_sysfs_hotplug_event); > > +/** > + * drm_sysfs_connector_hotplug_event - generate a DRM uevent for any connector > + * change > + * @connector: connector which has changed > + * > + * Send a uevent for the DRM connector specified by @connector. This will send > + * a uevent with the properties HOTPLUG=1 and CONNECTOR. > + */ > +void drm_sysfs_connector_hotplug_event(struct drm_connector *connector) > +{ > + struct drm_device *dev = connector->dev; > + char hotplug_str[] = "HOTPLUG=1", conn_id[21]; > + char *envp[] = { hotplug_str, conn_id, NULL }; > + > + snprintf(conn_id, ARRAY_SIZE(conn_id), Semantically should be sizeof(conn_id) though the result is the same. (I guess this is copy-paste from drm_sysfs_connector_status_event().) > + "CONNECTOR=%u", connector->base.id); > + > + drm_dbg(connector->dev, drm_dbg_kms? > + "generating hotplug event for [CONNECTOR:%d:%s]\n", > + connector->base.id, connector->name); A matter of taste, but seems like in a lot of places we tend to stick the [CONNECTOR:%d:%s] at the beginning of the string. So if you have back-to-back messages related to the same connector, they get aligned and are easy to spot. BR, Jani. > + > + kobject_uevent_env(&dev->primary->kdev->kobj, KOBJ_CHANGE, envp); > +} > +EXPORT_SYMBOL(drm_sysfs_connector_hotplug_event); > + > /** > * drm_sysfs_connector_status_event - generate a DRM uevent for connector > * property status change > diff --git a/include/drm/drm_sysfs.h b/include/drm/drm_sysfs.h > index d454ef617b2c..6273cac44e47 100644 > --- a/include/drm/drm_sysfs.h > +++ b/include/drm/drm_sysfs.h > @@ -11,6 +11,7 @@ int drm_class_device_register(struct device *dev); > void drm_class_device_unregister(struct device *dev); > > void drm_sysfs_hotplug_event(struct drm_device *dev); > +void drm_sysfs_connector_hotplug_event(struct drm_connector *connector); > void drm_sysfs_connector_status_event(struct drm_connector *connector, > struct drm_property *property); > #endif -- Jani Nikula, Intel Open Source Graphics Center