From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 052E0C433E0 for ; Tue, 26 Jan 2021 11:49:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B166B23101 for ; Tue, 26 Jan 2021 11:49:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B166B23101 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 00B9C6E249; Tue, 26 Jan 2021 11:49:31 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DFC86E249 for ; Tue, 26 Jan 2021 11:49:30 +0000 (UTC) IronPort-SDR: E6z6PrDQysTUKI3V975vDEPefAaNhpPXwMmJOCxZzbvF2UZd2wUKRu+8nj3cRQz7PZjugSPGpd 1MEPDeAFdTfQ== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="159663959" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="159663959" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 03:49:29 -0800 IronPort-SDR: 69aiQyqwN9yUfXcvYwp9iK7rHd6cWSq6opPMpuDuNOsxhp+jcwOmzjqn2gJ/hYCQ6WJwxWfIhh HY4Dw9aNmajQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="402715889" Received: from gaia.fi.intel.com ([10.237.72.192]) by fmsmga004.fm.intel.com with ESMTP; 26 Jan 2021 03:49:28 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id DFE0A5C20E7; Tue, 26 Jan 2021 13:46:37 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20210125220247.31701-1-chris@chris-wilson.co.uk> References: <20210125220247.31701-1-chris@chris-wilson.co.uk> Date: Tue, 26 Jan 2021 13:46:37 +0200 Message-ID: <871re7ly3m.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Flush before changing register state X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > Flush; invalidate; change registers; invalidate; flush. > > Will this finally work on every device? Or will Baytrail complain again? > > On the positive side, we immediate see the benefit of having hsw-gt1 in > CU. CI Acked-by: Mika Kuoppala > > Fixes: ace44e13e577 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals") > Testcase: igt/gem_render_tiled_blits # hsw-gt1 > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Akeem G Abodunrin > --- > drivers/gpu/drm/i915/gt/gen7_renderclear.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c > index 8551e6de50e8..e403eb046a43 100644 > --- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c > +++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c > @@ -393,6 +393,7 @@ static void emit_batch(struct i915_vma * const vma, > desc_count); > > /* Reset inherited context registers */ > + gen7_emit_pipeline_flush(&cmds); > gen7_emit_pipeline_invalidate(&cmds); > batch_add(&cmds, MI_LOAD_REGISTER_IMM(2)); > batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_0_GEN7)); > -- > 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx