From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FCF2C4361B for ; Tue, 8 Dec 2020 20:12:53 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id E402523B26 for ; Tue, 8 Dec 2020 20:12:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E402523B26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 37FAA4B2C4; Tue, 8 Dec 2020 15:12:52 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j-oNak5YlT5i; Tue, 8 Dec 2020 15:12:50 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 426914B2B3; Tue, 8 Dec 2020 15:12:50 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2B37E4B2AF for ; Tue, 8 Dec 2020 15:12:48 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VS8q14ku23rs for ; Tue, 8 Dec 2020 15:12:46 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 391D94B2AE for ; Tue, 8 Dec 2020 15:12:46 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1932923AFE; Tue, 8 Dec 2020 20:12:45 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kmjLm-00HAXe-TJ; Tue, 08 Dec 2020 20:12:43 +0000 Date: Tue, 08 Dec 2020 20:12:41 +0000 Message-ID: <871rg05a6e.wl-maz@kernel.org> From: Marc Zyngier To: David Brazdil Subject: Re: [PATCH v4 00/26] Opt-in always-on nVHE hypervisor In-Reply-To: <20201208191447.47idqf7n2v3hvrdg@google.com> References: <20201202184122.26046-1-dbrazdil@google.com> <160702322202.1501317.9696987088711766533.b4-ty@kernel.org> <20201208191447.47idqf7n2v3hvrdg@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dbrazdil@google.com, kvmarm@lists.cs.columbia.edu, catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, linux-kernel@vger.kernel.org, will@kernel.org, tj@kernel.org, dennis@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, cl@linux.com, sudeep.holla@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Christoph Lameter , Lorenzo Pieralisi , linux-doc@vger.kernel.org, Catalin Marinas , Jonathan Corbet , linux-kernel@vger.kernel.org, Sudeep Holla , Tejun Heo , Dennis Zhou , kernel-team@android.com, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, 08 Dec 2020 19:14:47 +0000, David Brazdil wrote: > > Hey Marc, > > On Thu, Dec 03, 2020 at 07:23:19PM +0000, Marc Zyngier wrote: > > On Wed, 2 Dec 2020 18:40:56 +0000, David Brazdil wrote: > > > As we progress towards being able to keep guest state private to the > > > host running nVHE hypervisor, this series allows the hypervisor to > > > install itself on newly booted CPUs before the host is allowed to run > > > on them. > > > > > > All functionality described below is opt-in, guarded by an early param > > > 'kvm-arm.mode=protected'. Future patches specific to the new protected > > > mode should be hidden behind the same param. > > > > > > [...] > > > > Applied to kvm-arm64/psci-relay, thanks! > > > > Note that although I pushed it to -next, I still need people to > > eyeball it and give it some Acks. The commit-IDs below will > > thus change as I apply tags, if any. > > > > I'm looking at -next and I think the merge with Mark Rutland's el2_setup > refactor didn't go as planned. > > The `#ifdef CONFIG_ARM64_VHE` section needs to cover everything between > init_el2 and init_el2_nvhe. Currently the code falls through into VHE init > when CONFIG_ARM64_VHE is not set. Oops, well spotted. I wasn't thinking straight. I came up with a slightly different fix though, keeping the whole of the VHE code and instead restoring the "mov x2, xzr" we had before. I've pushed something out, do yell if you spot anything else. Thanks again, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE2AEC19437 for ; Tue, 8 Dec 2020 20:23:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96B442388C for ; Tue, 8 Dec 2020 20:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731353AbgLHUQL (ORCPT ); Tue, 8 Dec 2020 15:16:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:33994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731110AbgLHUN0 (ORCPT ); Tue, 8 Dec 2020 15:13:26 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1932923AFE; Tue, 8 Dec 2020 20:12:45 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kmjLm-00HAXe-TJ; Tue, 08 Dec 2020 20:12:43 +0000 Date: Tue, 08 Dec 2020 20:12:41 +0000 Message-ID: <871rg05a6e.wl-maz@kernel.org> From: Marc Zyngier To: David Brazdil Cc: kvmarm@lists.cs.columbia.edu, Catalin Marinas , Lorenzo Pieralisi , linux-kernel@vger.kernel.org, Will Deacon , Tejun Heo , Dennis Zhou , linux-doc@vger.kernel.org, Jonathan Corbet , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, Christoph Lameter , Sudeep Holla Subject: Re: [PATCH v4 00/26] Opt-in always-on nVHE hypervisor In-Reply-To: <20201208191447.47idqf7n2v3hvrdg@google.com> References: <20201202184122.26046-1-dbrazdil@google.com> <160702322202.1501317.9696987088711766533.b4-ty@kernel.org> <20201208191447.47idqf7n2v3hvrdg@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dbrazdil@google.com, kvmarm@lists.cs.columbia.edu, catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, linux-kernel@vger.kernel.org, will@kernel.org, tj@kernel.org, dennis@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, cl@linux.com, sudeep.holla@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, 08 Dec 2020 19:14:47 +0000, David Brazdil wrote: > > Hey Marc, > > On Thu, Dec 03, 2020 at 07:23:19PM +0000, Marc Zyngier wrote: > > On Wed, 2 Dec 2020 18:40:56 +0000, David Brazdil wrote: > > > As we progress towards being able to keep guest state private to the > > > host running nVHE hypervisor, this series allows the hypervisor to > > > install itself on newly booted CPUs before the host is allowed to run > > > on them. > > > > > > All functionality described below is opt-in, guarded by an early param > > > 'kvm-arm.mode=protected'. Future patches specific to the new protected > > > mode should be hidden behind the same param. > > > > > > [...] > > > > Applied to kvm-arm64/psci-relay, thanks! > > > > Note that although I pushed it to -next, I still need people to > > eyeball it and give it some Acks. The commit-IDs below will > > thus change as I apply tags, if any. > > > > I'm looking at -next and I think the merge with Mark Rutland's el2_setup > refactor didn't go as planned. > > The `#ifdef CONFIG_ARM64_VHE` section needs to cover everything between > init_el2 and init_el2_nvhe. Currently the code falls through into VHE init > when CONFIG_ARM64_VHE is not set. Oops, well spotted. I wasn't thinking straight. I came up with a slightly different fix though, keeping the whole of the VHE code and instead restoring the "mov x2, xzr" we had before. I've pushed something out, do yell if you spot anything else. Thanks again, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC94C4361B for ; Tue, 8 Dec 2020 20:14:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5164722285 for ; Tue, 8 Dec 2020 20:14:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5164722285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sxMhqI4Jq1TRcuZDqwSrbQvH3dsMtWOlgEtmhld00nM=; b=Vue8bYDSsTEeoiMg57Kmhz+fN 7JZRGKvUWBewr5s39YtEGI6LEucRCLPHKVjqfkGMBmHwZDhSUzGtUFUrlyLuoljGy8VQnZh1KwmrU Ajmx4+VmAE01fe9xEQFu/PwrcJh4T7UHz1VP9Ca5TpmQ9tYzYx7lw/IsdsI9MqMX5PA28bK3aadNF agFV16Q88KWtdpgFpV6bo/042thtAmnsXRQeGxJIyN6Sj4kSVQSzCRD6rjzPukI0TXaqJDKhWulnI wMqD5J89kVxLYlq7esCP5N5EmR7c7QMWiHZi2n+F18uvISVAZgTd4j+AhkY/xO5oKoAW5DU2wLaCb D/rAMRVZQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmjLu-0002CZ-DL; Tue, 08 Dec 2020 20:12:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmjLq-0002CE-Ao for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 20:12:48 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1932923AFE; Tue, 8 Dec 2020 20:12:45 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kmjLm-00HAXe-TJ; Tue, 08 Dec 2020 20:12:43 +0000 Date: Tue, 08 Dec 2020 20:12:41 +0000 Message-ID: <871rg05a6e.wl-maz@kernel.org> From: Marc Zyngier To: David Brazdil Subject: Re: [PATCH v4 00/26] Opt-in always-on nVHE hypervisor In-Reply-To: <20201208191447.47idqf7n2v3hvrdg@google.com> References: <20201202184122.26046-1-dbrazdil@google.com> <160702322202.1501317.9696987088711766533.b4-ty@kernel.org> <20201208191447.47idqf7n2v3hvrdg@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dbrazdil@google.com, kvmarm@lists.cs.columbia.edu, catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, linux-kernel@vger.kernel.org, will@kernel.org, tj@kernel.org, dennis@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, cl@linux.com, sudeep.holla@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_151246_472581_4CB05237 X-CRM114-Status: GOOD ( 25.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Lameter , Lorenzo Pieralisi , linux-doc@vger.kernel.org, Catalin Marinas , Jonathan Corbet , linux-kernel@vger.kernel.org, Sudeep Holla , Tejun Heo , Dennis Zhou , kernel-team@android.com, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 08 Dec 2020 19:14:47 +0000, David Brazdil wrote: > > Hey Marc, > > On Thu, Dec 03, 2020 at 07:23:19PM +0000, Marc Zyngier wrote: > > On Wed, 2 Dec 2020 18:40:56 +0000, David Brazdil wrote: > > > As we progress towards being able to keep guest state private to the > > > host running nVHE hypervisor, this series allows the hypervisor to > > > install itself on newly booted CPUs before the host is allowed to run > > > on them. > > > > > > All functionality described below is opt-in, guarded by an early param > > > 'kvm-arm.mode=protected'. Future patches specific to the new protected > > > mode should be hidden behind the same param. > > > > > > [...] > > > > Applied to kvm-arm64/psci-relay, thanks! > > > > Note that although I pushed it to -next, I still need people to > > eyeball it and give it some Acks. The commit-IDs below will > > thus change as I apply tags, if any. > > > > I'm looking at -next and I think the merge with Mark Rutland's el2_setup > refactor didn't go as planned. > > The `#ifdef CONFIG_ARM64_VHE` section needs to cover everything between > init_el2 and init_el2_nvhe. Currently the code falls through into VHE init > when CONFIG_ARM64_VHE is not set. Oops, well spotted. I wasn't thinking straight. I came up with a slightly different fix though, keeping the whole of the VHE code and instead restoring the "mov x2, xzr" we had before. I've pushed something out, do yell if you spot anything else. Thanks again, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel