From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D78F1C43463 for ; Mon, 21 Sep 2020 09:20:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94FCF20BED for ; Mon, 21 Sep 2020 09:20:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726347AbgIUJUq (ORCPT ); Mon, 21 Sep 2020 05:20:46 -0400 Received: from mga03.intel.com ([134.134.136.65]:3220 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgIUJUp (ORCPT ); Mon, 21 Sep 2020 05:20:45 -0400 IronPort-SDR: mi9X1DpcFSBOBVXIftCpo0qvDLPKZc+A5uWEEix/mHTDSu46aHfix4NU4PE+Ii3OYgl4PvbLqL W8GvODca/kvA== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="160393758" X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="160393758" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 02:20:42 -0700 IronPort-SDR: QnzPM9M9h2F2s0POMjDYZwrSHaFwQcH6LaraSEMoqaxR8Plh60hbrn8SlpFwXi011Bz1JhLDx3 JD34DrGHcbag== X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="453942444" Received: from pamcglyn-mobl.ger.corp.intel.com (HELO localhost) ([10.251.84.51]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 02:20:37 -0700 From: Jani Nikula To: Rob Clark , dri-devel@lists.freedesktop.org Cc: Rob Clark , Peter Zijlstra , linux-arm-msm@vger.kernel.org, open list , timmurray@google.com, David Airlie , Thomas Zimmermann , Tejun Heo Subject: Re: [PATCH 1/3] drm/crtc: Introduce per-crtc kworker In-Reply-To: <20200919193727.2093945-2-robdclark@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200919193727.2093945-1-robdclark@gmail.com> <20200919193727.2093945-2-robdclark@gmail.com> Date: Mon, 21 Sep 2020 12:20:46 +0300 Message-ID: <871rivscy9.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat, 19 Sep 2020, Rob Clark wrote: > From: Rob Clark > > This will be used for non-block atomic commits. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/drm_crtc.c | 11 +++++++++++ > include/drm/drm_crtc.h | 8 ++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index aecdd7ea26dc..4f7c0bfce0a3 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -326,6 +326,14 @@ int drm_crtc_init_with_planes(struct drm_device *dev, struct drm_crtc *crtc, > config->prop_out_fence_ptr, 0); > drm_object_attach_property(&crtc->base, > config->prop_vrr_enabled, 0); > + > + crtc->worker = kthread_create_worker(0, "%s-worker", crtc->name); > + if (IS_ERR(crtc->worker)) { > + drm_mode_object_unregister(dev, &crtc->base); > + ret = PTR_ERR(crtc->worker); > + crtc->worker = NULL; > + return ret; > + } > } > > return 0; > @@ -366,6 +374,9 @@ void drm_crtc_cleanup(struct drm_crtc *crtc) > > kfree(crtc->name); > > + if (crtc->worker) > + kthread_destroy_worker(crtc->worker); > + > memset(crtc, 0, sizeof(*crtc)); > } > EXPORT_SYMBOL(drm_crtc_cleanup); > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 59b51a09cae6..8964a3732bca 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include A forward declaration would suffice. > #include > #include > #include > @@ -1172,6 +1173,13 @@ struct drm_crtc { > * Initialized via drm_self_refresh_helper_init(). > */ > struct drm_self_refresh_data *self_refresh_data; > + > + /** > + * worker: Missing @, should be "@worker:". > + * > + * Per-CRTC worker for nonblock atomic commits. > + */ > + struct kthread_worker *worker; > }; > > /** -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1132EC43464 for ; Mon, 21 Sep 2020 09:20:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ED7920BED for ; Mon, 21 Sep 2020 09:20:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ED7920BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A4F226E247; Mon, 21 Sep 2020 09:20:48 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E0946E247 for ; Mon, 21 Sep 2020 09:20:46 +0000 (UTC) IronPort-SDR: 7MI7FGLbH1VkV+whW+eYkg98EPA/SLhCWrw5HQr72xx7tomUwE85sj5v9e7Rqklg1Im9z/JMJK VADJNTteGKHg== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="157726253" X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="157726253" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 02:20:42 -0700 IronPort-SDR: QnzPM9M9h2F2s0POMjDYZwrSHaFwQcH6LaraSEMoqaxR8Plh60hbrn8SlpFwXi011Bz1JhLDx3 JD34DrGHcbag== X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="453942444" Received: from pamcglyn-mobl.ger.corp.intel.com (HELO localhost) ([10.251.84.51]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 02:20:37 -0700 From: Jani Nikula To: Rob Clark , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/crtc: Introduce per-crtc kworker In-Reply-To: <20200919193727.2093945-2-robdclark@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200919193727.2093945-1-robdclark@gmail.com> <20200919193727.2093945-2-robdclark@gmail.com> Date: Mon, 21 Sep 2020 12:20:46 +0300 Message-ID: <871rivscy9.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Peter Zijlstra , linux-arm-msm@vger.kernel.org, open list , timmurray@google.com, David Airlie , Thomas Zimmermann , Tejun Heo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 19 Sep 2020, Rob Clark wrote: > From: Rob Clark > > This will be used for non-block atomic commits. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/drm_crtc.c | 11 +++++++++++ > include/drm/drm_crtc.h | 8 ++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index aecdd7ea26dc..4f7c0bfce0a3 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -326,6 +326,14 @@ int drm_crtc_init_with_planes(struct drm_device *dev, struct drm_crtc *crtc, > config->prop_out_fence_ptr, 0); > drm_object_attach_property(&crtc->base, > config->prop_vrr_enabled, 0); > + > + crtc->worker = kthread_create_worker(0, "%s-worker", crtc->name); > + if (IS_ERR(crtc->worker)) { > + drm_mode_object_unregister(dev, &crtc->base); > + ret = PTR_ERR(crtc->worker); > + crtc->worker = NULL; > + return ret; > + } > } > > return 0; > @@ -366,6 +374,9 @@ void drm_crtc_cleanup(struct drm_crtc *crtc) > > kfree(crtc->name); > > + if (crtc->worker) > + kthread_destroy_worker(crtc->worker); > + > memset(crtc, 0, sizeof(*crtc)); > } > EXPORT_SYMBOL(drm_crtc_cleanup); > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 59b51a09cae6..8964a3732bca 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include A forward declaration would suffice. > #include > #include > #include > @@ -1172,6 +1173,13 @@ struct drm_crtc { > * Initialized via drm_self_refresh_helper_init(). > */ > struct drm_self_refresh_data *self_refresh_data; > + > + /** > + * worker: Missing @, should be "@worker:". > + * > + * Per-CRTC worker for nonblock atomic commits. > + */ > + struct kthread_worker *worker; > }; > > /** -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel