From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdBfT-0001TO-NS for ath10k@lists.infradead.org; Mon, 25 May 2020 11:53:22 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: add SDIO firmware for QCA9377 WiFi References: <20200524135933.1623-1-christianshewitt@gmail.com> <37BB0344-C9EB-41F5-87E7-D66DA45A488E@gmail.com> Date: Mon, 25 May 2020 14:53:10 +0300 In-Reply-To: <37BB0344-C9EB-41F5-87E7-D66DA45A488E@gmail.com> (Christian Hewitt's message of "Mon, 25 May 2020 09:09:35 +0400") Message-ID: <871rn89qop.fsf@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Christian Hewitt Cc: Josh Boyer , Linux Wireless , Linux Firmware , ath10k@lists.infradead.org Q2hyaXN0aWFuIEhld2l0dCA8Y2hyaXN0aWFuc2hld2l0dEBnbWFpbC5jb20+IHdyaXRlczoKCj4+ IE9uIDI0IE1heSAyMDIwLCBhdCA4OjM0IHBtLCBKb3NoIEJveWVyIDxqd2JveWVyQGtlcm5lbC5v cmc+IHdyb3RlOgo+PiAKPj4gT24gU3VuLCBNYXkgMjQsIDIwMjAgYXQgOTo1OSBBTSBDaHJpc3Rp YW4gSGV3aXR0Cj4+IDxjaHJpc3RpYW5zaGV3aXR0QGdtYWlsLmNvbT4gd3JvdGU6Cj4+PiAKPj4+ IFRoaXMgY29tbWl0IGFkZHMgdGhlIFNESU8gZmlybXdhcmUgZm9yIGF0aDEway9RQ0E5Mzc3IGNh cmRzLiBUaGUgZmlsZQo+Pj4gaXMgZnJvbSB0aGUgQm91bmRhcnkgRGV2aWNlcyByZXBvIFsxXSBh bmQgaGFzIHRoZSBzYW1lIGxpY2Vuc2UgYXMgdGhlCj4+PiBleGlzdGluZyBmaXJtd2FyZS01LmJp biBmaWxlLiBTdXBwb3J0IGZvciBRQ0E5Mzc3IFdpRmkgd2FzIG1lcmdlZCBmb3IKPj4+IExpbnV4 IDUuNyBbMl0uCj4+PiAKPj4+IFsxXSBodHRwczovL2dpdGh1Yi5jb20vYm91bmRhcnlkZXZpY2Vz L3FjYS1maXJtd2FyZS90cmVlL2JkLXNkbWFjLWF0aDEwawo+Pj4gWzJdCj4+PiBodHRwczovL2dp dGh1Yi5jb20vdG9ydmFsZHMvbGludXgvY29tbWl0LzZlNTFiMGU0OTEzY2EyYzkzMDU5ZjczY2E0 NzdjYTMwZWE5NWI2YTAKPj4gCj4+IFRoYXQgcmVwbyBnb3QgaXQgZnJvbSBLYWxsZSdzIHVudGVz dGVkIHJlcG8sIGFuZCBkaWRuJ3QgY2Fycnkgb3ZlciB0aGUKPj4gU2lnbmVkLW9mZi1ieS4gIFlv dSBkaWRuJ3QgY2Fycnkgb3ZlciB0aGUgU2lnbmVkLW9mZi1ieSBmcm9tIHRoZSByZXBvCj4+IHlv dSBnb3QgaXQgZnJvbS4gIDMgbGV2ZWxzIG9mIGluZGlyZWN0aW9uIHRvIGluY2x1ZGUgYSBmaWxl IHdpdGggYQo+PiBnaWFudCBub3RpY2UgZnJvbSBhbiB1bnRlc3RlZCBzb3VyY2VzIGlzIGEgYml0 IHRvbyBtdWNoIGZvciBtZSB0byBmZWVsCj4+IGNvbWZvcnRhYmxlIHdpdGguCj4KPiBBcG9sb2dp ZXMgSm9zaCwgSSBoYXZlIGJlZW4gdXNpbmcgbXkgb3duIHJlcGFjayBvZiB0aGUgQm91bmRhcnkg RGV2aWNlcwo+IHJlcG8gYW5kIGhhZCBjb21wbGV0ZWx5IGZvcmdvdHRlbiBLYWxsZeKAmXMgcmVw byBleGlzdGVkIGFuZCB3YXMgdGhlCj4gb3JpZ2luYWwgc291cmNlIG9mIHRoZSBmaWxlLgo+Cj4+ IEthbGxlLCBpcyB0aGVyZSBhIHJlYXNvbiB5b3UgZGlkbid0IHNlbmQgdGhpcyB1cHN0cmVhbSAz IHllYXJzIGFnbz8KPgo+IFNESU8gc3VwcG9ydCBpcyBhIHJlbGF0aXZlbHkgcmVjZW50IGFkZGl0 aW9uIHRvIHRoZSBhdGgxMGsgZHJpdmVyIGFuZAo+IHRoZSBjb21taXQgbWVzc2FnZSBpbiB0aGlz IFJGVCBbMV0gcHJvYmFibHkgZXhwbGFpbnMgd2h5IGhpcyByZXBvIGhhcwo+IGl0IGRlc2NyaWJl ZCBhcyB1bnRlc3RlZC4KPgo+IEnigJltIGhhcHB5IHRvIHN1Ym1pdCB2MiB3aXRoIGNvcnJlY3Rl ZCByZWZlcmVuY2VzIG9yIGxldCBLYWxsZSBoYW5kbGUKPiB0aGUgc3VibWlzc2lvbiwgd2hpY2hl dmVyIGlzIGJlc3Qgb3IgZWFzaWVzdCBpcyBmaW5lIHdpdGggbWUuCgpJJ2xsIGluY2x1ZGUgdGhl IFFDQTkzNzcgU0RJTyBpbWFnZSBpbiBteSBuZXh0IHB1bGwgcmVxdWVzdCB0byBKb3NoLgpJJ2xs IGFsc28gaGF2ZSBRQ0E2MTc0IFNESU8gaW1hZ2VzIHBlbmRpbmcuCgotLSAKaHR0cHM6Ly93aXJl bGVzcy53aWtpLmtlcm5lbC5vcmcvZW4vZGV2ZWxvcGVycy9kb2N1bWVudGF0aW9uL3N1Ym1pdHRp bmdwYXRjaGVzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6539AC433E1 for ; Mon, 25 May 2020 11:53:16 +0000 (UTC) Received: by mail.kernel.org (Postfix) id 5967B2087D; Mon, 25 May 2020 11:53:16 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 26273C433C6; Mon, 25 May 2020 11:53:16 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6D8BCC433C6; Mon, 25 May 2020 11:53:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6D8BCC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Christian Hewitt List-Id: Cc: Josh Boyer , Linux Wireless , ath10k@lists.infradead.org, Linux Firmware Subject: Re: [PATCH] ath10k: add SDIO firmware for QCA9377 WiFi References: <20200524135933.1623-1-christianshewitt@gmail.com> <37BB0344-C9EB-41F5-87E7-D66DA45A488E@gmail.com> Date: Mon, 25 May 2020 14:53:10 +0300 In-Reply-To: <37BB0344-C9EB-41F5-87E7-D66DA45A488E@gmail.com> (Christian Hewitt's message of "Mon, 25 May 2020 09:09:35 +0400") Message-ID: <871rn89qop.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Christian Hewitt writes: >> On 24 May 2020, at 8:34 pm, Josh Boyer wrote: >>=20 >> On Sun, May 24, 2020 at 9:59 AM Christian Hewitt >> wrote: >>>=20 >>> This commit adds the SDIO firmware for ath10k/QCA9377 cards. The file >>> is from the Boundary Devices repo [1] and has the same license as the >>> existing firmware-5.bin file. Support for QCA9377 WiFi was merged for >>> Linux 5.7 [2]. >>>=20 >>> [1] https://github.com/boundarydevices/qca-firmware/tree/bd-sdmac-ath10k >>> [2] >>> https://github.com/torvalds/linux/commit/6e51b0e4913ca2c93059f73ca477ca= 30ea95b6a0 >>=20 >> That repo got it from Kalle's untested repo, and didn't carry over the >> Signed-off-by. You didn't carry over the Signed-off-by from the repo >> you got it from. 3 levels of indirection to include a file with a >> giant notice from an untested sources is a bit too much for me to feel >> comfortable with. > > Apologies Josh, I have been using my own repack of the Boundary Devices > repo and had completely forgotten Kalle=E2=80=99s repo existed and was the > original source of the file. > >> Kalle, is there a reason you didn't send this upstream 3 years ago? > > SDIO support is a relatively recent addition to the ath10k driver and > the commit message in this RFT [1] probably explains why his repo has > it described as untested. > > I=E2=80=99m happy to submit v2 with corrected references or let Kalle han= dle > the submission, whichever is best or easiest is fine with me. I'll include the QCA9377 SDIO image in my next pull request to Josh. I'll also have QCA6174 SDIO images pending. --=20 https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes