From: Kalle Valo <kvalo@codeaurora.org>
To: <yhchuang@realtek.com>
Cc: <linux-wireless@vger.kernel.org>, <kevlo@kevlo.org>
Subject: Re: [PATCH] Revert "rtw88: no need to set registers for SDIO"
Date: Fri, 22 May 2020 13:27:41 +0300 [thread overview]
Message-ID: <871rncb6xu.fsf@codeaurora.org> (raw)
In-Reply-To: <20200520055350.23328-1-yhchuang@realtek.com> (yhchuang@realtek.com's message of "Wed, 20 May 2020 13:53:50 +0800")
<yhchuang@realtek.com> writes:
> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> This reverts commit 07d0f5534935e2daf63a4e1012af13d68e089fed.
>
> For rtw88 driver, the SDIO is going to be supported, so there is
> no need to remove the SDIO related power sequence settings. And
> while the power sequence parser will pass in the mask of the HCI,
> the SDIO part will not be used to set registers accordingly.
>
> Moreover, the power sequence table is released as a whole package,
> so the next time if we are going to update, the SDIO settings will
> be overwritten. So, revert this now.
>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Oops, I was supposed to drop that patch but somehow I did apply it
anyway. Sorry about that, I'll apply this revert.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-22 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 5:53 [PATCH] Revert "rtw88: no need to set registers for SDIO" yhchuang
2020-05-22 10:27 ` Kalle Valo [this message]
2020-05-25 2:20 ` Tony Chuang
2020-05-29 17:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rncb6xu.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=kevlo@kevlo.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.