From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E11F6C43331 for ; Fri, 27 Mar 2020 01:28:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B325020774 for ; Fri, 27 Mar 2020 01:28:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B325020774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 49F976E973; Fri, 27 Mar 2020 01:28:18 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36F936E973 for ; Fri, 27 Mar 2020 01:28:17 +0000 (UTC) IronPort-SDR: tkicNWpGh3ZCJ3v7D19NCPLXZefjmKSuZuM1ITo3D4zReBYYQJtFsrvnSat4qb6WVJa9kK4Y/C XsYL/Zp7Cvig== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 18:28:16 -0700 IronPort-SDR: PkPEEXq+Q6c6GJbaCpre2CiNTx12xWAhcB/CHrbkCFaukIZ8ox8/c+Rc9EAa5IdXdZLdeFW239 fhiRoPXNP4KQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,310,1580803200"; d="scan'208";a="448844465" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.134.77.53]) by fmsmga006.fm.intel.com with ESMTP; 26 Mar 2020 18:28:15 -0700 Date: Thu, 26 Mar 2020 18:28:15 -0700 Message-ID: <871rpetwls.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20200326180246.GB9553@orsosgc001.amr.corp.intel.com> References: <98393a3bbd2652886d895e1c3250e43c6e0f1a24.1585160174.git.ashutosh.dixit@intel.com> <20200326003235.GA9553@orsosgc001.amr.corp.intel.com> <877dz7ubkb.wl-ashutosh.dixit@intel.com> <20200326180246.GB9553@orsosgc001.amr.corp.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [Intel-gfx] [PATCH] drm/i915/perf: Do not clear pollin for small user read buffers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 26 Mar 2020 11:02:46 -0700, Umesh Nerlige Ramappa wrote: > On Wed, Mar 25, 2020 at 06:52:52PM -0700, Dixit, Ashutosh wrote: > > On Wed, 25 Mar 2020 17:32:35 -0700, Umesh Nerlige Ramappa wrote: > >> > >> On Wed, Mar 25, 2020 at 11:20:19AM -0700, Ashutosh Dixit wrote: > >> > > >> > + /* Possible values for __ret are 0, -EFAULT, -ENOSPC, -EAGAIN, ... */ > >> > >> __ret may never be EAGAIN either (comment^). I don't see EAGAIN in the read > >> path. > > > > It's here: > > > > gen8_append_oa_reports() > > { > > > > /* > > * An invalid tail pointer here means we're still waiting for the poll > > * hrtimer callback to give us a pointer > > */ > > if (tail == INVALID_TAIL_PTR) > > return -EAGAIN; > > } > > Oh, you are right, EAGAIN is returned here. I was looking for it with the > poll period patch series applied and these references are removed in that > series. No, you are right, since that series is likely to be merged first, it is better to remove it from this patch. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx