From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC46BC10DCE for ; Fri, 6 Mar 2020 09:10:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92F1C2072A for ; Fri, 6 Mar 2020 09:10:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hp4gqjGV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92F1C2072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jA90T-0006JT-Kt for qemu-devel@archiver.kernel.org; Fri, 06 Mar 2020 04:10:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45632) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jA8zt-0005mt-6a for qemu-devel@nongnu.org; Fri, 06 Mar 2020 04:10:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jA8zr-0008Q9-Rd for qemu-devel@nongnu.org; Fri, 06 Mar 2020 04:10:20 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:25679 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jA8zr-0008N7-MA for qemu-devel@nongnu.org; Fri, 06 Mar 2020 04:10:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583485818; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x2OytJ2ingUzW6byBRRXUqfMXnh9rKtoQxsDTKOxHZU=; b=Hp4gqjGVLHy3fyPrg8h/wg+EPsirz6p5keSRCnPWYVY3c8WVKKavrj1vFSsz9FsueNbR+0 vZfRlLbGWRbDMPH+rPM8A4bD1oG/v1uuBG8sgxr3Ah31LXIwQmiyIIhAkajODJABDOZo7j Zr3QdpLQ+6KpF+NBh+SMyibOB7Mua0I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-461-mW9GIMYsMg6qhCep6A_1sg-1; Fri, 06 Mar 2020 04:10:17 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 02C10189F760; Fri, 6 Mar 2020 09:10:16 +0000 (UTC) Received: from redhat.com (ovpn-116-72.ams2.redhat.com [10.36.116.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86CC65DA7B; Fri, 6 Mar 2020 09:10:15 +0000 (UTC) From: Juan Quintela To: Michal =?utf-8?B?UHLDrXZvem7DrWs=?= Subject: Re: [PATCH] configure: Improve zstd test In-Reply-To: <5b2ff215-ef9c-2981-5467-b79ad7af7a34@redhat.com> ("Michal =?utf-8?B?UHLDrXZvem7DrWsiJ3M=?= message of "Fri, 6 Mar 2020 09:49:59 +0100") References: <20200305103427.157658-1-quintela@redhat.com> <87imji6eio.fsf@linaro.org> <87h7z2g6te.fsf@secure.laptop> <5b2ff215-ef9c-2981-5467-b79ad7af7a34@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Fri, 06 Mar 2020 10:10:10 +0100 Message-ID: <871rq5g87h.fsf@secure.laptop> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: mW9GIMYsMg6qhCep6A_1sg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Richard Henderson , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Michal Pr=C3=ADvozn=C3=ADk wrote: > On 5. 3. 2020 16:27, Juan Quintela wrote: >> Alex Benn=C3=A9e wrote: >>> Juan Quintela writes: >>> >>>> There were one error on the test (missing an s for --exists). >>>> But we really need a recent zstd (0.8.1). >>>> That version was released in 2016, so it is newer that some of our tra= vis >>>> images. Just check for the version that we need. >>>> >>>> Signed-off-by: Juan Quintela >>>> Reported-by: Richard Henderson >>>> --- >>>> configure | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/configure b/configure >>>> index 7b373bc0bb..1bf48df1ef 100755 >>>> --- a/configure >>>> +++ b/configure >>>> @@ -2464,7 +2464,8 @@ fi >>>> # zstd check >>>> =20 >>>> if test "$zstd" !=3D "no" ; then >>>> - if $pkg_config --exist libzstd ; then >>>> + libzstd_minver=3D"0.8.1" >>>> + if $pkg_config --atleast-version=3D$libzstd_minver libzstd ; then >>>> zstd_cflags=3D"$($pkg_config --cflags libzstd)" >>>> zstd_libs=3D"$($pkg_config --libs libzstd)" >>>> LIBS=3D"$zstd_libs $LIBS" >>> >>> Hmm still breaks with: >>> >>> make docker-test-build@ubuntu J=3D9 V=3D1 >>=20 >> Thanks. >>=20 >>> With: >>> >>> FY_SOURCE=3D2 -g -c -o monitor/qmp.o /tmp/qemu-test/src/monitor/qmp= .c >>> /tmp/qemu-test/src/migration/multifd-zstd.c: In function 'zstd_send_p= repare': >>> /tmp/qemu-test/src/migration/multifd-zstd.c:125:9: error: unknown typ= e name 'ZSTD_EndDirective'; did you mean 'ZSTD_DDict'? >>> ZSTD_EndDirective flush =3D ZSTD_e_continue; >>> ^~~~~~~~~~~~~~~~~ >>=20 >> Greate, more things were introduced later. >> As it would be too easy, the zstd repository is not lineal, you need to >> checkout the tag you want to see when something has been introduced. >>=20 >> Will try to get this fixed. >>=20 >> Sorry for the inconveniences. >>=20 >>=20 >>> Version: 1.3.8+dfsg-3 >>> Depends: libzstd1 (=3D 1.3.8+dfsg-3) >>> Description: fast lossless compression algorithm -- development files >>=20 >> I don't undertsand now. >>=20 >> ZSTD_EndDirective was included in 1.3.0. >>=20 >> I can just change that for 1.3.9, but I don't know why is that there. >> Could you do a grep ZSTD_EndDirective /usr/lib/zstd.h? > > Thing is, they have so called experimental APIs. You get them only if > you define ZSTD_STATIC_LINKING_ONLY before including zstd.h. So the > plain grep of a symbol tells us nothing. We need to check if it's not in > #ifdef. Looks like 1.3.9 is the minimal version which has everything we > want. So easy!!!!! I was arriving to that conclusion after brute force. Later, Juan.