All of lore.kernel.org
 help / color / mirror / Atom feed
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr <olekstysh@gmail.com>,
	Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] iommu/arm: Don't allow the same micro-TLB to be shared between domains
Date: Thu, 30 Jan 2020 15:20:21 +0000	[thread overview]
Message-ID: <871rrhotsb.fsf@epam.com> (raw)
In-Reply-To: <8736bxougo.fsf@epam.com>



Volodymyr Babchuk writes:

Oleksandr,

[...]
>> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> index c21d2d7..411fc0f 100644
>> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> @@ -702,7 +702,12 @@ static int ipmmu_attach_device(struct
>> ipmmu_vmsa_domain *domain,
>>          int ret = ipmmu_utlb_enable(domain, fwspec->ids[i]);
>>
>>          if ( ret )
>> +        {
>> +            while ( i-- )
> You will call
>> +                ipmmu_utlb_disable(domain, fwspec->ids[i]);
> for uTLB that caused the error. Likely, this uTLB right now is assigned
> for another domain. So, you will disable active uTLB which belongs to
> that domain. 

Please disregard this. I realized that i-- will ensure that right index
will be used. Sorry for the noise.

-- 
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

      reply	other threads:[~2020-01-30 15:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 14:55 [Xen-devel] [PATCH] iommu/arm: Don't allow the same micro-TLB to be shared between domains Oleksandr Tyshchenko
2020-01-29 16:07 ` Volodymyr Babchuk
2020-01-30 14:34   ` Oleksandr
2020-01-30 15:05     ` Volodymyr Babchuk
2020-01-30 15:20       ` Volodymyr Babchuk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rrhotsb.fsf@epam.com \
    --to=volodymyr_babchuk@epam.com \
    --cc=Oleksandr_Tyshchenko@epam.com \
    --cc=julien@xen.org \
    --cc=olekstysh@gmail.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.