From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 235A3C33CAE for ; Mon, 13 Jan 2020 17:38:11 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D0822207FF for ; Mon, 13 Jan 2020 17:38:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nqIxncL1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0822207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7C0BF4AC80; Mon, 13 Jan 2020 12:38:10 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@linaro.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hupfbo2drhLQ; Mon, 13 Jan 2020 12:38:09 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 30CF54AEFC; Mon, 13 Jan 2020 12:38:09 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BC7754AEF5 for ; Mon, 13 Jan 2020 12:38:07 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lYQ-qduDklLj for ; Mon, 13 Jan 2020 12:38:06 -0500 (EST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 680364A5A3 for ; Mon, 13 Jan 2020 12:38:06 -0500 (EST) Received: by mail-wr1-f66.google.com with SMTP id y11so9499970wrt.6 for ; Mon, 13 Jan 2020 09:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=eI/hjqguFIOdMUSo3q0+87ouKq6C8zjThus+1sH1VO0=; b=nqIxncL1yFiSxKpJfW7b03JH6kat4Dudfk5nBxAOSe9fy852eC0rgDnVwIWEsn77zM dE2aPjfeec9grIBn2D6TKVGWvlCbHoPkDREmeg0ugSwGl0uKWjOqlhz9PFubYFsQ8hJq 8AHQ6VOa8ibgvSsql/4I74XQVotBz96ZolcljqE4cr4l+8cvTw7sEml7DFJSNlRp/B9+ eVWnY0PZROjEhdpBdVDxSkNBYF88APTOPXCBepgcHORk1RgjGlFS/BVQMBIB13S3DoM4 qS2qi++eAdhVtdEtzeRHg8B93xPXcGOz8lnvTcAHy50WvUnbCWZgk+TBfG75rYhImHj8 +nrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=eI/hjqguFIOdMUSo3q0+87ouKq6C8zjThus+1sH1VO0=; b=dQEHJb0CJ8QmS8A8S+0RFzHBUoq0JDNJknDH1PdbMHp7hWkNWrLPWxrXB5/YT55KkZ 71KL/GjRtXeQwZVSC+RD1Ja74kiuG9bZq2f/LUcmRsVI/0iwzOSk+AFo0YbyWK8gI1YS FlHZuzkksDJl2ZUYIUjD8W/VqSwlL8iQdXcGeucUsFoSZ67mI1V33UBZCWFacZZGRG2F l6G/sCMy58UfnAhxZx/RLOiAFH6baSThc6c7poCGsO9SmJFRNk9tV0E0bibhWs6ws1mm Oh5812eRyuUpBnd3Hc+lHu+ItHwKLwE6XIQ/Y4sUKr3M9m5itOD0uCBIjMA5osbGX22R +EaA== X-Gm-Message-State: APjAAAWwgcCynr2sLkk7RwsaFzASS+wEYjqdWh0sh7TVHFvFoje86x0A d32TnMAMCmHjmr6xx4Kzyghc7A== X-Google-Smtp-Source: APXvYqyNWRIWYrBMrEZC8POMivYqJE726L4BZ9LWUi0lr76+NdJQGfH6a/xGkKlsVQXVJu8cb+LQmw== X-Received: by 2002:a5d:6144:: with SMTP id y4mr20201081wrt.367.1578937085286; Mon, 13 Jan 2020 09:38:05 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id x14sm14824060wmj.42.2020.01.13.09.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2020 09:38:04 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7EF811FF87; Mon, 13 Jan 2020 17:38:03 +0000 (GMT) References: <20200110160511.17821-1-alex.bennee@linaro.org> <8455cdf6-e5c3-bd84-5b85-33ffad581d0e@arm.com> User-agent: mu4e 1.3.6; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Alexandru Elisei Subject: Re: [kvm-unit-tests PATCH] arm: expand the timer tests In-reply-to: <8455cdf6-e5c3-bd84-5b85-33ffad581d0e@arm.com> Date: Mon, 13 Jan 2020 17:38:03 +0000 Message-ID: <871rs3ntok.fsf@linaro.org> MIME-Version: 1.0 Cc: linux-arm-kernel@lists.infradead.org, maz@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu CkFsZXhhbmRydSBFbGlzZWkgPGFsZXhhbmRydS5lbGlzZWlAYXJtLmNvbT4gd3JpdGVzOgoKPiBI aSwKPgo+IE9uIDEvMTAvMjAgNDowNSBQTSwgQWxleCBCZW5uw6llIHdyb3RlOgo+PiBUaGlzIHdh cyBhbiBhdHRlbXB0IHRvIHJlcGxpY2F0ZSBhIFFFTVUgYnVnLiBIb3dldmVyIHRvIHRyaWdnZXIg dGhlCj4+IGJ1ZyB5b3UgbmVlZCB0byBoYXZlIGFuIG9mZnNldCBzZXQgaW4gRUwyIHdoaWNoIGt2 bS11bml0LXRlc3RzIGlzCj4+IHVuYWJsZSB0byBkby4gSG93ZXZlciBpdCBkb2VzIGV4ZXJjaXNl IHNvbWUgbW9yZSBjb3JuZXIgY2FzZXMuCj4+Cj4+IEJ1ZzogaHR0cHM6Ly9idWdzLmxhdW5jaHBh ZC5uZXQvYnVncy8xODU5MDIxCj4KPiBJJ20gbm90IGF3YXJlIG9mIGFueSBCdWc6IHRhZ3MgaW4g dGhlIExpbnV4IGtlcm5lbC4gSWYgeW91IHdhbnQgcGVvcGxlIHRvIGZvbGxvdwo+IHRoZSBsaW5r IHRvIHRoZSBidWcsIGhvdyBhYm91dCByZWZlcmVuY2luZyBzb21ldGhpbmcgbGlrZSB0aGlzOgo+ Cj4gIlRoaXMgd2FzIGFuIGF0dGVtcHQgdG8gcmVwbGljYXRlIGEgUUVNVSBidWcgWzFdLiBbLi5d Cj4KPiBbMV0gaHR0cHM6Ly9idWdzLmxhdW5jaHBhZC5uZXQvcWVtdS8rYnVnLzE4NTkwMjEiCgpP SywgSSdsbCBmaXggdGhhdCBpbiB2Mi4KCj4KPiBBbHNvLCBhcmUgbGF1bmNocGFkIGJ1ZyByZXBv cnRzIHBlcm1hbmVudD8gV2lsbCB0aGUgbGluayBzdGlsbCB3b3JrIGluCj4gYSB5ZWFycycgdGlt ZT8KClRoZXkgc2hvdWxkIGJlIC0gdGhleSBhcmUgYSB1bmlxdWUgaWQgYW5kIHdlIHVzZSB0aGVt IGluIHRoZSBRRU1VIHNvdXJjZQp0cmVlLgoKPgo+PiBTaWduZWQtb2ZmLWJ5OiBBbGV4IEJlbm7D qWUgPGFsZXguYmVubmVlQGxpbmFyby5vcmc+Cj4+IC0tLQo+PiAgYXJtL3RpbWVyLmMgfCAyNyAr KysrKysrKysrKysrKysrKysrKysrKysrKy0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9hcm0vdGltZXIuYyBiL2Fy bS90aW1lci5jCj4+IGluZGV4IGYzOTBlOGUuLmFlMWQyOTkgMTAwNjQ0Cj4+IC0tLSBhL2FybS90 aW1lci5jCj4+ICsrKyBiL2FybS90aW1lci5jCj4+IEBAIC0yMTQsMjEgKzIxNCw0NiBAQCBzdGF0 aWMgdm9pZCB0ZXN0X3RpbWVyKHN0cnVjdCB0aW1lcl9pbmZvICppbmZvKQo+PiAgCSAqIHN0aWxs IHJlYWQgdGhlIHBlbmRpbmcgc3RhdGUgZXZlbiBpZiBpdCdzIGRpc2FibGVkLiAqLwo+PiAgCXNl dF90aW1lcl9pcnFfZW5hYmxlZChpbmZvLCBmYWxzZSk7Cj4+ICAKPj4gKwkvKiBWZXJpZnkgY291 bnQgZ29lcyB1cCAqLwo+PiArCXJlcG9ydChpbmZvLT5yZWFkX2NvdW50ZXIoKSA+PSBub3csICJj b3VudGVyIGluY3JlbWVudHMiKTsKPj4gKwo+PiAgCS8qIEVuYWJsZSB0aGUgdGltZXIsIGJ1dCBz Y2hlZHVsZSBpdCBmb3IgbXVjaCBsYXRlciAqLwo+PiAgCWluZm8tPndyaXRlX2N2YWwobGF0ZXIp Owo+PiAgCWluZm8tPndyaXRlX2N0bChBUkNIX1RJTUVSX0NUTF9FTkFCTEUpOwo+PiAgCWlzYigp Owo+PiAtCXJlcG9ydCghZ2ljX3RpbWVyX3BlbmRpbmcoaW5mbyksICJub3QgcGVuZGluZyBiZWZv cmUiKTsKPj4gKwlyZXBvcnQoIWdpY190aW1lcl9wZW5kaW5nKGluZm8pLCAibm90IHBlbmRpbmcg YmVmb3JlIDEwcyIpOwo+PiArCj4+ICsJLyogQ2hlY2sgd2l0aCBhIG1heGltdW0gcG9zc2libGUg Y3ZhbCAqLwo+PiArCWluZm8tPndyaXRlX2N2YWwoVUlOVDY0X01BWCk7Cj4+ICsJaXNiKCk7Cj4+ ICsJcmVwb3J0KCFnaWNfdGltZXJfcGVuZGluZyhpbmZvKSwgIm5vdCBwZW5kaW5nIGJlZm9yZSBV SU5UNjRfTUFYIik7Cj4+ICsKPj4gKwkvKiBhbHNvIGJ5IHNldHRpbmcgdHZhbCAqLwo+Cj4gQWxs IHRoZSBjb21tZW50cyBpbiB0aGlzIGZpbGUgc2VlbSB0byBzdGFydCB3aXRoIGEgY2FwaXRhbCBs ZXR0ZXIuCj4KPj4gKwlpbmZvLT53cml0ZV90dmFsKHRpbWVfMTBzKTsKPj4gKwlpc2IoKTsKPj4g KwlyZXBvcnQoIWdpY190aW1lcl9wZW5kaW5nKGluZm8pLCAibm90IHBlbmRpbmcgYmVmb3JlIDEw cyAodmlhIHR2YWwpIik7Cj4KPiBZb3UgY2FuIHJlbW92ZSB0aGUgIih2aWEgdHZhbCkiIHBhcnQg LSB0aGUgbWVzc2FnZSBpcyB1bmlxdWUgZW5vdWdoIHRvIGZpZ3VyZSBvdXQKPiB3aGljaCBwYXJ0 IG9mIHRoZSB0ZXN0IGl0IHJlZmVycyB0by4KCkkgYWRkZWQgaXQgdG8gZGlmZmVyZW50aWF0ZSB3 aXRoIHRoZSBtZXNzYWdlIGEgbGl0dGxlIGZ1cnRoZXIgYWJvdmUuCgo+PiArCXJlcG9ydF9pbmZv KCJUVkFMIGlzICVkIChkZWx0YSBDVkFMICVsZCkgdGlja3MiLAo+PiArCQkgICAgaW5mby0+cmVh ZF90dmFsKCksIGluZm8tPnJlYWRfY3ZhbCgpIC0gaW5mby0+cmVhZF9jb3VudGVyKCkpOwo+Cj4g SSdtIG5vdCBzdXJlIHdoYXQgeW91IGFyZSB0cnlpbmcgdG8gYWNoaWV2ZSB3aXRoIHRoaXMuIFlv dSBjYW4gdHJhbnNmb3JtIGl0IHRvCj4gY2hlY2sgdGhhdCBUVkFMIGlzIGluZGVlZCBwb3NpdGl2 ZSBhbmQgKGFsbW9zdCkgZXF1YWwgdG8gY3ZhbCAtIGNudHBjdCwgc29tZXRoaW5nCj4gbGlrZSB0 aGlzOgo+Cj4gKwlzMzIgdHZhbCA9IGluZm8tPnJlYWRfdHZhbCgpOwo+ICsJcmVwb3J0KHR2YWwg PiAwICYmIHR2YWwgPD0gaW5mby0+cmVhZF9jdmFsKCkgLQo+IGluZm8tPnJlYWRfY291bnRlcigp LCAiVFZBTCBtZWFzdXJlcyB0aW1lIHRvIG5leHQgaW50ZXJydXB0Iik7CgpZZXMgaXQgd2FzIHB1 cmVseSBpbmZvcm1hdGlvbmFsIHRvIHNheSB0dmFsIGRlY3JlbWVudHMgdG93YXJkcyB0aGUgbmV4 dApJUlEuIEkgY2FuIG1ha2UgaXQgYSBwdXJlIHRlc3QuCgo+Cj4+ICAKPj4gKyAgICAgICAgLyog Y2hlY2sgcGVuZGluZyBvbmNlIGN2YWwgaXMgYmVmb3JlIG5vdyAqLwo+Cj4gVGhpcyBjb21tZW50 IGFkZHMgbm90aGluZyB0byB0aGUgdGVzdC4KCmRyb3BwZWQuCgo+Cj4+ICAJaW5mby0+d3JpdGVf Y3ZhbChub3cgLSAxKTsKPj4gIAlpc2IoKTsKPj4gIAlyZXBvcnQoZ2ljX3RpbWVyX3BlbmRpbmco aW5mbyksICJpbnRlcnJ1cHQgc2lnbmFsIHBlbmRpbmciKTsKPj4gKwlyZXBvcnRfaW5mbygiVFZB TCBpcyAlZCB0aWNrcyIsIGluZm8tPnJlYWRfdHZhbCgpKTsKPgo+IFlvdSBjYW4gdGVzdCB0aGF0 IFRWQUwgaXMgbmVnYXRpdmUgaGVyZSBpbnN0ZWFkIG9mIHByaW50aW5nIHRoZSB2YWx1ZS4KCm9r LgoKPgo+PiAgCj4+ICAJLyogRGlzYWJsZSB0aGUgdGltZXIgYWdhaW4gYW5kIHByZXBhcmUgdG8g dGFrZSBpbnRlcnJ1cHRzICovCj4+ICAJaW5mby0+d3JpdGVfY3RsKDApOwo+PiAgCXNldF90aW1l cl9pcnFfZW5hYmxlZChpbmZvLCB0cnVlKTsKPj4gIAlyZXBvcnQoIWdpY190aW1lcl9wZW5kaW5n KGluZm8pLCAiaW50ZXJydXB0IHNpZ25hbCBubyBsb25nZXIgcGVuZGluZyIpOwo+PiAgCj4+ICsJ LyogUUVNVSBidWcgd2hlbiBjbnR2b2ZmX2VsMiA+IDAKPj4gKwkgKiBodHRwczovL2J1Z3MubGF1 bmNocGFkLm5ldC9idWdzLzE4NTkwMjEgKi8KPgo+IFRoaXMgbG9va3MgY29uZnVzaW5nIHRvIG1l LiBGcm9tIHRoZSBjb21taXQgbWVzc2FnZSwgSSBnb3QgdGhhdCBrdm0tdW5pdC10ZXN0cwo+IG5l ZWRzIHFlbXUgdG8gc2V0IGEgc3BlY2lhbCB2YWx1ZSBmb3IgQ05UVk9GRl9FTDIuIEJ1dCB0aGUg Y29tbWVudHMgc2VlbXMgdG8KPiBzdWdnZXN0IHRoYXQga3ZtLXVuaXQtdGVzdHMgY2FuIHRyaWdn ZXIgdGhlIGJ1ZyB3aXRob3V0IHFlbXUgZG9pbmcgYW55dGhpbmcKPiBzcGVjaWFsLiBDYW4geW91 IGVsYWJvcmF0ZSB1bmRlciB3aGljaCBjb25kaXRpb24ga3ZtLXVuaXQtdGVzdHMgY2FuCj4gdHJp Z2dlciB0aGUgYnVnPwoKSXQgY2FuJ3Qgd2l0aG91dCBzb21lIHNvcnQgb2YgbWVjaGFuaXNtIHRv IHNldCB0aGUgaHlwZXJ2aXNvciByZWdpc3RlcnMKYmVmb3JlIHJ1bm5pbmcgdGhlIHRlc3QuIFRo ZSBRRU1VIGJ1ZyBpcyBhbiBvdmVyZmxvdyB3aGVuIGN2YWwgb2YgVUlOVDY0X01BWAp3aXRoIGEg bm9uLXplcm8gQ05UVk9GRl9FTDIuCgpSdW5uaW5nIHVuZGVyIEtWTSB0aGUgaG9zdCBrZXJuZWwg d2lsbCBoYXZlIGxpa2VseSBzZXQgQ05UVk9GRl9FTDIgdG8Kc29tZSBzb3J0IG9mIHZhbHVlIHdp dGg6CgoJdXBkYXRlX3Z0aW1lcl9jbnR2b2ZmKHZjcHUsIGt2bV9waHlzX3RpbWVyX3JlYWQoKSk7 Cgo+Cj4+ICsJaW5mby0+d3JpdGVfY3RsKEFSQ0hfVElNRVJfQ1RMX0VOQUJMRSk7Cj4+ICsJaW5m by0+d3JpdGVfY3ZhbChVSU5UNjRfTUFYKTsKPgo+IFRoZSBvcmRlciBpcyB3cm9uZyAtIHlvdSB3 cml0ZSBDVkFMIGZpcnN0LCAqdGhlbiogZW5hYmxlIHRvIHRpbWVyLiBPdGhlcndpc2UgeW91Cj4g bWlnaHQgZ2V0IGFuIGludGVycnVwdCBiZWNhdXNlIG9mIHRoZSBwcmV2aW91cyBDVkFMIHZhbHVl Lgo+Cj4gVGhlIHByZXZpb3VzIHZhbHVlIGZvciBDVkFMIHdhcyBub3cgLTEsIHNvIHlvdXIgY2hh bmdlIHRyaWdnZXJzIGFuIHVud2FudGVkCj4gaW50ZXJydXB0IGFmdGVyIGVuYWJsaW5nIHRoZSB0 aW1lci4gVGhlIGludGVycnVwdCBoYW5kbGVyIG1hc2tzIHRoZSB0aW1lcgo+IGludGVycnVwdCBh dCB0aGUgdGltZXIgbGV2ZWwsIHdoaWNoIG1lYW5zIHRoYXQgYXMgZmFyIGFzIHRoZSBnaWMgaXMg Y29uY2VybmVkIHRoZQo+IGludGVycnVwdCBpcyBub3QgcGVuZGluZywgbWFraW5nIHRoZSByZXBv cnQgY2FsbCBhZnRlcndhcmRzIHVzZWxlc3MuCj4KPj4gKwlpc2IoKTsKPj4gKwlyZXBvcnQoIWdp Y190aW1lcl9wZW5kaW5nKGluZm8pLCAibm90IHBlbmRpbmcgYmVmb3JlIFVJTlQ2NF9NQVggKGly cXMgb24pIik7Cj4KPiBUaGlzIGNoZWNrIGNhbiBiZSBpbXByb3ZlZC4gWW91IHdhbnQgdG8gY2hl Y2sgdGhlIHRpbWVyIENUTC5JU1RBVFVTIGhlcmUsIG5vdCB0aGUKPiBnaWMuIEEgZGV2aWNlIChp biB0aGlzIGNhc2UsIHRoZSB0aW1lcikgY2FuIGFzc2VydCB0aGUgaW50ZXJydXB0LCBidXQgdGhl IGdpYyBkb2VzCj4gbm90IHNhbXBsZSBpdCBpbW1lZGlhdGVseS4gQ29tZSB0byB0aGluayBvZiBp dCwgdGhlIGVudGlyZSB0aW1lciB0ZXN0IGlzIHdyb25nCj4gYmVjYXVzZSBvZiB0aGlzLgoKSXMg aXQgd29ydGggc3RpbGwgY2hlY2tpbmcgdGhlIEdJQyBvciBqdXN0IHJlcGxhY2luZyBldmVyeXRo aW5nIHdpdGgKY2FsbHMgdG86CgogIHN0YXRpYyBib29sIHRpbWVyX3BlbmRpbmcoc3RydWN0IHRp bWVyX2luZm8gKmluZm8pCiAgewogICAgICAgICAgcmV0dXJuIGluZm8tPnJlYWRfY3RsKCkgJiBB UkNIX1RJTUVSX0NUTF9JU1RBVFVTOwogIH0KCj4KPiBUaGFua3MsCj4gQWxleAo+PiArCWluZm8t PndyaXRlX2N0bCgwKTsKPj4gKwo+PiAgCXJlcG9ydCh0ZXN0X2N2YWxfMTBtc2VjKGluZm8pLCAi bGF0ZW5jeSB3aXRoaW4gMTAgbXMiKTsKPj4gIAlyZXBvcnQoaW5mby0+aXJxX3JlY2VpdmVkLCAi aW50ZXJydXB0IHJlY2VpdmVkIik7Cj4+ICAKCgotLSAKQWxleCBCZW5uw6llCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxpc3QK a3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlhLmVk dS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55898C33CA9 for ; Mon, 13 Jan 2020 17:38:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28674207FF for ; Mon, 13 Jan 2020 17:38:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oK20vFLk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nqIxncL1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28674207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=o0y0FidprMsXHgbzVckyuYO9lGqoBr+rMJpUrnOhQTE=; b=oK20vFLkRU+UeK5X2OO367i+6N dpySNuYTZzXD55axJAAWRXMgwczch3MOo+KTbsAa4SmLxUV/0nDOLdNMzQAWGI8WAIDpToDdcfZXr sDsitrOc0EuahI5jKq7mS67RBd4wBOflZcxQT44UVEx9x3MArtg2e2rxOYNKLpvZJJHL5mrS1jqdo dTZEZuuVh4M4boEtQdmeYrmRku+M5/J/7cSypgh0JcNgtdoj1emtRmZ2RxYLg0nQa9clNHM6MItMN P2JAUTAUipLRxcJoixO+W2Ar6eSGkpawABoK1fI2A0427iOcljB9Gx0pohvwLq6XjJr05l7Rd3dWn waMGBSVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ir3fI-0000no-CR; Mon, 13 Jan 2020 17:38:12 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ir3fE-0000mv-SS for linux-arm-kernel@lists.infradead.org; Mon, 13 Jan 2020 17:38:10 +0000 Received: by mail-wr1-x444.google.com with SMTP id y17so9509063wrh.5 for ; Mon, 13 Jan 2020 09:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=eI/hjqguFIOdMUSo3q0+87ouKq6C8zjThus+1sH1VO0=; b=nqIxncL1yFiSxKpJfW7b03JH6kat4Dudfk5nBxAOSe9fy852eC0rgDnVwIWEsn77zM dE2aPjfeec9grIBn2D6TKVGWvlCbHoPkDREmeg0ugSwGl0uKWjOqlhz9PFubYFsQ8hJq 8AHQ6VOa8ibgvSsql/4I74XQVotBz96ZolcljqE4cr4l+8cvTw7sEml7DFJSNlRp/B9+ eVWnY0PZROjEhdpBdVDxSkNBYF88APTOPXCBepgcHORk1RgjGlFS/BVQMBIB13S3DoM4 qS2qi++eAdhVtdEtzeRHg8B93xPXcGOz8lnvTcAHy50WvUnbCWZgk+TBfG75rYhImHj8 +nrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=eI/hjqguFIOdMUSo3q0+87ouKq6C8zjThus+1sH1VO0=; b=M8JFjH3hOq7XXkOCGk5taDT6E2pGQM10J/LWLtueVqL5Ef0QeTURSlh3eoOTtrRB9y fNs6IXY0iJMK6vhEOcbs5RNIJkiE2pVHEOA4mHe3poq38IrYMkaNGaBUPg6v7yIq1Zb5 lH9EhBKUirAddx3FiZUFJwozmHOsSQhMg+7d0poUHJxN4UhzLD1a0tXwnMFZXHAY++hC oPm23GKpXimDeKOQ2htLrk2iQj6KxnEOgEIZgJGLOSi+F/Rnsj9aaDs0l6nUINVJC0ug lXhkYvgFRh0TPi1A0v3dwCbMMpNrQLgHDn847dDJvfCwX3O1g6x6fUsEVgj8mksighEg H8xw== X-Gm-Message-State: APjAAAUOgNtNyuMtwL9JKmOBIXoJvORrNLEwWUcIjbYPwUYynLIO+kI4 ArkDU1L4PW7uBz3C945nVVriAQ== X-Google-Smtp-Source: APXvYqyNWRIWYrBMrEZC8POMivYqJE726L4BZ9LWUi0lr76+NdJQGfH6a/xGkKlsVQXVJu8cb+LQmw== X-Received: by 2002:a5d:6144:: with SMTP id y4mr20201081wrt.367.1578937085286; Mon, 13 Jan 2020 09:38:05 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id x14sm14824060wmj.42.2020.01.13.09.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2020 09:38:04 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7EF811FF87; Mon, 13 Jan 2020 17:38:03 +0000 (GMT) References: <20200110160511.17821-1-alex.bennee@linaro.org> <8455cdf6-e5c3-bd84-5b85-33ffad581d0e@arm.com> User-agent: mu4e 1.3.6; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Alexandru Elisei Subject: Re: [kvm-unit-tests PATCH] arm: expand the timer tests In-reply-to: <8455cdf6-e5c3-bd84-5b85-33ffad581d0e@arm.com> Date: Mon, 13 Jan 2020 17:38:03 +0000 Message-ID: <871rs3ntok.fsf@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200113_093808_924572_E4DE8205 X-CRM114-Status: GOOD ( 24.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, maz@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CkFsZXhhbmRydSBFbGlzZWkgPGFsZXhhbmRydS5lbGlzZWlAYXJtLmNvbT4gd3JpdGVzOgoKPiBI aSwKPgo+IE9uIDEvMTAvMjAgNDowNSBQTSwgQWxleCBCZW5uw6llIHdyb3RlOgo+PiBUaGlzIHdh cyBhbiBhdHRlbXB0IHRvIHJlcGxpY2F0ZSBhIFFFTVUgYnVnLiBIb3dldmVyIHRvIHRyaWdnZXIg dGhlCj4+IGJ1ZyB5b3UgbmVlZCB0byBoYXZlIGFuIG9mZnNldCBzZXQgaW4gRUwyIHdoaWNoIGt2 bS11bml0LXRlc3RzIGlzCj4+IHVuYWJsZSB0byBkby4gSG93ZXZlciBpdCBkb2VzIGV4ZXJjaXNl IHNvbWUgbW9yZSBjb3JuZXIgY2FzZXMuCj4+Cj4+IEJ1ZzogaHR0cHM6Ly9idWdzLmxhdW5jaHBh ZC5uZXQvYnVncy8xODU5MDIxCj4KPiBJJ20gbm90IGF3YXJlIG9mIGFueSBCdWc6IHRhZ3MgaW4g dGhlIExpbnV4IGtlcm5lbC4gSWYgeW91IHdhbnQgcGVvcGxlIHRvIGZvbGxvdwo+IHRoZSBsaW5r IHRvIHRoZSBidWcsIGhvdyBhYm91dCByZWZlcmVuY2luZyBzb21ldGhpbmcgbGlrZSB0aGlzOgo+ Cj4gIlRoaXMgd2FzIGFuIGF0dGVtcHQgdG8gcmVwbGljYXRlIGEgUUVNVSBidWcgWzFdLiBbLi5d Cj4KPiBbMV0gaHR0cHM6Ly9idWdzLmxhdW5jaHBhZC5uZXQvcWVtdS8rYnVnLzE4NTkwMjEiCgpP SywgSSdsbCBmaXggdGhhdCBpbiB2Mi4KCj4KPiBBbHNvLCBhcmUgbGF1bmNocGFkIGJ1ZyByZXBv cnRzIHBlcm1hbmVudD8gV2lsbCB0aGUgbGluayBzdGlsbCB3b3JrIGluCj4gYSB5ZWFycycgdGlt ZT8KClRoZXkgc2hvdWxkIGJlIC0gdGhleSBhcmUgYSB1bmlxdWUgaWQgYW5kIHdlIHVzZSB0aGVt IGluIHRoZSBRRU1VIHNvdXJjZQp0cmVlLgoKPgo+PiBTaWduZWQtb2ZmLWJ5OiBBbGV4IEJlbm7D qWUgPGFsZXguYmVubmVlQGxpbmFyby5vcmc+Cj4+IC0tLQo+PiAgYXJtL3RpbWVyLmMgfCAyNyAr KysrKysrKysrKysrKysrKysrKysrKysrKy0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9hcm0vdGltZXIuYyBiL2Fy bS90aW1lci5jCj4+IGluZGV4IGYzOTBlOGUuLmFlMWQyOTkgMTAwNjQ0Cj4+IC0tLSBhL2FybS90 aW1lci5jCj4+ICsrKyBiL2FybS90aW1lci5jCj4+IEBAIC0yMTQsMjEgKzIxNCw0NiBAQCBzdGF0 aWMgdm9pZCB0ZXN0X3RpbWVyKHN0cnVjdCB0aW1lcl9pbmZvICppbmZvKQo+PiAgCSAqIHN0aWxs IHJlYWQgdGhlIHBlbmRpbmcgc3RhdGUgZXZlbiBpZiBpdCdzIGRpc2FibGVkLiAqLwo+PiAgCXNl dF90aW1lcl9pcnFfZW5hYmxlZChpbmZvLCBmYWxzZSk7Cj4+ICAKPj4gKwkvKiBWZXJpZnkgY291 bnQgZ29lcyB1cCAqLwo+PiArCXJlcG9ydChpbmZvLT5yZWFkX2NvdW50ZXIoKSA+PSBub3csICJj b3VudGVyIGluY3JlbWVudHMiKTsKPj4gKwo+PiAgCS8qIEVuYWJsZSB0aGUgdGltZXIsIGJ1dCBz Y2hlZHVsZSBpdCBmb3IgbXVjaCBsYXRlciAqLwo+PiAgCWluZm8tPndyaXRlX2N2YWwobGF0ZXIp Owo+PiAgCWluZm8tPndyaXRlX2N0bChBUkNIX1RJTUVSX0NUTF9FTkFCTEUpOwo+PiAgCWlzYigp Owo+PiAtCXJlcG9ydCghZ2ljX3RpbWVyX3BlbmRpbmcoaW5mbyksICJub3QgcGVuZGluZyBiZWZv cmUiKTsKPj4gKwlyZXBvcnQoIWdpY190aW1lcl9wZW5kaW5nKGluZm8pLCAibm90IHBlbmRpbmcg YmVmb3JlIDEwcyIpOwo+PiArCj4+ICsJLyogQ2hlY2sgd2l0aCBhIG1heGltdW0gcG9zc2libGUg Y3ZhbCAqLwo+PiArCWluZm8tPndyaXRlX2N2YWwoVUlOVDY0X01BWCk7Cj4+ICsJaXNiKCk7Cj4+ ICsJcmVwb3J0KCFnaWNfdGltZXJfcGVuZGluZyhpbmZvKSwgIm5vdCBwZW5kaW5nIGJlZm9yZSBV SU5UNjRfTUFYIik7Cj4+ICsKPj4gKwkvKiBhbHNvIGJ5IHNldHRpbmcgdHZhbCAqLwo+Cj4gQWxs IHRoZSBjb21tZW50cyBpbiB0aGlzIGZpbGUgc2VlbSB0byBzdGFydCB3aXRoIGEgY2FwaXRhbCBs ZXR0ZXIuCj4KPj4gKwlpbmZvLT53cml0ZV90dmFsKHRpbWVfMTBzKTsKPj4gKwlpc2IoKTsKPj4g KwlyZXBvcnQoIWdpY190aW1lcl9wZW5kaW5nKGluZm8pLCAibm90IHBlbmRpbmcgYmVmb3JlIDEw cyAodmlhIHR2YWwpIik7Cj4KPiBZb3UgY2FuIHJlbW92ZSB0aGUgIih2aWEgdHZhbCkiIHBhcnQg LSB0aGUgbWVzc2FnZSBpcyB1bmlxdWUgZW5vdWdoIHRvIGZpZ3VyZSBvdXQKPiB3aGljaCBwYXJ0 IG9mIHRoZSB0ZXN0IGl0IHJlZmVycyB0by4KCkkgYWRkZWQgaXQgdG8gZGlmZmVyZW50aWF0ZSB3 aXRoIHRoZSBtZXNzYWdlIGEgbGl0dGxlIGZ1cnRoZXIgYWJvdmUuCgo+PiArCXJlcG9ydF9pbmZv KCJUVkFMIGlzICVkIChkZWx0YSBDVkFMICVsZCkgdGlja3MiLAo+PiArCQkgICAgaW5mby0+cmVh ZF90dmFsKCksIGluZm8tPnJlYWRfY3ZhbCgpIC0gaW5mby0+cmVhZF9jb3VudGVyKCkpOwo+Cj4g SSdtIG5vdCBzdXJlIHdoYXQgeW91IGFyZSB0cnlpbmcgdG8gYWNoaWV2ZSB3aXRoIHRoaXMuIFlv dSBjYW4gdHJhbnNmb3JtIGl0IHRvCj4gY2hlY2sgdGhhdCBUVkFMIGlzIGluZGVlZCBwb3NpdGl2 ZSBhbmQgKGFsbW9zdCkgZXF1YWwgdG8gY3ZhbCAtIGNudHBjdCwgc29tZXRoaW5nCj4gbGlrZSB0 aGlzOgo+Cj4gKwlzMzIgdHZhbCA9IGluZm8tPnJlYWRfdHZhbCgpOwo+ICsJcmVwb3J0KHR2YWwg PiAwICYmIHR2YWwgPD0gaW5mby0+cmVhZF9jdmFsKCkgLQo+IGluZm8tPnJlYWRfY291bnRlcigp LCAiVFZBTCBtZWFzdXJlcyB0aW1lIHRvIG5leHQgaW50ZXJydXB0Iik7CgpZZXMgaXQgd2FzIHB1 cmVseSBpbmZvcm1hdGlvbmFsIHRvIHNheSB0dmFsIGRlY3JlbWVudHMgdG93YXJkcyB0aGUgbmV4 dApJUlEuIEkgY2FuIG1ha2UgaXQgYSBwdXJlIHRlc3QuCgo+Cj4+ICAKPj4gKyAgICAgICAgLyog Y2hlY2sgcGVuZGluZyBvbmNlIGN2YWwgaXMgYmVmb3JlIG5vdyAqLwo+Cj4gVGhpcyBjb21tZW50 IGFkZHMgbm90aGluZyB0byB0aGUgdGVzdC4KCmRyb3BwZWQuCgo+Cj4+ICAJaW5mby0+d3JpdGVf Y3ZhbChub3cgLSAxKTsKPj4gIAlpc2IoKTsKPj4gIAlyZXBvcnQoZ2ljX3RpbWVyX3BlbmRpbmco aW5mbyksICJpbnRlcnJ1cHQgc2lnbmFsIHBlbmRpbmciKTsKPj4gKwlyZXBvcnRfaW5mbygiVFZB TCBpcyAlZCB0aWNrcyIsIGluZm8tPnJlYWRfdHZhbCgpKTsKPgo+IFlvdSBjYW4gdGVzdCB0aGF0 IFRWQUwgaXMgbmVnYXRpdmUgaGVyZSBpbnN0ZWFkIG9mIHByaW50aW5nIHRoZSB2YWx1ZS4KCm9r LgoKPgo+PiAgCj4+ICAJLyogRGlzYWJsZSB0aGUgdGltZXIgYWdhaW4gYW5kIHByZXBhcmUgdG8g dGFrZSBpbnRlcnJ1cHRzICovCj4+ICAJaW5mby0+d3JpdGVfY3RsKDApOwo+PiAgCXNldF90aW1l cl9pcnFfZW5hYmxlZChpbmZvLCB0cnVlKTsKPj4gIAlyZXBvcnQoIWdpY190aW1lcl9wZW5kaW5n KGluZm8pLCAiaW50ZXJydXB0IHNpZ25hbCBubyBsb25nZXIgcGVuZGluZyIpOwo+PiAgCj4+ICsJ LyogUUVNVSBidWcgd2hlbiBjbnR2b2ZmX2VsMiA+IDAKPj4gKwkgKiBodHRwczovL2J1Z3MubGF1 bmNocGFkLm5ldC9idWdzLzE4NTkwMjEgKi8KPgo+IFRoaXMgbG9va3MgY29uZnVzaW5nIHRvIG1l LiBGcm9tIHRoZSBjb21taXQgbWVzc2FnZSwgSSBnb3QgdGhhdCBrdm0tdW5pdC10ZXN0cwo+IG5l ZWRzIHFlbXUgdG8gc2V0IGEgc3BlY2lhbCB2YWx1ZSBmb3IgQ05UVk9GRl9FTDIuIEJ1dCB0aGUg Y29tbWVudHMgc2VlbXMgdG8KPiBzdWdnZXN0IHRoYXQga3ZtLXVuaXQtdGVzdHMgY2FuIHRyaWdn ZXIgdGhlIGJ1ZyB3aXRob3V0IHFlbXUgZG9pbmcgYW55dGhpbmcKPiBzcGVjaWFsLiBDYW4geW91 IGVsYWJvcmF0ZSB1bmRlciB3aGljaCBjb25kaXRpb24ga3ZtLXVuaXQtdGVzdHMgY2FuCj4gdHJp Z2dlciB0aGUgYnVnPwoKSXQgY2FuJ3Qgd2l0aG91dCBzb21lIHNvcnQgb2YgbWVjaGFuaXNtIHRv IHNldCB0aGUgaHlwZXJ2aXNvciByZWdpc3RlcnMKYmVmb3JlIHJ1bm5pbmcgdGhlIHRlc3QuIFRo ZSBRRU1VIGJ1ZyBpcyBhbiBvdmVyZmxvdyB3aGVuIGN2YWwgb2YgVUlOVDY0X01BWAp3aXRoIGEg bm9uLXplcm8gQ05UVk9GRl9FTDIuCgpSdW5uaW5nIHVuZGVyIEtWTSB0aGUgaG9zdCBrZXJuZWwg d2lsbCBoYXZlIGxpa2VseSBzZXQgQ05UVk9GRl9FTDIgdG8Kc29tZSBzb3J0IG9mIHZhbHVlIHdp dGg6CgoJdXBkYXRlX3Z0aW1lcl9jbnR2b2ZmKHZjcHUsIGt2bV9waHlzX3RpbWVyX3JlYWQoKSk7 Cgo+Cj4+ICsJaW5mby0+d3JpdGVfY3RsKEFSQ0hfVElNRVJfQ1RMX0VOQUJMRSk7Cj4+ICsJaW5m by0+d3JpdGVfY3ZhbChVSU5UNjRfTUFYKTsKPgo+IFRoZSBvcmRlciBpcyB3cm9uZyAtIHlvdSB3 cml0ZSBDVkFMIGZpcnN0LCAqdGhlbiogZW5hYmxlIHRvIHRpbWVyLiBPdGhlcndpc2UgeW91Cj4g bWlnaHQgZ2V0IGFuIGludGVycnVwdCBiZWNhdXNlIG9mIHRoZSBwcmV2aW91cyBDVkFMIHZhbHVl Lgo+Cj4gVGhlIHByZXZpb3VzIHZhbHVlIGZvciBDVkFMIHdhcyBub3cgLTEsIHNvIHlvdXIgY2hh bmdlIHRyaWdnZXJzIGFuIHVud2FudGVkCj4gaW50ZXJydXB0IGFmdGVyIGVuYWJsaW5nIHRoZSB0 aW1lci4gVGhlIGludGVycnVwdCBoYW5kbGVyIG1hc2tzIHRoZSB0aW1lcgo+IGludGVycnVwdCBh dCB0aGUgdGltZXIgbGV2ZWwsIHdoaWNoIG1lYW5zIHRoYXQgYXMgZmFyIGFzIHRoZSBnaWMgaXMg Y29uY2VybmVkIHRoZQo+IGludGVycnVwdCBpcyBub3QgcGVuZGluZywgbWFraW5nIHRoZSByZXBv cnQgY2FsbCBhZnRlcndhcmRzIHVzZWxlc3MuCj4KPj4gKwlpc2IoKTsKPj4gKwlyZXBvcnQoIWdp Y190aW1lcl9wZW5kaW5nKGluZm8pLCAibm90IHBlbmRpbmcgYmVmb3JlIFVJTlQ2NF9NQVggKGly cXMgb24pIik7Cj4KPiBUaGlzIGNoZWNrIGNhbiBiZSBpbXByb3ZlZC4gWW91IHdhbnQgdG8gY2hl Y2sgdGhlIHRpbWVyIENUTC5JU1RBVFVTIGhlcmUsIG5vdCB0aGUKPiBnaWMuIEEgZGV2aWNlIChp biB0aGlzIGNhc2UsIHRoZSB0aW1lcikgY2FuIGFzc2VydCB0aGUgaW50ZXJydXB0LCBidXQgdGhl IGdpYyBkb2VzCj4gbm90IHNhbXBsZSBpdCBpbW1lZGlhdGVseS4gQ29tZSB0byB0aGluayBvZiBp dCwgdGhlIGVudGlyZSB0aW1lciB0ZXN0IGlzIHdyb25nCj4gYmVjYXVzZSBvZiB0aGlzLgoKSXMg aXQgd29ydGggc3RpbGwgY2hlY2tpbmcgdGhlIEdJQyBvciBqdXN0IHJlcGxhY2luZyBldmVyeXRo aW5nIHdpdGgKY2FsbHMgdG86CgogIHN0YXRpYyBib29sIHRpbWVyX3BlbmRpbmcoc3RydWN0IHRp bWVyX2luZm8gKmluZm8pCiAgewogICAgICAgICAgcmV0dXJuIGluZm8tPnJlYWRfY3RsKCkgJiBB UkNIX1RJTUVSX0NUTF9JU1RBVFVTOwogIH0KCj4KPiBUaGFua3MsCj4gQWxleAo+PiArCWluZm8t PndyaXRlX2N0bCgwKTsKPj4gKwo+PiAgCXJlcG9ydCh0ZXN0X2N2YWxfMTBtc2VjKGluZm8pLCAi bGF0ZW5jeSB3aXRoaW4gMTAgbXMiKTsKPj4gIAlyZXBvcnQoaW5mby0+aXJxX3JlY2VpdmVkLCAi aW50ZXJydXB0IHJlY2VpdmVkIik7Cj4+ICAKCgotLSAKQWxleCBCZW5uw6llCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B83C33CAF for ; Mon, 13 Jan 2020 17:38:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5F90214AF for ; Mon, 13 Jan 2020 17:38:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nqIxncL1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728757AbgAMRiI (ORCPT ); Mon, 13 Jan 2020 12:38:08 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:43794 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728665AbgAMRiI (ORCPT ); Mon, 13 Jan 2020 12:38:08 -0500 Received: by mail-wr1-f66.google.com with SMTP id d16so9485491wre.10 for ; Mon, 13 Jan 2020 09:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=eI/hjqguFIOdMUSo3q0+87ouKq6C8zjThus+1sH1VO0=; b=nqIxncL1yFiSxKpJfW7b03JH6kat4Dudfk5nBxAOSe9fy852eC0rgDnVwIWEsn77zM dE2aPjfeec9grIBn2D6TKVGWvlCbHoPkDREmeg0ugSwGl0uKWjOqlhz9PFubYFsQ8hJq 8AHQ6VOa8ibgvSsql/4I74XQVotBz96ZolcljqE4cr4l+8cvTw7sEml7DFJSNlRp/B9+ eVWnY0PZROjEhdpBdVDxSkNBYF88APTOPXCBepgcHORk1RgjGlFS/BVQMBIB13S3DoM4 qS2qi++eAdhVtdEtzeRHg8B93xPXcGOz8lnvTcAHy50WvUnbCWZgk+TBfG75rYhImHj8 +nrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=eI/hjqguFIOdMUSo3q0+87ouKq6C8zjThus+1sH1VO0=; b=EYxmOeRZBzZl0krez0nKY2pyo+VwWC9s7y9AN7ZjNvxJsDyCv20WKD2uaIevt3AJjh Zsk8LQEdCN0wFhaKRiV6f/7C7Z2M1T3xx49CG4wrX7/g9XJXlC2XDampD/YQhyoxYjUL md7Z+aUCUwZAJTkAaig8dIK+iGDvKZa9VR9+b+tT/rZY2U817iBEoIKRgoPD2pjUQ9JB dTthudEgZFDgM77GocCvV4jFjW+OLiGszwGC6kFnrBOMh99Wmh2P4aki6yLwjpPejspH nC5I2JOuxbn8zdNwCgrXMKi2u1K28JGUAEB1n4ejPvBe1n/9JZ5U23zHmnPFfs7amnOC 9rdg== X-Gm-Message-State: APjAAAXBgw35PB5qeQPgUQTHeQK3Ye2514rMLKFLmmrpJr+IkUEOTy0j J4OlNJvNivQ4oHrt5IgRrdLxS33RF+g= X-Google-Smtp-Source: APXvYqyNWRIWYrBMrEZC8POMivYqJE726L4BZ9LWUi0lr76+NdJQGfH6a/xGkKlsVQXVJu8cb+LQmw== X-Received: by 2002:a5d:6144:: with SMTP id y4mr20201081wrt.367.1578937085286; Mon, 13 Jan 2020 09:38:05 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id x14sm14824060wmj.42.2020.01.13.09.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2020 09:38:04 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7EF811FF87; Mon, 13 Jan 2020 17:38:03 +0000 (GMT) References: <20200110160511.17821-1-alex.bennee@linaro.org> <8455cdf6-e5c3-bd84-5b85-33ffad581d0e@arm.com> User-agent: mu4e 1.3.6; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Alexandru Elisei Cc: kvm@vger.kernel.org, maz@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [kvm-unit-tests PATCH] arm: expand the timer tests In-reply-to: <8455cdf6-e5c3-bd84-5b85-33ffad581d0e@arm.com> Date: Mon, 13 Jan 2020 17:38:03 +0000 Message-ID: <871rs3ntok.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Alexandru Elisei writes: > Hi, > > On 1/10/20 4:05 PM, Alex Benn=C3=A9e wrote: >> This was an attempt to replicate a QEMU bug. However to trigger the >> bug you need to have an offset set in EL2 which kvm-unit-tests is >> unable to do. However it does exercise some more corner cases. >> >> Bug: https://bugs.launchpad.net/bugs/1859021 > > I'm not aware of any Bug: tags in the Linux kernel. If you want people to= follow > the link to the bug, how about referencing something like this: > > "This was an attempt to replicate a QEMU bug [1]. [..] > > [1] https://bugs.launchpad.net/qemu/+bug/1859021" OK, I'll fix that in v2. > > Also, are launchpad bug reports permanent? Will the link still work in > a years' time? They should be - they are a unique id and we use them in the QEMU source tree. > >> Signed-off-by: Alex Benn=C3=A9e >> --- >> arm/timer.c | 27 ++++++++++++++++++++++++++- >> 1 file changed, 26 insertions(+), 1 deletion(-) >> >> diff --git a/arm/timer.c b/arm/timer.c >> index f390e8e..ae1d299 100644 >> --- a/arm/timer.c >> +++ b/arm/timer.c >> @@ -214,21 +214,46 @@ static void test_timer(struct timer_info *info) >> * still read the pending state even if it's disabled. */ >> set_timer_irq_enabled(info, false); >>=20=20 >> + /* Verify count goes up */ >> + report(info->read_counter() >=3D now, "counter increments"); >> + >> /* Enable the timer, but schedule it for much later */ >> info->write_cval(later); >> info->write_ctl(ARCH_TIMER_CTL_ENABLE); >> isb(); >> - report(!gic_timer_pending(info), "not pending before"); >> + report(!gic_timer_pending(info), "not pending before 10s"); >> + >> + /* Check with a maximum possible cval */ >> + info->write_cval(UINT64_MAX); >> + isb(); >> + report(!gic_timer_pending(info), "not pending before UINT64_MAX"); >> + >> + /* also by setting tval */ > > All the comments in this file seem to start with a capital letter. > >> + info->write_tval(time_10s); >> + isb(); >> + report(!gic_timer_pending(info), "not pending before 10s (via tval)"); > > You can remove the "(via tval)" part - the message is unique enough to fi= gure out > which part of the test it refers to. I added it to differentiate with the message a little further above. >> + report_info("TVAL is %d (delta CVAL %ld) ticks", >> + info->read_tval(), info->read_cval() - info->read_counter()); > > I'm not sure what you are trying to achieve with this. You can transform = it to > check that TVAL is indeed positive and (almost) equal to cval - cntpct, s= omething > like this: > > + s32 tval =3D info->read_tval(); > + report(tval > 0 && tval <=3D info->read_cval() - > info->read_counter(), "TVAL measures time to next interrupt"); Yes it was purely informational to say tval decrements towards the next IRQ. I can make it a pure test. > >>=20=20 >> + /* check pending once cval is before now */ > > This comment adds nothing to the test. dropped. > >> info->write_cval(now - 1); >> isb(); >> report(gic_timer_pending(info), "interrupt signal pending"); >> + report_info("TVAL is %d ticks", info->read_tval()); > > You can test that TVAL is negative here instead of printing the value. ok. > >>=20=20 >> /* Disable the timer again and prepare to take interrupts */ >> info->write_ctl(0); >> set_timer_irq_enabled(info, true); >> report(!gic_timer_pending(info), "interrupt signal no longer pending"); >>=20=20 >> + /* QEMU bug when cntvoff_el2 > 0 >> + * https://bugs.launchpad.net/bugs/1859021 */ > > This looks confusing to me. From the commit message, I got that kvm-unit-= tests > needs qemu to set a special value for CNTVOFF_EL2. But the comments seems= to > suggest that kvm-unit-tests can trigger the bug without qemu doing anythi= ng > special. Can you elaborate under which condition kvm-unit-tests can > trigger the bug? It can't without some sort of mechanism to set the hypervisor registers before running the test. The QEMU bug is an overflow when cval of UINT64_MAX with a non-zero CNTVOFF_EL2. Running under KVM the host kernel will have likely set CNTVOFF_EL2 to some sort of value with: update_vtimer_cntvoff(vcpu, kvm_phys_timer_read()); > >> + info->write_ctl(ARCH_TIMER_CTL_ENABLE); >> + info->write_cval(UINT64_MAX); > > The order is wrong - you write CVAL first, *then* enable to timer. Otherw= ise you > might get an interrupt because of the previous CVAL value. > > The previous value for CVAL was now -1, so your change triggers an unwant= ed > interrupt after enabling the timer. The interrupt handler masks the timer > interrupt at the timer level, which means that as far as the gic is conce= rned the > interrupt is not pending, making the report call afterwards useless. > >> + isb(); >> + report(!gic_timer_pending(info), "not pending before UINT64_MAX (irqs = on)"); > > This check can be improved. You want to check the timer CTL.ISTATUS here,= not the > gic. A device (in this case, the timer) can assert the interrupt, but the= gic does > not sample it immediately. Come to think of it, the entire timer test is = wrong > because of this. Is it worth still checking the GIC or just replacing everything with calls to: static bool timer_pending(struct timer_info *info) { return info->read_ctl() & ARCH_TIMER_CTL_ISTATUS; } > > Thanks, > Alex >> + info->write_ctl(0); >> + >> report(test_cval_10msec(info), "latency within 10 ms"); >> report(info->irq_received, "interrupt received"); >>=20=20 --=20 Alex Benn=C3=A9e