From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD0DC43603 for ; Thu, 12 Dec 2019 10:30:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EBEA206DA for ; Thu, 12 Dec 2019 10:30:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="beZaezn9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728668AbfLLKaB (ORCPT ); Thu, 12 Dec 2019 05:30:01 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:33541 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728561AbfLLKaB (ORCPT ); Thu, 12 Dec 2019 05:30:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576146600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2M6G8iAhRV7/cjIOqjMt+xr5yQGXJg0bdL2B5+adEQY=; b=beZaezn9kqCo0Tb1hzxPoQJCQeFjAS8MuQYyce10KKYC54zmRiK8KZ2ETRJKAk3vdnRyuf kjiQo8evi0xcKbVm/RMu4dJtm4DxGDYKWvqJmgwrBvzFUOTWrzaBM/iw6ko/SbDfrrptbR 6EMR4E48udeBrSRlf3OE4+gV/4aGWfg= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-82-B4DjG6-1Nw2KAJRDvvDR3g-1; Thu, 12 Dec 2019 05:29:59 -0500 X-MC-Unique: B4DjG6-1Nw2KAJRDvvDR3g-1 Received: by mail-lj1-f200.google.com with SMTP id s8so354315ljo.10 for ; Thu, 12 Dec 2019 02:29:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=2M6G8iAhRV7/cjIOqjMt+xr5yQGXJg0bdL2B5+adEQY=; b=NcfxZ1IgCekqo6C6rj652OAgGEs5t3Ot/BJemI8x1dNZt+Dhd41srdWcd9A2BT9d8l NrLx6R64V1vd1GkGV1gDsILllwnWoo15NwfzR4OFr0oaUGHdlYKqgO0fLhx4bfy2qKam JAhgWgLXuzoZAX4Wx61g8DelXnGkRBFmk2Tazrw0VXPf86gzDoWTA900BRB5zn/rkcgg UZxf3eZKOB2fMGPea58zSwOaYXAZFXYH06XtdZKXDs2Hlis0ucI7AmqehNQMAQZbYwxD 47SwhaAoxFWUAEvJRx5hAhqBfDzzFrEV8Wnaw//eGz8W3q4rN8mw4JTE9YPY2lHSRnnE GO4Q== X-Gm-Message-State: APjAAAXwZS3J5X2SYWf6Obwrf9X+SY9FDesS6VuMoXEJhZucbGPKaQIn hL+8aGUuMTfI1cN74ZtpKvgrzDH8JMYtikiEQgOyMpALtzZoM8HtR0eqCitLJA98HAea3rl7Bd0 KPyqwejvFqNFyQIpG5ROfqpXaFEQ= X-Received: by 2002:ac2:46dc:: with SMTP id p28mr5228240lfo.23.1576146597557; Thu, 12 Dec 2019 02:29:57 -0800 (PST) X-Google-Smtp-Source: APXvYqzqry9NQX+5JoJ1CMjEXLOjljhoSaIBxWUieZunQNd9ApcILr8cfNOm923DLupXjagv4JavaQ== X-Received: by 2002:ac2:46dc:: with SMTP id p28mr5228234lfo.23.1576146597386; Thu, 12 Dec 2019 02:29:57 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id c27sm2657557lfh.62.2019.12.12.02.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2019 02:29:56 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id BAD811819EA; Thu, 12 Dec 2019 11:29:55 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Justin Capella , Johannes Berg Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] mac80211: Turn AQL into an NL80211_EXT_FEATURE In-Reply-To: References: <20191211145230.200132-1-toke@redhat.com> <20191211145230.200132-2-toke@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 12 Dec 2019 11:29:55 +0100 Message-ID: <871rt9g7ks.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Justin Capella writes: > Disclaimer: I'm new, so don't assume my questions are rhetorical... > > sta = container_of(txq->sta, struct sta_info, sta); // Is this > correct? Not sure what you're referring to here; but generally, yes? :) > I see the use of IEEE80211_NUM_ACS seems to be standard, is that AC > specific? I learned today that different devs have different numbers > of queues... AC numbers are defined in the standard, and there are always four of them. Different hardware can have different numbers of queues, which may or may not be related to NUM_ACS. > What are the units of the THRESHOLD, iirc there was some bit > shifting/masking? Units are logically microseconds, but stored as increments of 4 microseconds because we ran out of bits; this is kept inside the setter/getter function, though, so everywhere else is just microseconds. > Is there supposed to be a queue per station, or just per interface? There's a TXQ per TID (so 16 per station), and an additional one on the interface for multicast. > It seemed like the threshold was meant to pick a higher or lower > queue, this seems to maybe just reject if not within the bounds? There are two thresholds; one for the whole interface, and one per station. If either is exceeded transmission will be throttled. -Toke