From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/rect: remove useless call to clamp_t Date: Wed, 20 Nov 2019 16:18:35 +0200 Message-ID: <871ru2y6kk.fsf@intel.com> References: <20191119133435.22525-1-benjamin.gaignard@st.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20191119133435.22525-1-benjamin.gaignard@st.com> Sender: linux-kernel-owner@vger.kernel.org To: maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Benjamin Gaignard List-Id: dri-devel@lists.freedesktop.org On Tue, 19 Nov 2019, Benjamin Gaignard wrote: > Clamping a value between INT_MIN and INT_MAX always return the value itself > and generate warnings when compiling with W=1. Does that hold for 32-bit too? BR, Jani. > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_rect.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_rect.c b/drivers/gpu/drm/drm_rect.c > index b8363aaa9032..681f1fd09357 100644 > --- a/drivers/gpu/drm/drm_rect.c > +++ b/drivers/gpu/drm/drm_rect.c > @@ -89,7 +89,7 @@ bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst, > u32 new_src_w = clip_scaled(drm_rect_width(src), > drm_rect_width(dst), diff); > > - src->x1 = clamp_t(int64_t, src->x2 - new_src_w, INT_MIN, INT_MAX); > + src->x1 = src->x2 - new_src_w; > dst->x1 = clip->x1; > } > diff = clip->y1 - dst->y1; > @@ -97,7 +97,7 @@ bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst, > u32 new_src_h = clip_scaled(drm_rect_height(src), > drm_rect_height(dst), diff); > > - src->y1 = clamp_t(int64_t, src->y2 - new_src_h, INT_MIN, INT_MAX); > + src->y1 = src->y2 - new_src_h; > dst->y1 = clip->y1; > } > diff = dst->x2 - clip->x2; > @@ -105,7 +105,7 @@ bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst, > u32 new_src_w = clip_scaled(drm_rect_width(src), > drm_rect_width(dst), diff); > > - src->x2 = clamp_t(int64_t, src->x1 + new_src_w, INT_MIN, INT_MAX); > + src->x2 = src->x1 + new_src_w; > dst->x2 = clip->x2; > } > diff = dst->y2 - clip->y2; > @@ -113,7 +113,7 @@ bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst, > u32 new_src_h = clip_scaled(drm_rect_height(src), > drm_rect_height(dst), diff); > > - src->y2 = clamp_t(int64_t, src->y1 + new_src_h, INT_MIN, INT_MAX); > + src->y2 = src->y1 + new_src_h; > dst->y2 = clip->y2; > } -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DF9C43215 for ; Wed, 20 Nov 2019 14:18:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B65CC20637 for ; Wed, 20 Nov 2019 14:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B65CC20637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F3166E5F6; Wed, 20 Nov 2019 14:18:44 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95D356E5EE for ; Wed, 20 Nov 2019 14:18:42 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:18:42 -0800 X-IronPort-AV: E=Sophos;i="5.69,222,1571727600"; d="scan'208";a="196867261" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:18:38 -0800 From: Jani Nikula To: Benjamin Gaignard , maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Subject: Re: [PATCH] drm/rect: remove useless call to clamp_t In-Reply-To: <20191119133435.22525-1-benjamin.gaignard@st.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191119133435.22525-1-benjamin.gaignard@st.com> Date: Wed, 20 Nov 2019 16:18:35 +0200 Message-ID: <871ru2y6kk.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Benjamin Gaignard Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191120141835.gGrzzbiojZyW87ICK7HRpBcGm2ck2RdErli-B8tl5kw@z> T24gVHVlLCAxOSBOb3YgMjAxOSwgQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJk QHN0LmNvbT4gd3JvdGU6Cj4gQ2xhbXBpbmcgYSB2YWx1ZSBiZXR3ZWVuIElOVF9NSU4gYW5kIElO VF9NQVggYWx3YXlzIHJldHVybiB0aGUgdmFsdWUgaXRzZWxmCj4gYW5kIGdlbmVyYXRlIHdhcm5p bmdzIHdoZW4gY29tcGlsaW5nIHdpdGggVz0xLgoKRG9lcyB0aGF0IGhvbGQgZm9yIDMyLWJpdCB0 b28/CgpCUiwKSmFuaS4KCj4KPiBTaWduZWQtb2ZmLWJ5OiBCZW5qYW1pbiBHYWlnbmFyZCA8YmVu amFtaW4uZ2FpZ25hcmRAc3QuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3JlY3Qu YyB8IDggKysrKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3JlY3QuYyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fcmVjdC5jCj4gaW5kZXggYjgzNjNhYWE5MDMyLi42ODFmMWZkMDkz NTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9yZWN0LmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX3JlY3QuYwo+IEBAIC04OSw3ICs4OSw3IEBAIGJvb2wgZHJtX3JlY3Rf Y2xpcF9zY2FsZWQoc3RydWN0IGRybV9yZWN0ICpzcmMsIHN0cnVjdCBkcm1fcmVjdCAqZHN0LAo+ ICAJCXUzMiBuZXdfc3JjX3cgPSBjbGlwX3NjYWxlZChkcm1fcmVjdF93aWR0aChzcmMpLAo+ICAJ CQkJCSAgICBkcm1fcmVjdF93aWR0aChkc3QpLCBkaWZmKTsKPiAgCj4gLQkJc3JjLT54MSA9IGNs YW1wX3QoaW50NjRfdCwgc3JjLT54MiAtIG5ld19zcmNfdywgSU5UX01JTiwgSU5UX01BWCk7Cj4g KwkJc3JjLT54MSA9IHNyYy0+eDIgLSBuZXdfc3JjX3c7Cj4gIAkJZHN0LT54MSA9IGNsaXAtPngx Owo+ICAJfQo+ICAJZGlmZiA9IGNsaXAtPnkxIC0gZHN0LT55MTsKPiBAQCAtOTcsNyArOTcsNyBA QCBib29sIGRybV9yZWN0X2NsaXBfc2NhbGVkKHN0cnVjdCBkcm1fcmVjdCAqc3JjLCBzdHJ1Y3Qg ZHJtX3JlY3QgKmRzdCwKPiAgCQl1MzIgbmV3X3NyY19oID0gY2xpcF9zY2FsZWQoZHJtX3JlY3Rf aGVpZ2h0KHNyYyksCj4gIAkJCQkJICAgIGRybV9yZWN0X2hlaWdodChkc3QpLCBkaWZmKTsKPiAg Cj4gLQkJc3JjLT55MSA9IGNsYW1wX3QoaW50NjRfdCwgc3JjLT55MiAtIG5ld19zcmNfaCwgSU5U X01JTiwgSU5UX01BWCk7Cj4gKwkJc3JjLT55MSA9IHNyYy0+eTIgLSBuZXdfc3JjX2g7Cj4gIAkJ ZHN0LT55MSA9IGNsaXAtPnkxOwo+ICAJfQo+ICAJZGlmZiA9IGRzdC0+eDIgLSBjbGlwLT54MjsK PiBAQCAtMTA1LDcgKzEwNSw3IEBAIGJvb2wgZHJtX3JlY3RfY2xpcF9zY2FsZWQoc3RydWN0IGRy bV9yZWN0ICpzcmMsIHN0cnVjdCBkcm1fcmVjdCAqZHN0LAo+ICAJCXUzMiBuZXdfc3JjX3cgPSBj bGlwX3NjYWxlZChkcm1fcmVjdF93aWR0aChzcmMpLAo+ICAJCQkJCSAgICBkcm1fcmVjdF93aWR0 aChkc3QpLCBkaWZmKTsKPiAgCj4gLQkJc3JjLT54MiA9IGNsYW1wX3QoaW50NjRfdCwgc3JjLT54 MSArIG5ld19zcmNfdywgSU5UX01JTiwgSU5UX01BWCk7Cj4gKwkJc3JjLT54MiA9IHNyYy0+eDEg KyBuZXdfc3JjX3c7Cj4gIAkJZHN0LT54MiA9IGNsaXAtPngyOwo+ICAJfQo+ICAJZGlmZiA9IGRz dC0+eTIgLSBjbGlwLT55MjsKPiBAQCAtMTEzLDcgKzExMyw3IEBAIGJvb2wgZHJtX3JlY3RfY2xp cF9zY2FsZWQoc3RydWN0IGRybV9yZWN0ICpzcmMsIHN0cnVjdCBkcm1fcmVjdCAqZHN0LAo+ICAJ CXUzMiBuZXdfc3JjX2ggPSBjbGlwX3NjYWxlZChkcm1fcmVjdF9oZWlnaHQoc3JjKSwKPiAgCQkJ CQkgICAgZHJtX3JlY3RfaGVpZ2h0KGRzdCksIGRpZmYpOwo+ICAKPiAtCQlzcmMtPnkyID0gY2xh bXBfdChpbnQ2NF90LCBzcmMtPnkxICsgbmV3X3NyY19oLCBJTlRfTUlOLCBJTlRfTUFYKTsKPiAr CQlzcmMtPnkyID0gc3JjLT55MSArIG5ld19zcmNfaDsKPiAgCQlkc3QtPnkyID0gY2xpcC0+eTI7 Cj4gIAl9CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B30AC432C0 for ; Wed, 20 Nov 2019 14:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD11B224B2 for ; Wed, 20 Nov 2019 14:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730848AbfKTOSm (ORCPT ); Wed, 20 Nov 2019 09:18:42 -0500 Received: from mga04.intel.com ([192.55.52.120]:21117 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729000AbfKTOSm (ORCPT ); Wed, 20 Nov 2019 09:18:42 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:18:42 -0800 X-IronPort-AV: E=Sophos;i="5.69,222,1571727600"; d="scan'208";a="196867261" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 06:18:38 -0800 From: Jani Nikula To: Benjamin Gaignard , maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Benjamin Gaignard Subject: Re: [PATCH] drm/rect: remove useless call to clamp_t In-Reply-To: <20191119133435.22525-1-benjamin.gaignard@st.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191119133435.22525-1-benjamin.gaignard@st.com> Date: Wed, 20 Nov 2019 16:18:35 +0200 Message-ID: <871ru2y6kk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Nov 2019, Benjamin Gaignard wrote: > Clamping a value between INT_MIN and INT_MAX always return the value itself > and generate warnings when compiling with W=1. Does that hold for 32-bit too? BR, Jani. > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_rect.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_rect.c b/drivers/gpu/drm/drm_rect.c > index b8363aaa9032..681f1fd09357 100644 > --- a/drivers/gpu/drm/drm_rect.c > +++ b/drivers/gpu/drm/drm_rect.c > @@ -89,7 +89,7 @@ bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst, > u32 new_src_w = clip_scaled(drm_rect_width(src), > drm_rect_width(dst), diff); > > - src->x1 = clamp_t(int64_t, src->x2 - new_src_w, INT_MIN, INT_MAX); > + src->x1 = src->x2 - new_src_w; > dst->x1 = clip->x1; > } > diff = clip->y1 - dst->y1; > @@ -97,7 +97,7 @@ bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst, > u32 new_src_h = clip_scaled(drm_rect_height(src), > drm_rect_height(dst), diff); > > - src->y1 = clamp_t(int64_t, src->y2 - new_src_h, INT_MIN, INT_MAX); > + src->y1 = src->y2 - new_src_h; > dst->y1 = clip->y1; > } > diff = dst->x2 - clip->x2; > @@ -105,7 +105,7 @@ bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst, > u32 new_src_w = clip_scaled(drm_rect_width(src), > drm_rect_width(dst), diff); > > - src->x2 = clamp_t(int64_t, src->x1 + new_src_w, INT_MIN, INT_MAX); > + src->x2 = src->x1 + new_src_w; > dst->x2 = clip->x2; > } > diff = dst->y2 - clip->y2; > @@ -113,7 +113,7 @@ bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst, > u32 new_src_h = clip_scaled(drm_rect_height(src), > drm_rect_height(dst), diff); > > - src->y2 = clamp_t(int64_t, src->y1 + new_src_h, INT_MIN, INT_MAX); > + src->y2 = src->y1 + new_src_h; > dst->y2 = clip->y2; > } -- Jani Nikula, Intel Open Source Graphics Center