From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v3] drm/v3d: clean caches at the end of render jobs on request from user space Date: Thu, 19 Sep 2019 12:58:16 -0700 Message-ID: <871rwc9hyf.fsf@anholt.net> References: <20190919071016.4578-1-itoral@igalia.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2040500757==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id BFE5C6FAF8 for ; Thu, 19 Sep 2019 19:58:19 +0000 (UTC) In-Reply-To: <20190919071016.4578-1-itoral@igalia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Iago Toral Quiroga List-Id: dri-devel@lists.freedesktop.org --===============2040500757== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Iago Toral Quiroga writes: > Extends the user space ioctl for CL submissions so it can include a request > to flush the cache once the CL execution has completed. Fixes memory > write violation messages reported by the kernel in workloads involving > shader memory writes (SSBOs, shader images, scratch, etc) which sometimes > also lead to GPU resets during Piglit and CTS workloads. > > v2: if v3d_job_init() fails we need to kfree() the job instead of > v3d_job_put() it (Eric Anholt). > > v3 (Eric Anholt): > - Drop _FLAG suffix from the new flag name. > - Add a new param so userspace can tell whether cache flushing is > implemented in the kernel. Appled to drm-misc-next. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAl2D3dgACgkQtdYpNtH8 nugvrg//dqHlxcnk5AR9LNtOQpDYp4XFgrp3/A3M/iY5laGdZy0RSgf8Y4omjjkO hBgUu5uiya8JOqiwfTZbFXTsYDc9M3KdyjM6DC3YodhftmNRx7oP1cTP9Bg/2b8J oPajDczWyt1d+JtvzepYMR2A36zhAFIJRj9rwYtVVw//XUvx8nHU+ijvF10FfD7+ sJDD7ZCYl0dauVOnY+CflBjEgSmED94qE9qNUVXQp3rU0Q18MIzjrznEOVYQLuSr 97xbrKrRjqLkUJT7Xf8fNriX6RaRBk7fN2eW1Gc9lrazaXS18+whTF2xZa2fcETt pCC/dIxTpmpa1bzJTKejMLOH6ESvMp7tuPjiGLYu2czUhM8kdPmXHZjH4+zh0yrW iJDit4Ar12FO6Xsh+SNJ0utGKjjoKUu456HIXmx/mwgdSUUugJcHKeiBmkgDS663 /vZCZn5zjFWCYkdT2NB7H3/eFUDbH3TcpGtQQHYZC2154SyOTLolt64gVUr3a0Sm j28zMUoEv9ZEufeMYmU7pFOmDSinlUy7ibStwgHkP+xDyQuASLspvoKc9OlM91cA Kpp3y5dFZyAymN6qF2/yI+hvBX0Kg/GEYsmoZnrhlxJaEBSyIdJgAbnFuGPmeaQF CozEqx+hUUuwKFDKRR5ua9t6ApEaY05D7W9A1EYuhEdO2E65wwA= =Y4oR -----END PGP SIGNATURE----- --=-=-=-- --===============2040500757== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============2040500757==--