From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Aleksandar Rikalo <arikalo@wavecomp.com>,
Aurelien Jarno <aurelien@aurel32.net>,
qemu-devel@nongnu.org,
Aleksandar Markovic <amarkovic@wavecomp.com>,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 5/7] target/mips: rationalise softfloat includes
Date: Fri, 09 Aug 2019 09:33:39 +0100 [thread overview]
Message-ID: <871rxuivq4.fsf@linaro.org> (raw)
In-Reply-To: <0dd4b130-dfe2-6a0b-fdd1-e265e9004ec9@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 8/8/19 9:41 AM, Alex Bennée wrote:
>> index 21c0615e020..f146924623c 100644
>> --- a/target/mips/cpu.h
>> +++ b/target/mips/cpu.h
>> @@ -5,7 +5,8 @@
>>
>> #include "cpu-qom.h"
>> #include "exec/cpu-defs.h"
>> -#include "fpu/softfloat.h"
>> +#include "fpu/softfloat-types.h"
>> +#include "fpu/softfloat-helpers.h"
>
> Do you really need softfloat-helpers.h here?
> It appears as if this is only needed by target/mips/internal.h
I've moved the helper to internal.h which somehow gets auto-magically
included for cpu_loop.c for linux-user.
>
>
> r~
--
Alex Bennée
next prev parent reply other threads:[~2019-08-09 8:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 16:41 [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups Alex Bennée
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-types Alex Bennée
2019-08-08 17:28 ` Richard Henderson
2019-08-09 10:08 ` Peter Maydell
2019-08-10 10:03 ` Alex Bennée
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 2/7] fpu: move inline helpers into a separate header Alex Bennée
2019-08-08 17:31 ` Richard Henderson
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 3/7] fpu: make softfloat-macros "self-contained" Alex Bennée
2019-08-08 17:49 ` Richard Henderson
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 4/7] fpu: rename softfloat-specialize.h -> .inc.c Alex Bennée
2019-08-08 17:50 ` Richard Henderson
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 5/7] target/mips: rationalise softfloat includes Alex Bennée
2019-08-08 17:55 ` Richard Henderson
2019-08-09 8:33 ` Alex Bennée [this message]
2019-08-08 16:41 ` [Qemu-riscv] [PATCH v1 6/7] target/riscv: " Alex Bennée
2019-08-08 16:41 ` [Qemu-devel] " Alex Bennée
2019-08-08 17:57 ` [Qemu-riscv] " Richard Henderson
2019-08-08 17:57 ` Richard Henderson
2019-08-10 1:55 ` [Qemu-riscv] " Alistair Francis
2019-08-10 1:55 ` Alistair Francis
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 7/7] targets (various): use softfloat-helpers.h where we can Alex Bennée
2019-08-08 17:58 ` Richard Henderson
2019-08-09 8:58 ` David Hildenbrand
2019-08-08 16:58 ` [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups no-reply
2019-08-08 17:41 ` no-reply
2019-08-08 18:02 ` no-reply
2019-08-08 18:49 ` no-reply
2019-08-09 6:31 ` Markus Armbruster
2019-08-09 8:20 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rxuivq4.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.