From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 1463D7D910 for ; Thu, 6 Jun 2019 08:20:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726092AbfFFIUm (ORCPT ); Thu, 6 Jun 2019 04:20:42 -0400 Received: from mga04.intel.com ([192.55.52.120]:7384 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfFFIUm (ORCPT ); Thu, 6 Jun 2019 04:20:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2019 01:20:40 -0700 X-ExtLoop1: 1 Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.150]) by fmsmga001.fm.intel.com with ESMTP; 06 Jun 2019 01:20:38 -0700 From: Jani Nikula To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Cc: linux-doc@vger.kernel.org, Chris Wilson Subject: Re: [PATCH 1/2] Documentation/i915: Fix kernel-doc references to moved gem files In-Reply-To: <87d0jss4uo.fsf@gaia.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20190605095657.23601-1-jani.nikula@intel.com> <87d0jss4uo.fsf@gaia.fi.intel.com> Date: Thu, 06 Jun 2019 11:23:44 +0300 Message-ID: <871s072kbz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, 05 Jun 2019, Mika Kuoppala wrote: > Jani Nikula writes: > >> The error messages could be more descriptive, but fix these caused by >> file moves: >> >> WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -internal >> ./drivers/gpu/drm/i915/i915_gem_shrinker.c' failed with return code 2 >> WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function >> User command execution ./drivers/gpu/drm/i915/i915_gem_execbuffer.c' >> failed with return code 1 >> WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -internal >> ./drivers/gpu/drm/i915/i915_gem_tiling.c' failed with return code 2 >> WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function >> buffer object tiling ./drivers/gpu/drm/i915/i915_gem_tiling.c' >> failed with return code 1 >> >> Fixes: 10be98a77c55 ("drm/i915: Move more GEM objects under gem/") >> Cc: Chris Wilson >> Cc: Mika Kuoppala >> Signed-off-by: Jani Nikula > > /o\ > > Reviewed-by: Mika Kuoppala Thanks for the reviews, I took the liberty of pushing these to dinq with just BAT results, as these are purely documentation/comment changes. BR, Jani. > >> --- >> Documentation/gpu/i915.rst | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst >> index 6c75380b2928..f98ee95da90f 100644 >> --- a/Documentation/gpu/i915.rst >> +++ b/Documentation/gpu/i915.rst >> @@ -349,7 +349,7 @@ of buffer object caches. Shrinking is used to make main memory >> available. Note that this is mostly orthogonal to evicting buffer >> objects, which has the goal to make space in gpu virtual address spaces. >> >> -.. kernel-doc:: drivers/gpu/drm/i915/i915_gem_shrinker.c >> +.. kernel-doc:: drivers/gpu/drm/i915/gem/i915_gem_shrinker.c >> :internal: >> >> Batchbuffer Parsing >> @@ -373,7 +373,7 @@ Batchbuffer Pools >> User Batchbuffer Execution >> -------------------------- >> >> -.. kernel-doc:: drivers/gpu/drm/i915/i915_gem_execbuffer.c >> +.. kernel-doc:: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c >> :doc: User command execution >> >> Logical Rings, Logical Ring Contexts and Execlists >> @@ -382,9 +382,6 @@ Logical Rings, Logical Ring Contexts and Execlists >> .. kernel-doc:: drivers/gpu/drm/i915/gt/intel_lrc.c >> :doc: Logical Rings, Logical Ring Contexts and Execlists >> >> -.. kernel-doc:: drivers/gpu/drm/i915/gt/intel_lrc.c >> - :internal: >> - >> Global GTT views >> ---------------- >> >> @@ -415,10 +412,10 @@ Hardware Tiling and Swizzling Details >> Object Tiling IOCTLs >> -------------------- >> >> -.. kernel-doc:: drivers/gpu/drm/i915/i915_gem_tiling.c >> +.. kernel-doc:: drivers/gpu/drm/i915/gem/i915_gem_tiling.c >> :internal: >> >> -.. kernel-doc:: drivers/gpu/drm/i915/i915_gem_tiling.c >> +.. kernel-doc:: drivers/gpu/drm/i915/gem/i915_gem_tiling.c >> :doc: buffer object tiling >> >> WOPCM >> -- >> 2.20.1 -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] Documentation/i915: Fix kernel-doc references to moved gem files Date: Thu, 06 Jun 2019 11:23:44 +0300 Message-ID: <871s072kbz.fsf@intel.com> References: <20190605095657.23601-1-jani.nikula@intel.com> <87d0jss4uo.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 686FA8926E for ; Thu, 6 Jun 2019 08:20:41 +0000 (UTC) In-Reply-To: <87d0jss4uo.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Cc: linux-doc@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAwNSBKdW4gMjAxOSwgTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+IHdy aXRlczoKPgo+PiBUaGUgZXJyb3IgbWVzc2FnZXMgY291bGQgYmUgbW9yZSBkZXNjcmlwdGl2ZSwg YnV0IGZpeCB0aGVzZSBjYXVzZWQgYnkKPj4gZmlsZSBtb3ZlczoKPj4KPj4gV0FSTklORzoga2Vy bmVsLWRvYyAnLi9zY3JpcHRzL2tlcm5lbC1kb2MgLXJzdCAtZW5hYmxlLWxpbmVubyAtaW50ZXJu YWwKPj4gICAgIC4vZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc2hyaW5rZXIuYycgZmFp bGVkIHdpdGggcmV0dXJuIGNvZGUgMgo+PiBXQVJOSU5HOiBrZXJuZWwtZG9jICcuL3NjcmlwdHMv a2VybmVsLWRvYyAtcnN0IC1lbmFibGUtbGluZW5vIC1mdW5jdGlvbgo+PiAgICAgVXNlciBjb21t YW5kIGV4ZWN1dGlvbiAuL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIu YycKPj4gICAgIGZhaWxlZCB3aXRoIHJldHVybiBjb2RlIDEKPj4gV0FSTklORzoga2VybmVsLWRv YyAnLi9zY3JpcHRzL2tlcm5lbC1kb2MgLXJzdCAtZW5hYmxlLWxpbmVubyAtaW50ZXJuYWwKPj4g ICAgIC4vZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fdGlsaW5nLmMnIGZhaWxlZCB3aXRo IHJldHVybiBjb2RlIDIKPj4gV0FSTklORzoga2VybmVsLWRvYyAnLi9zY3JpcHRzL2tlcm5lbC1k b2MgLXJzdCAtZW5hYmxlLWxpbmVubyAtZnVuY3Rpb24KPj4gICAgIGJ1ZmZlciBvYmplY3QgdGls aW5nIC4vZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fdGlsaW5nLmMnCj4+ICAgICBmYWls ZWQgd2l0aCByZXR1cm4gY29kZSAxCj4+Cj4+IEZpeGVzOiAxMGJlOThhNzdjNTUgKCJkcm0vaTkx NTogTW92ZSBtb3JlIEdFTSBvYmplY3RzIHVuZGVyIGdlbS8iKQo+PiBDYzogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1 b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGph bmkubmlrdWxhQGludGVsLmNvbT4KPgo+IC9vXAo+Cj4gUmV2aWV3ZWQtYnk6IE1pa2EgS3VvcHBh bGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgoKVGhhbmtzIGZvciB0aGUgcmV2aWV3 cywgSSB0b29rIHRoZSBsaWJlcnR5IG9mIHB1c2hpbmcgdGhlc2UgdG8gZGlucSB3aXRoCmp1c3Qg QkFUIHJlc3VsdHMsIGFzIHRoZXNlIGFyZSBwdXJlbHkgZG9jdW1lbnRhdGlvbi9jb21tZW50IGNo YW5nZXMuCgpCUiwKSmFuaS4KCj4KPj4gLS0tCj4+ICBEb2N1bWVudGF0aW9uL2dwdS9pOTE1LnJz dCB8IDExICsrKystLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA3 IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9ncHUvaTkxNS5y c3QgYi9Eb2N1bWVudGF0aW9uL2dwdS9pOTE1LnJzdAo+PiBpbmRleCA2Yzc1MzgwYjI5MjguLmY5 OGVlOTVkYTkwZiAxMDA2NDQKPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9ncHUvaTkxNS5yc3QKPj4g KysrIGIvRG9jdW1lbnRhdGlvbi9ncHUvaTkxNS5yc3QKPj4gQEAgLTM0OSw3ICszNDksNyBAQCBv ZiBidWZmZXIgb2JqZWN0IGNhY2hlcy4gU2hyaW5raW5nIGlzIHVzZWQgdG8gbWFrZSBtYWluIG1l bW9yeQo+PiAgYXZhaWxhYmxlLiBOb3RlIHRoYXQgdGhpcyBpcyBtb3N0bHkgb3J0aG9nb25hbCB0 byBldmljdGluZyBidWZmZXIKPj4gIG9iamVjdHMsIHdoaWNoIGhhcyB0aGUgZ29hbCB0byBtYWtl IHNwYWNlIGluIGdwdSB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2VzLgo+PiAgCj4+IC0uLiBrZXJuZWwt ZG9jOjogZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc2hyaW5rZXIuYwo+PiArLi4ga2Vy bmVsLWRvYzo6IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9zaHJpbmtlci5jCj4+ ICAgICA6aW50ZXJuYWw6Cj4+ICAKPj4gIEJhdGNoYnVmZmVyIFBhcnNpbmcKPj4gQEAgLTM3Myw3 ICszNzMsNyBAQCBCYXRjaGJ1ZmZlciBQb29scwo+PiAgVXNlciBCYXRjaGJ1ZmZlciBFeGVjdXRp b24KPj4gIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICAKPj4gLS4uIGtlcm5lbC1kb2M6 OiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPj4gKy4uIGtlcm5l bC1kb2M6OiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4+ ICAgICA6ZG9jOiBVc2VyIGNvbW1hbmQgZXhlY3V0aW9uCj4+ICAKPj4gIExvZ2ljYWwgUmluZ3Ms IExvZ2ljYWwgUmluZyBDb250ZXh0cyBhbmQgRXhlY2xpc3RzCj4+IEBAIC0zODIsOSArMzgyLDYg QEAgTG9naWNhbCBSaW5ncywgTG9naWNhbCBSaW5nIENvbnRleHRzIGFuZCBFeGVjbGlzdHMKPj4g IC4uIGtlcm5lbC1kb2M6OiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYwo+PiAg ICAgOmRvYzogTG9naWNhbCBSaW5ncywgTG9naWNhbCBSaW5nIENvbnRleHRzIGFuZCBFeGVjbGlz dHMKPj4gIAo+PiAtLi4ga2VybmVsLWRvYzo6IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVs X2xyYy5jCj4+IC0gICA6aW50ZXJuYWw6Cj4+IC0KPj4gIEdsb2JhbCBHVFQgdmlld3MKPj4gIC0t LS0tLS0tLS0tLS0tLS0KPj4gIAo+PiBAQCAtNDE1LDEwICs0MTIsMTAgQEAgSGFyZHdhcmUgVGls aW5nIGFuZCBTd2l6emxpbmcgRGV0YWlscwo+PiAgT2JqZWN0IFRpbGluZyBJT0NUTHMKPj4gIC0t LS0tLS0tLS0tLS0tLS0tLS0tCj4+ICAKPj4gLS4uIGtlcm5lbC1kb2M6OiBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV90aWxpbmcuYwo+PiArLi4ga2VybmVsLWRvYzo6IGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2dlbS9pOTE1X2dlbV90aWxpbmcuYwo+PiAgICAgOmludGVybmFsOgo+PiAgCj4+ IC0uLiBrZXJuZWwtZG9jOjogZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fdGlsaW5nLmMK Pj4gKy4uIGtlcm5lbC1kb2M6OiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fdGls aW5nLmMKPj4gICAgIDpkb2M6IGJ1ZmZlciBvYmplY3QgdGlsaW5nCj4+ICAKPj4gIFdPUENNCj4+ IC0tIAo+PiAyLjIwLjEKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhp Y3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==