From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E4CC10F0E for ; Tue, 9 Apr 2019 08:21:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 081E420883 for ; Tue, 9 Apr 2019 08:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbfDIIVT (ORCPT ); Tue, 9 Apr 2019 04:21:19 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43850 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbfDIIVT (ORCPT ); Tue, 9 Apr 2019 04:21:19 -0400 Received: by mail-wr1-f68.google.com with SMTP id k17so19608944wrx.10 for ; Tue, 09 Apr 2019 01:21:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=CJw0M17KP5zLfcVcS/ML93CZSeUnbftEDVSZq+BLfPk=; b=Iq8JpB+zFeDv/JjCmccaDfNcqeq481OXloB6/n+ELnkDk4UZ+PdOWtLpb1MMrCH8Lb Sp0cF2vc0hAzqLNh4qWpe36KU7Rg8W/KX134lEwUbXZzejtJh3FWB/mlHuOkX2UlwNhB MhABY7/+8N2MSFkOwuvVymx4MPGPc/Oz9Qy9BWe76tabKh/4+wW4CERthUhEAwiQXaqU 93Ti6erFfnYgOn8b+CCtvPvCg177SWLISVcYN7cBoF+0Sdao/s92eQW2hcfUB1w8Qq2v +1rFWtr7tyPoEKZNvVMax7QPy5LLgS+6OjHTb/E2wbTBDMCL/bpqdtjPzwf7d9qH7+wy 9CyA== X-Gm-Message-State: APjAAAVAnOvaxZ5fzwuYLG0S4KKQDnR/QSJk7xzQwsZ03S/dpqimzNJn 9B64sRbYoZgmulNGSJ17Z825Mg== X-Google-Smtp-Source: APXvYqy0qxvkL0uFIBU47wQFWhiChaBi+hGSGMhu+XKrX+aZ8/V/q6OmxhECqD2rPMCBaV+i9MvUBQ== X-Received: by 2002:adf:ffc2:: with SMTP id x2mr22696294wrs.86.1554798077888; Tue, 09 Apr 2019 01:21:17 -0700 (PDT) Received: from vitty.brq.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id a8sm13639197wmf.33.2019.04.09.01.21.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 01:21:16 -0700 (PDT) From: Vitaly Kuznetsov To: kvm list Cc: Sean Christopherson , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Joerg Roedel , Jon Doron , Liran Alon , Jim Mattson Subject: Re: [PATCH] KVM: x86: nVMX: allow RSM to restore VMXE CR4 flag In-Reply-To: References: <20190326130746.28748-1-vkuznets@redhat.com> <20190327192946.19128-1-sean.j.christopherson@intel.com> <87va03ml7n.fsf@vitty.brq.redhat.com> Date: Tue, 09 Apr 2019 10:21:16 +0200 Message-ID: <871s2bio77.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Jim Mattson writes: > On Thu, Mar 28, 2019 at 1:56 AM Vitaly Kuznetsov wrote: > >> P.S. We probably need a kvm-unit-tests or selftests test as >> Hyper-V+secureboot is the only known way to test this atm. > > Yes, please! And the requirement for providing tests of new features > should be applied universally, rather than ad hoc. FWIW, I have a working proof-of-concept test for KVM selftests doing SMI/RSM. I'm going to clean it up, enhance a bit, maybe add something to state_test and send out (unless someone beats me up to it, of course :-) -- Vitaly