From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3770C10F0E for ; Tue, 9 Apr 2019 09:23:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89A7520818 for ; Tue, 9 Apr 2019 09:23:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbfDIJXc convert rfc822-to-8bit (ORCPT ); Tue, 9 Apr 2019 05:23:32 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:35760 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbfDIJXb (ORCPT ); Tue, 9 Apr 2019 05:23:31 -0400 Received: by mail-ed1-f67.google.com with SMTP id s39so14298585edb.2 for ; Tue, 09 Apr 2019 02:23:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=XOLc+L7pB3W/cav0VzFKVOz8XVkDd6yFwWxqC1Tr5gM=; b=K+XdXbwXWf/lO8hfsbYC7PTqNRoyar9zwGgH2gN55sNgfIs0a0yUen4qreyh2K4k4c pSqTDrHcWQH2gWMREdjfhFBvBRyNv51eBq8QQm83gLRq/PhGiSV2AJ6smFITDCzL/AcX QnzOop3Xl/Uqqa5X+D0w6RALkc5ZQgioWhLmV9a82QPYagtx+b2fg8QgscIc6CwJQZty pJ3bMudtkJW9KhSLKP43X4jebWH6IyR9sm4zJly9bU1tAXieHue6TblYOpcm1czKGtha KSHOcMvvFUzchwNToU0re31logOJfmcCgCmMTnAx7lqLOIwoYphYRYPGkS7Cvkp6ykbD bfrw== X-Gm-Message-State: APjAAAVDxa/Dei+xZDZtabkdwLqz8rm0FD9ZdFOwrjW9BsbDdmTXo4la TvUZrdjgOfiQsHji/oGfzxigmQ== X-Google-Smtp-Source: APXvYqwK8Q6It+c8OXZ6XvD22x4faeRaO5rrz2hBOVvlMoBvQHHNVjtmuJHkK5gYuooLbRVpsqIiPg== X-Received: by 2002:aa7:d710:: with SMTP id t16mr22645872edq.222.1554801810068; Tue, 09 Apr 2019 02:23:30 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id e18sm5962238ejf.77.2019.04.09.02.23.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 02:23:29 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 4CEF21804A4; Tue, 9 Apr 2019 11:23:28 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jesper Dangaard Brouer Cc: David Miller , netdev@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov , Jakub Kicinski , =?utf-8?B?QmrDtnJuVMO2cGVs?= , brouer@redhat.com Subject: Re: [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device In-Reply-To: <20190409102559.28cbb37a@carbon> References: <155474315642.24432.6179239576879119104.stgit@alrua-x1> <155474315681.24432.16316236828243189182.stgit@alrua-x1> <20190409102559.28cbb37a@carbon> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 09 Apr 2019 11:23:28 +0200 Message-ID: <871s2bzg4v.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jesper Dangaard Brouer writes: > On Mon, 08 Apr 2019 19:05:56 +0200 Toke Høiland-Jørgensen wrote: > >> +void dev_map_put_default_map(struct net *net) >> +{ >> + mutex_lock(&dev_map_mtx); > > Looks like a white-space error... > >> + if (atomic_dec_and_test(&net->xdp.default_map.use_cnt)) { >> + __dev_map_release_default_map(&net->xdp.default_map); >> + } >> + mutex_unlock(&dev_map_mtx); > > And here again. Yeah, and there are more :/ Will fix, thanks! -Toke