From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Wed, 27 Mar 2019 15:28:04 +0100 Subject: [Buildroot] [PATCH] core/pkg-infra: tweak only .la files that need it In-Reply-To: <20190210213818.5232-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Sun, 10 Feb 2019 22:38:18 +0100") References: <20190210213818.5232-1-yann.morin.1998@free.fr> Message-ID: <871s2stmrv.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Yann" == Yann E MORIN writes: > Currently, when we tweak the .la files, we do so unconditionally on all > .la files, even those we already fixed in a previous run. > This has the nasty side effect that each .la file will be reported as > being touched by all packages that are installed after the package that > actually installed said .la file. > Since we can't easily know what files were installed by a package (that > is an instrumentation hook, and comes after the mangling), we use a > trick (like is done in libtool?): we do mangle all files, each into a > temporary location; if the result is identical to the input, we remove > the temporary, while if the result differs from the output, we move > the temporary to replace the input. > Reported-by: Nicolas Cavallari > Reported-by: Thomas Petazzoni > Signed-off-by: "Yann E. MORIN" > Cc: Thomas Petazzoni > Cc: Nicolas Cavallari > Cc: Thomas De Schampheleire > Cc: Arnout Vandecappelle > --- > Changes v1 -> v2: > - drop spurious trailing semicolon on sed command line (Thomas DS.) > - use $$(find ...) instead of $(find ...), as we don't want it to be > evaluated by the Makefile, but by the shell > - silence the output of cmp > - typoes in commit log (Thomas DS.) Committed to 2019.02.x, thanks. -- Bye, Peter Korsgaard