From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH v5] drm/i915/pmu: Always sample an active
 ringbuffer
Date: Fri, 22 Feb 2019 14:52:20 +0200
Message-ID: <871s40vvcr.fsf@gaia.fi.intel.com>
References: <20190222122318.3572-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9946188ECE
 for <intel-gfx@lists.freedesktop.org>; Fri, 22 Feb 2019 12:52:43 +0000 (UTC)
In-Reply-To: <20190222122318.3572-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQXMgd2Ug
bm8gbG9uZ2VyIGhhdmUgYSBwcmVjaXNlIGluZGljYXRpb24gb2YgcmVxdWVzdHMgcXVldWVkIHRv
IGFuCj4gZW5naW5lLCBtYWtlIG5vIHByZXN1bXB0aW9ucyBhbmQganVzdCBzYW1wbGUgdGhlIHJp
bmcgcmVnaXN0ZXJzIHRvIHNlZQo+IGlmIHRoZSBlbmdpbmUgaXMgYnVzeS4KPgo+IHYyOiBSZXBv
cnQgYnVzeSB3aGlsZSB0aGUgcmluZyBpcyBpZGxpbmcgb24gYSBzZW1hcGhvcmUvZXZlbnQuCj4g
djM6IEdpdmUgdGhlIHN0cnVjdCBhIG5hbWUhCj4gdjQ6IEFsd2F5cyAwIG91dHNpZGUgdGhlIHBv
d2Vyd2VsbDsgdHJ1c3RpbmcgdGhlIHBvd2Vyd2VsbCBpcwo+IGFjY3VyYXRlIGVub3VnaCBmb3Ig
b3VyIHNhbXBsaW5nIHBtdS4KPiB2NTogUHJvdGVjdCBhZ2FpbnN0IGdlbjcgbW1pbyBtYWRuZXNz
IGFuZCB0cnkgdG8gaW1wcm92ZSBncmFtbWFyCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz
b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRr
by51cnN1bGluQGludGVsLmNvbT4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBp
bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMgICAgICAg
ICB8IDY0ICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfcmluZ2J1ZmZlci5oIHwgIDIgKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRp
b25zKCspLCAzOCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pOTE1X3BtdS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+IGluZGV4
IDEzZDcwYjkwZGQwZi4uMjQ3YjY3YjgyZjBlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfcG11LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5j
Cj4gQEAgLTE0OCwxNCArMTQ4LDYgQEAgdm9pZCBpOTE1X3BtdV9ndF91bnBhcmtlZChzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAgCXNwaW5fdW5sb2NrX2lycSgmaTkxNS0+cG11Lmxv
Y2spOwo+ICB9Cj4gIAo+IC1zdGF0aWMgYm9vbCBncmFiX2ZvcmNld2FrZShzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqaTkxNSwgYm9vbCBmdykKPiAtewo+IC0JaWYgKCFmdykKPiAtCQlpbnRlbF91
bmNvcmVfZm9yY2V3YWtlX2dldChpOTE1LCBGT1JDRVdBS0VfQUxMKTsKPiAtCj4gLQlyZXR1cm4g
dHJ1ZTsKPiAtfQo+IC0KPiAgc3RhdGljIHZvaWQKPiAgYWRkX3NhbXBsZShzdHJ1Y3QgaTkxNV9w
bXVfc2FtcGxlICpzYW1wbGUsIHUzMiB2YWwpCj4gIHsKPiBAQCAtMTY4LDQ5ICsxNjAsNDcgQEAg
ZW5naW5lc19zYW1wbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1bnNpZ25l
ZCBpbnQgcGVyaW9kX25zKQo+ICAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+ICAJ
ZW51bSBpbnRlbF9lbmdpbmVfaWQgaWQ7Cj4gIAlpbnRlbF93YWtlcmVmX3Qgd2FrZXJlZjsKPiAt
CWJvb2wgZncgPSBmYWxzZTsKPiAgCj4gIAlpZiAoKGRldl9wcml2LT5wbXUuZW5hYmxlICYgRU5H
SU5FX1NBTVBMRV9NQVNLKSA9PSAwKQo+ICAJCXJldHVybjsKPiAgCj4gLQlpZiAoIWRldl9wcml2
LT5ndC5hd2FrZSkKPiAtCQlyZXR1cm47Cj4gLQo+IC0Jd2FrZXJlZiA9IGludGVsX3J1bnRpbWVf
cG1fZ2V0X2lmX2luX3VzZShkZXZfcHJpdik7Cj4gKwl3YWtlcmVmID0gMDsKPiArCWlmIChSRUFE
X09OQ0UoZGV2X3ByaXYtPmd0LmF3YWtlKSkKPiArCQl3YWtlcmVmID0gaW50ZWxfcnVudGltZV9w
bV9nZXRfaWZfaW5fdXNlKGRldl9wcml2KTsKPiAgCWlmICghd2FrZXJlZikKPiAgCQlyZXR1cm47
Cj4gIAo+ICsJc3Bpbl9sb2NrX2lycSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrKTsgLyogcHJldmVu
dCBjb25jdXJyZW50IG1taW8gKi8KCkkgaGFkIHRvIGRpZyBkZWVwIGluIG1lbW9yeS4gUGVyaGFw
cyBJIGhhdmUgd2FudGVkIHRvIGZvcmdldC4KQnV0IHllYWgsIGdlbjcgd2lsbCBibG93IHVwIG9u
IGNvbmN1cnJlbnQgbW1pbyBhY2Nlc3MuCgpSZXZpZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlr
YS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICAJZm9yX2VhY2hfZW5naW5lKGVuZ2luZSwg
ZGV2X3ByaXYsIGlkKSB7Cj4gLQkJdTMyIGN1cnJlbnRfc2Vxbm8gPSBpbnRlbF9lbmdpbmVfZ2V0
X3NlcW5vKGVuZ2luZSk7Cj4gLQkJdTMyIGxhc3Rfc2Vxbm8gPSBpbnRlbF9lbmdpbmVfbGFzdF9z
dWJtaXQoZW5naW5lKTsKPiArCQlzdHJ1Y3QgaW50ZWxfZW5naW5lX3BtdSAqcG11ID0gJmVuZ2lu
ZS0+cG11Owo+ICsJCWJvb2wgYnVzeTsKPiAgCQl1MzIgdmFsOwo+ICAKPiAtCQl2YWwgPSAhaTkx
NV9zZXFub19wYXNzZWQoY3VycmVudF9zZXFubywgbGFzdF9zZXFubyk7Cj4gLQo+IC0JCWlmICh2
YWwpCj4gLQkJCWFkZF9zYW1wbGUoJmVuZ2luZS0+cG11LnNhbXBsZVtJOTE1X1NBTVBMRV9CVVNZ
XSwKPiAtCQkJCSAgIHBlcmlvZF9ucyk7Cj4gLQo+IC0JCWlmICh2YWwgJiYgKGVuZ2luZS0+cG11
LmVuYWJsZSAmCj4gLQkJICAgIChCSVQoSTkxNV9TQU1QTEVfV0FJVCkgfCBCSVQoSTkxNV9TQU1Q
TEVfU0VNQSkpKSkgewo+IC0JCQlmdyA9IGdyYWJfZm9yY2V3YWtlKGRldl9wcml2LCBmdyk7Cj4g
LQo+IC0JCQl2YWwgPSBJOTE1X1JFQURfRlcoUklOR19DVEwoZW5naW5lLT5tbWlvX2Jhc2UpKTsK
PiAtCQl9IGVsc2Ugewo+IC0JCQl2YWwgPSAwOwo+IC0JCX0KPiArCQl2YWwgPSBJOTE1X1JFQURf
RlcoUklOR19DVEwoZW5naW5lLT5tbWlvX2Jhc2UpKTsKPiArCQlpZiAodmFsID09IDApIC8qIHBv
d2Vyd2VsbCBvZmYgPT4gZW5naW5lIGlkbGUgKi8KPiArCQkJY29udGludWU7Cj4gIAo+ICAJCWlm
ICh2YWwgJiBSSU5HX1dBSVQpCj4gLQkJCWFkZF9zYW1wbGUoJmVuZ2luZS0+cG11LnNhbXBsZVtJ
OTE1X1NBTVBMRV9XQUlUXSwKPiAtCQkJCSAgIHBlcmlvZF9ucyk7Cj4gLQo+ICsJCQlhZGRfc2Ft
cGxlKCZwbXUtPnNhbXBsZVtJOTE1X1NBTVBMRV9XQUlUXSwgcGVyaW9kX25zKTsKPiAgCQlpZiAo
dmFsICYgUklOR19XQUlUX1NFTUFQSE9SRSkKPiAtCQkJYWRkX3NhbXBsZSgmZW5naW5lLT5wbXUu
c2FtcGxlW0k5MTVfU0FNUExFX1NFTUFdLAo+IC0JCQkJICAgcGVyaW9kX25zKTsKPiAtCX0KPiAr
CQkJYWRkX3NhbXBsZSgmcG11LT5zYW1wbGVbSTkxNV9TQU1QTEVfU0VNQV0sIHBlcmlvZF9ucyk7
Cj4gIAo+IC0JaWYgKGZ3KQo+IC0JCWludGVsX3VuY29yZV9mb3JjZXdha2VfcHV0KGRldl9wcml2
LCBGT1JDRVdBS0VfQUxMKTsKPiArCQkvKgo+ICsJCSAqIFdoaWxlIHdhaXRpbmcgb24gYSBzZW1h
cGhvcmUgb3IgZXZlbnQsIE1JX01PREUgcmVwb3J0cyB0aGUKPiArCQkgKiByaW5nIGFzIGlkbGUu
IEhvd2V2ZXIsIHByZXZpb3VzbHkgdXNpbmcgdGhlIHNlcW5vLCBhbmQgd2l0aAo+ICsJCSAqIGV4
ZWNsaXN0cyBzYW1wbGluZywgd2UgYWNjb3VudCBmb3IgdGhlIHJpbmcgd2FpdGluZyBhcyB0aGUK
PiArCQkgKiBlbmdpbmUgYmVpbmcgYnVzeS4gVGhlcmVmb3JlLCB3ZSByZWNvcmQgdGhlIHNhbXBs
ZSBhcyBiZWluZwo+ICsJCSAqIGJ1c3kgaWYgZWl0aGVyIHdhaXRpbmcgb3IgIWlkbGUuCj4gKwkJ
ICovCj4gKwkJYnVzeSA9IHZhbCAmIChSSU5HX1dBSVRfU0VNQVBIT1JFIHwgUklOR19XQUlUKTsK
PiArCQlpZiAoIWJ1c3kpIHsKPiArCQkJdmFsID0gSTkxNV9SRUFEX0ZXKFJJTkdfTUlfTU9ERShl
bmdpbmUtPm1taW9fYmFzZSkpOwo+ICsJCQlidXN5ID0gISh2YWwgJiBNT0RFX0lETEUpOwo+ICsJ
CX0KPiArCQlpZiAoYnVzeSkKPiArCQkJYWRkX3NhbXBsZSgmcG11LT5zYW1wbGVbSTkxNV9TQU1Q
TEVfQlVTWV0sIHBlcmlvZF9ucyk7Cj4gKwl9Cj4gKwlzcGluX3VubG9ja19pcnEoJmRldl9wcml2
LT51bmNvcmUubG9jayk7Cj4gIAo+ICAJaW50ZWxfcnVudGltZV9wbV9wdXQoZGV2X3ByaXYsIHdh
a2VyZWYpOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jp
bmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IGlu
ZGV4IDcxMGZmYjIyMTc3NS4uNWQ0NWFkNGVjY2E5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX3JpbmdidWZmZXIuaAo+IEBAIC0zOTIsNyArMzkyLDcgQEAgc3RydWN0IGludGVsX2Vu
Z2luZV9jcyB7Cj4gIAkJYm9vbCBpcnFfYXJtZWQ7Cj4gIAl9IGJyZWFkY3J1bWJzOwo+ICAKPiAt
CXN0cnVjdCB7Cj4gKwlzdHJ1Y3QgaW50ZWxfZW5naW5lX3BtdSB7Cj4gIAkJLyoqCj4gIAkJICog
QGVuYWJsZTogQml0bWFzayBvZiBlbmFibGUgc2FtcGxlIGV2ZW50cyBvbiB0aGlzIGVuZ2luZS4K
PiAgCQkgKgo+IC0tIAo+IDIuMjAuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxp
c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk
ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv
L2ludGVsLWdmeA==