From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [RESEND PATCH 1/5] drm/i915/backlight: Restore backlight on resume, v2. Date: Fri, 28 Dec 2018 12:10:17 +0200 Message-ID: <871s62vu5y.fsf@intel.com> References: <20181217095024.2340-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 516BA6E4A3 for ; Fri, 28 Dec 2018 10:09:53 +0000 (UTC) In-Reply-To: <20181217095024.2340-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org Cc: Hans de Goede , Tolga Cakir , Basil Eric Rabi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxNyBEZWMgMjAxOCwgTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gUmVzdG9yZSBvdXIgc2F2ZWQgdmFsdWVzIGZvciBi YWNrbGlnaHQuIFRoaXMgd2F5IGV2ZW4gd2l0aCBmYXN0c2V0IG9uCj4gUzQgcmVzdW1lIHdlIHdp bGwgY29ycmVjdGx5IHJlc3RvcmUgdGhlIGJhY2tsaWdodCB0byB0aGUgYWN0aXZlIHZhbHVlcy4K CkkgdGhpbmsgdGhpcyBpcyBhIG5vbi10cml2aWFsIGNvbW1pdCB0aGF0IHJlcXVpcmVzIG1vcmUg ZXhwbGFuYXRpb24gaW4KdGhlIGNvbW1pdCBtZXNzYWdlIGFuZCBjb21tZW50cy4KCldoYXQgZG9l cyB0aGlzIGRvIGZvciBub24tZmFzdHNldCByZXN1bWU/IEl0IHNlZW1zIHRvIG1lIHRoaXMKZW5h Ymxlcy9kaXNhYmxlcyBiYWNrbGlnaHQgdHdpY2UgaW4gdGhhdCBjYXNlLgoKVGhpcyBkb2Vzbid0 IHRha2UgcGFuZWwgcG93ZXIgc2VxdWVuY2luZyBpbnRvIGFjY291bnQgYXQgYWxsLiBZb3UgY2Fu J3QKanVzdCBnbyBhaGVhZCBhbmQgZW5hYmxlIHRoZSBQV00gd2l0aCBubyBjb25zaWRlcmF0aW9u IG9mIGhvdyB0aGF0IGlzCmZlZCB0byB0aGUgcGFuZWwuIFRoYXQgaW4gdHVybiBpcyBlbmNvZGVy IGNvZGUsIHNvIEknbSBub3Qgc3VyZSBob3cgdGhhdApjb3VsZCBiZSBib2x0ZWQgb24gaGVyZS4K ClNvIEknbSBhZnJhaWQgSSdtIG5vdCBjb252aW5jZWQgdGhpcyB3aWxsIHdvcmsuCgpPbmUgbW9y ZSBkZXRhaWwgaW4tbGluZSBiZWxvdy4KCj4KPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gQ2FsbCBl bmFibGVfYmFja2xpZ2h0KCkgd2hlbiBiYWNrbGlnaHQubGV2ZWwgaXMgc2V0LiBPbiBzdXNwZW5k Cj4gICBiYWNrbGlnaHQuZW5hYmxlZCBpcyBhbHdheXMgY2xlYXJlZCwgdGhpcyBtYWtlcyBpdCBu b3QgYSBnb29kCj4gICBpbmRpY2F0b3IuIEFsc28gY2hlY2sgZm9yIGNydGMtPnN0YXRlLT5hY3Rp dmUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9y c3RAbGludXguaW50ZWwuY29tPgo+IENjOiBUb2xnYSBDYWtpciA8Y2V2ZWxuZXRAZ21haWwuY29t Pgo+IENjOiBCYXNpbCBFcmljIFJhYmkgPGVyaWNiYXNpbC5yYWJpQGdtYWlsLmNvbT4KPiBDYzog SGFucyBkZSBHb2VkZSA8andyZGVnb2VkZUBmZWRvcmFwcm9qZWN0Lm9yZz4KPiBDYzogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBSZXBvcnRlZC1ieTog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgIDIgKysKPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9wYW5lbC5jICAgfCAzMCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDMg ZmlsZXMgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+IGluZGV4IDJjM2YzZjY4ZDUwNi4uODZlN2IxNDVmZDk4IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xNTg4Nyw3ICsxNTg4Nyw5IEBAIHZv aWQgaW50ZWxfZGlzcGxheV9yZXN1bWUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCWlmICgh cmV0KQo+ICAJCXJldCA9IF9faW50ZWxfZGlzcGxheV9yZXN1bWUoZGV2LCBzdGF0ZSwgJmN0eCk7 Cj4gIAo+ICsJaW50ZWxfcGFuZWxfcmVzdG9yZV9iYWNrbGlnaHQoZGV2X3ByaXYpOwo+ICAJaW50 ZWxfZW5hYmxlX2lwYyhkZXZfcHJpdik7Cj4gKwo+ICAJZHJtX21vZGVzZXRfZHJvcF9sb2Nrcygm Y3R4KTsKPiAgCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiAgCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCBjYjNhMDU1ZjE4YzguLmEwNTUxNzQyYmNmNCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTIwMDMsNiArMjAwMyw3IEBAIGludCBpbnRl bF9wYW5lbF9pbml0KHN0cnVjdCBpbnRlbF9wYW5lbCAqcGFuZWwsCj4gIAkJICAgICBzdHJ1Y3Qg ZHJtX2Rpc3BsYXlfbW9kZSAqZml4ZWRfbW9kZSwKPiAgCQkgICAgIHN0cnVjdCBkcm1fZGlzcGxh eV9tb2RlICpkb3duY2xvY2tfbW9kZSk7Cj4gIHZvaWQgaW50ZWxfcGFuZWxfZmluaShzdHJ1Y3Qg aW50ZWxfcGFuZWwgKnBhbmVsKTsKPiArdm9pZCBpbnRlbF9wYW5lbF9yZXN0b3JlX2JhY2tsaWdo dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICB2b2lkIGludGVsX2ZpeGVk X3BhbmVsX21vZGUoY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmZpeGVkX21vZGUsCj4g IAkJCSAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRfbW9kZSk7Cj4gIHZvaWQg aW50ZWxfcGNoX3BhbmVsX2ZpdHRpbmcoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gaW5kZXggZWUzZTA4NDJkNTQyLi43OTkyODRmY2Q1N2Qg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiBAQCAtMTkwMyw2ICsxOTAzLDM2 IEBAIGludGVsX3BhbmVsX2luaXRfYmFja2xpZ2h0X2Z1bmNzKHN0cnVjdCBpbnRlbF9wYW5lbCAq cGFuZWwpCj4gIAl9Cj4gIH0KPiAgCj4gK3ZvaWQgaW50ZWxfcGFuZWxfcmVzdG9yZV9iYWNrbGln aHQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwlzdHJ1Y3QgaW50 ZWxfY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9saXN0X2l0 ZXIgY29ubl9pdGVyOwo+ICsKPiArCS8qIEtpbGwgYWxsIHRoZSB3b3JrIHRoYXQgbWF5IGhhdmUg YmVlbiBxdWV1ZWQgYnkgaHBkLiAqLwo+ICsJZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXJfYmVnaW4o JmRldl9wcml2LT5kcm0sICZjb25uX2l0ZXIpOwo+ICsJZm9yX2VhY2hfaW50ZWxfY29ubmVjdG9y X2l0ZXIoY29ubmVjdG9yLCAmY29ubl9pdGVyKSB7Cj4gKwkJc3RydWN0IGludGVsX3BhbmVsICpw YW5lbCA9ICZjb25uZWN0b3ItPnBhbmVsOwo+ICsJCWNvbnN0IHN0cnVjdCBkcm1fY29ubmVjdG9y X3N0YXRlICpjb25uX3N0YXRlID0KPiArCQkJY29ubmVjdG9yLT5iYXNlLnN0YXRlOwo+ICsKPiAr CQlpZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJ CWlmIChwYW5lbC0+YmFja2xpZ2h0LmxldmVsICYmIGNvbm5fc3RhdGUtPmNydGMgJiYKCnBhbmVs LT5iYWNrbGlnaHQubGV2ZWwgaXMgbm90IG5lY2Vzc2FyaWx5IDAtYmFzZWQsIGl0J3MgYmV0d2Vl bgpwYW5lbC0+YmFja2xpZ2h0LnttaW4sbWF4fS4KCkJSLApKYW5pLgoKPiArCQkgICAgY29ubl9z dGF0ZS0+Y3J0Yy0+c3RhdGUtPmFjdGl2ZSkgewo+ICsJCQljb25zdCBzdHJ1Y3QgaW50ZWxfY3J0 Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9Cj4gKwkJCQl0b19pbnRlbF9jcnRjX3N0YXRlKGNvbm5fc3Rh dGUtPmNydGMtPnN0YXRlKTsKPiArCj4gKwkJCWludGVsX3BhbmVsX2VuYWJsZV9iYWNrbGlnaHQo Y3J0Y19zdGF0ZSwgY29ubl9zdGF0ZSk7Cj4gKwkJfSBlbHNlIHsKPiArCQkJV0FSTihwYW5lbC0+ YmFja2xpZ2h0LmVuYWJsZWQsICJCYWNrbGlnaHQgZW5hYmxlZCB3aXRob3V0IGNydGNcbiIpOwo+ ICsKPiArCQkJaW50ZWxfcGFuZWxfZGlzYWJsZV9iYWNrbGlnaHQoY29ubl9zdGF0ZSk7Cj4gKwkJ fQo+ICsJfQo+ICsJZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXJfZW5kKCZjb25uX2l0ZXIpOwo+ICt9 Cj4gKwo+ICBpbnQgaW50ZWxfcGFuZWxfaW5pdChzdHJ1Y3QgaW50ZWxfcGFuZWwgKnBhbmVsLAo+ ICAJCSAgICAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmZpeGVkX21vZGUsCj4gIAkJICAgICBz dHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqZG93bmNsb2NrX21vZGUpCgotLSAKSmFuaSBOaWt1bGEs IEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK