From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915/icl: fix transcoder state readout Date: Tue, 04 Dec 2018 19:08:46 +0200 Message-ID: <871s6x8bj5.fsf@intel.com> References: <20181204101926.17174-1-jani.nikula@intel.com> <20181204112948.GA17262@ideak-desk.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C94F6E2E2 for ; Tue, 4 Dec 2018 17:08:34 +0000 (UTC) In-Reply-To: <20181204112948.GA17262@ideak-desk.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAwNCBEZWMgMjAxOCwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90 ZToKPiBPbiBUdWUsIERlYyAwNCwgMjAxOCBhdCAxMjoxOToyNlBNICswMjAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gQ29tbWl0IDJjYTcxMWNhZWNhMiAoImRybS9pOTE1L2ljbDogQ29uc2lkZXIg RFNJIGZvciBnZXR0aW5nIHRyYW5zY29kZXIKPj4gc3RhdGUiKSBjbG9iYmVycyB0aGUgcHJldmlv dXNseSByZWFkIFRSQU5TX0RESV9GVU5DX0NUTF9FRFAgcmVnaXN0ZXIKPj4gY29udGVudHMgd2l0 aCBUUkFOU19ERElfRlVOQ19DVExfRFNJMCBjb250ZW50cy4gRml4IHRoZSBzdGF0ZSByZWFkb3V0 LAo+PiBhbmQgaGFuZGxlIERTSSAxIHdoaWxlIGF0IGl0Lgo+PiAKPj4gVXNlIGEgYml0bWFzayBm b3IgaXRlcmF0aW5nIGFuZCBsb2dnaW5nIHRyYW5zY29kZXJzLCBiZWNhdXNlIHRoZSBhbGxvd2Vk Cj4+IGNvbWJpbmF0aW9ucyBhcmUgYSBiaXQgZnVua3kuCj4+IAo+PiBGaXhlczogMmNhNzExY2Fl Y2EyICgiZHJtL2k5MTUvaWNsOiBDb25zaWRlciBEU0kgZm9yIGdldHRpbmcgdHJhbnNjb2RlciBz dGF0ZSIpCj4KPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA4OTI4Cj4KPj4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+PiBDYzogTWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1aGFuQGludGVs LmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNv bT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0OCAr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAy NyBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPj4gaW5kZXggYTI1ODRmOTc3YWIxLi42NGIwZWNkNTM4ZmQgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gQEAgLTk0NzYsMTMgKzk0NzYs MTggQEAgc3RhdGljIGJvb2wgaHN3X2dldF90cmFuc2NvZGVyX3N0YXRlKHN0cnVjdCBpbnRlbF9j cnRjICpjcnRjLAo+PiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsK Pj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4+ ICAJZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbiBwb3dlcl9kb21haW47Cj4+ICsJdW5z aWduZWQgbG9uZyBwYW5lbF90cmFuc2NvZGVyX21hc2sgPSBCSVQoVFJBTlNDT0RFUl9FRFApOwo+ PiArCXVuc2lnbmVkIGxvbmcgZW5hYmxlZF9wYW5lbF90cmFuc2NvZGVycyA9IDA7Cj4+ICsJZW51 bSB0cmFuc2NvZGVyIHBhbmVsX3RyYW5zY29kZXI7Cj4+ICAJdTMyIHRtcDsKPj4gLQlib29sIGlz X2RzaSA9IGZhbHNlOwo+PiAtCWJvb2wgaXNfZWRwID0gZmFsc2U7Cj4+ICsKPj4gKwlpZiAoSVNf SUNFTEFLRShkZXZfcHJpdikpCj4+ICsJCXBhbmVsX3RyYW5zY29kZXJfbWFzayB8PQo+PiArCQkJ QklUKFRSQU5TQ09ERVJfRFNJXzApIHwgQklUKFRSQU5TQ09ERVJfRFNJXzEpOwo+PiAgCj4+ICAJ LyoKPj4gIAkgKiBUaGUgcGlwZS0+dHJhbnNjb2RlciBtYXBwaW5nIGlzIGZpeGVkIHdpdGggdGhl IGV4Y2VwdGlvbiBvZiB0aGUgZURQCj4+IC0JICogdHJhbnNjb2RlciBoYW5kbGVkIGJlbG93Lgo+ PiArCSAqIGFuZCBEU0kgdHJhbnNjb2RlcnMgaGFuZGxlZCBiZWxvdy4KPj4gIAkgKi8KPj4gIAlw aXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29kZXIgPSAoZW51bSB0cmFuc2NvZGVyKSBjcnRjLT5waXBl Owo+PiAgCj4+IEBAIC05NDkwLDIzICs5NDk1LDIyIEBAIHN0YXRpYyBib29sIGhzd19nZXRfdHJh bnNjb2Rlcl9zdGF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPj4gIAkgKiBYWFg6IERvIGlu dGVsX2Rpc3BsYXlfcG93ZXJfZ2V0X2lmX2VuYWJsZWQgYmVmb3JlIHJlYWRpbmcgdGhpcyAoZm9y Cj4+ICAJICogY29uc2lzdGVuY3kgYW5kIGxlc3Mgc3VycHJpc2luZyBjb2RlOyBpdCdzIGluIGFs d2F5cyBvbiBwb3dlcikuCj4+ICAJICovCj4+IC0JdG1wID0gSTkxNV9SRUFEKFRSQU5TX0RESV9G VU5DX0NUTChUUkFOU0NPREVSX0VEUCkpOwo+PiAtCWlmICh0bXAgJiBUUkFOU19ERElfRlVOQ19F TkFCTEUpCj4+IC0JCWlzX2VkcCA9IHRydWU7Cj4+ICsJZm9yX2VhY2hfc2V0X2JpdChwYW5lbF90 cmFuc2NvZGVyLCAmcGFuZWxfdHJhbnNjb2Rlcl9tYXNrLCAzMikgewo+Cj4gbml0OiBCSVRTX1BF Ul9MT05HIG9yIEk5MTVfTUFYX1RSQU5TQ09ERVJTPwo+Cj4+ICsJCWVudW0gcGlwZSB0cmFuc19w aXBlOwo+PiAgCj4+IC0JaWYgKElTX0lDRUxBS0UoZGV2X3ByaXYpKSB7Cj4+IC0JCXRtcCA9IEk5 MTVfUkVBRChUUkFOU19ERElfRlVOQ19DVEwoVFJBTlNDT0RFUl9EU0lfMCkpOwo+PiAtCQlpZiAo dG1wICYgVFJBTlNfRERJX0ZVTkNfRU5BQkxFKQo+PiAtCQkJaXNfZHNpID0gdHJ1ZTsKPj4gLQl9 Cj4+ICsJCXRtcCA9IEk5MTVfUkVBRChUUkFOU19ERElfRlVOQ19DVEwocGFuZWxfdHJhbnNjb2Rl cikpOwo+PiArCQlpZiAoISh0bXAgJiBUUkFOU19ERElfRlVOQ19FTkFCTEUpKQo+PiArCQkJY29u dGludWU7Cj4+ICAKPj4gLQlXQVJOX09OKGlzX2VkcCAmJiBpc19kc2kpOwo+PiArCQkvKiBMb2cg YWxsIGVuYWJsZWQgb25lcywgb25seSB1c2UgdGhlIGZpcnN0IG9uZSAqLwo+PiArCQllbmFibGVk X3BhbmVsX3RyYW5zY29kZXJzIHw9IEJJVChwYW5lbF90cmFuc2NvZGVyKTsKPj4gKwkJaWYgKGVu YWJsZWRfcGFuZWxfdHJhbnNjb2RlcnMgIT0gQklUKHBhbmVsX3RyYW5zY29kZXIpKQo+PiArCQkJ Y29udGludWU7Cj4KPgo+IG5pdDogQXMgeW91IGV4cGxhaW5lZCBmb3IgRFNJIGR1YWwgbW9kZSBi b3RoIHRyYW5zY29kZXJzIGFyZSBuZWVkZWQgYW5kCj4gd2UgZG9uJ3Qgc3VwcG9ydCBhdG0gdHdv IHNlcGFyYXRlIERTSSBwb3J0cy4gQSBjb2RlIGNvbW1lbnQgYWJvdXQgdGhpcwo+IHdvdWxkIGJl IG5pY2UuIE1heWJlIGZvciB0aGUgdHdvIERTSSBwb3J0IGNhc2Ugd2Ugc2hvdWxkIGFsc28gd2Fy biBiZWxvdy4KPgo+IFdpdGggb3Igd2l0aG91dCB0aGUgbml0czoKPiBSZXZpZXdlZC1ieTogSW1y ZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgoKVGhhbmtzLCBwdXNoZWQgd2l0aCB0aGUgY29t bWVudCBhZGRlZC4KCkJSLApKYW5pLgoKPgo+PiAgCj4+IC0JaWYgKGlzX2VkcCB8fCBpc19kc2kp IHsKPj4gLQkJZW51bSBwaXBlIHRyYW5zX3BpcGU7Cj4+ICAJCXN3aXRjaCAodG1wICYgVFJBTlNf RERJX0VEUF9JTlBVVF9NQVNLKSB7Cj4+ICAJCWRlZmF1bHQ6Cj4+IC0JCQlXQVJOKDEsICJ1bmtu b3duIHBpcGUgbGlua2VkIHRvIGVkcCB0cmFuc2NvZGVyXG4iKTsKPj4gKwkJCVdBUk4oMSwgInVu a25vd24gcGlwZSBsaW5rZWQgdG8gdHJhbnNjb2RlciAlc1xuIiwKPj4gKwkJCSAgICAgdHJhbnNj b2Rlcl9uYW1lKHBhbmVsX3RyYW5zY29kZXIpKTsKPj4gIAkJCS8qIGZhbGwgdGhyb3VnaCAqLwo+ PiAgCQljYXNlIFRSQU5TX0RESV9FRFBfSU5QVVRfQV9PTk9GRjoKPj4gIAkJY2FzZSBUUkFOU19E RElfRURQX0lOUFVUX0FfT046Cj4+IEBAIC05NTIwLDE0ICs5NTI0LDE2IEBAIHN0YXRpYyBib29s IGhzd19nZXRfdHJhbnNjb2Rlcl9zdGF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPj4gIAkJ CWJyZWFrOwo+PiAgCQl9Cj4+ICAKPj4gLQkJaWYgKHRyYW5zX3BpcGUgPT0gY3J0Yy0+cGlwZSkg ewo+PiAtCQkJaWYgKGlzX2VkcCkKPj4gLQkJCQlwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29kZXIg PSBUUkFOU0NPREVSX0VEUDsKPj4gLQkJCWVsc2UgaWYgKGlzX2RzaSkKPj4gLQkJCQlwaXBlX2Nv bmZpZy0+Y3B1X3RyYW5zY29kZXIgPSBUUkFOU0NPREVSX0RTSV8wOwo+PiAtCQl9Cj4+ICsJCWlm ICh0cmFuc19waXBlID09IGNydGMtPnBpcGUpCj4+ICsJCQlwaXBlX2NvbmZpZy0+Y3B1X3RyYW5z Y29kZXIgPSBwYW5lbF90cmFuc2NvZGVyOwo+PiAgCX0KPj4gIAo+PiArCS8qCj4+ICsJICogVmFs aWQgY29tYm9zOiBub25lLCBlRFAsIERTSTAsIERTSTEsIERTSTArRFNJMQo+PiArCSAqLwo+PiAr CVdBUk5fT04oKGVuYWJsZWRfcGFuZWxfdHJhbnNjb2RlcnMgJiBCSVQoVFJBTlNDT0RFUl9FRFAp KSAmJgo+PiArCQllbmFibGVkX3BhbmVsX3RyYW5zY29kZXJzICE9IEJJVChUUkFOU0NPREVSX0VE UCkpOwo+PiArCj4+ICAJcG93ZXJfZG9tYWluID0gUE9XRVJfRE9NQUlOX1RSQU5TQ09ERVIocGlw ZV9jb25maWctPmNwdV90cmFuc2NvZGVyKTsKPj4gIAlpZiAoIWludGVsX2Rpc3BsYXlfcG93ZXJf Z2V0X2lmX2VuYWJsZWQoZGV2X3ByaXYsIHBvd2VyX2RvbWFpbikpCj4+ICAJCXJldHVybiBmYWxz ZTsKPj4gLS0gCj4+IDIuMTEuMAo+PiAKPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291 cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK