From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers Date: Thu, 13 Sep 2018 14:03:18 +0300 Message-ID: <871s9x1wy1.fsf@linux.intel.com> References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-3-arnd@arndb.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: In-Reply-To: <20180912150142.157913-3-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, Arnd Bergmann , Frederic Barrat , Andrew Donnellan , Greg Kroah-Hartman , Frank Haverkamp , "Guilherme G. Piccoli" , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org List-Id: linux-scsi@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arnd Bergmann writes: > A handful of drivers all have a trivial wrapper around their ioctl > handler, but don't call the compat_ptr() conversion function at the > moment. In practice this does not matter, since none of them are used > on the s390 architecture and for all other architectures, compat_ptr() > does not do anything, but using the new generic_compat_ioctl_ptrarg > helper makes it more correct in theory, and simplifies the code. > > Signed-off-by: Arnd Bergmann Acked-by: Felipe Balbi =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAluaQ/YACgkQzL64meEa mQa7Cw//SVIduyNkKUJWE/M6JNaHgPcjaKHvJmfwUbCJ4obLMil5YB5r4CXLcL6c e+sSufRSpae7ea7GG3v7aKqOdA5QqwoK3Nuly7lJv7tfy29lQiXTIvVfW8f52SWM AM4vjGT/TKyMrdFoXBr8KkFlCppAXShYUSayRg7ADNnvR+pZ5aNihNdb1BVb/gfT 4/A9PObPckHwj7v3RxYe1Nj6IOuI276oNXlLOWAbC4L3ijXxTD20K+sP/ZvzzO7V /bTl1rEmyqcD5khWYw/MpJhbuDZN2FRa1lyYcp/zHOXCrkly8jaB94LlSiycajja ylzBVqOSqC3al600dBsxAU2XFlDmVcWgQZCcyubLC1C0cZdo3sshhArgiXy/v8N2 D+3l9iWr8BpC44zbCEQgjNvaqJUF0mMg4Rs7LXVH+IH6KrcZbpOf/pcjLRvqf+zt PXIyEJXDfXjOii/kSugM9EHAF8U9p+/JCxsum93vgv7E1UjZhz0X3pc3vWoIbGN6 yeKN7vkGxiue8ghzscuwJowIdv6wa9erbX0srRruxajFvnm92wp0ajHDOgaUaZAG RhQSqq+JnE9zMWSUyc3rLD7WBiDntLu4DCYNjFqQbi34tbYDUnbiejsdnSywHa6p 8TAIXk+jnn/Em5zalyWoAX4lkpdGhAgQLMySWhnvw3NEpfeX6Gw= =/6h3 -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,03/17] compat_ioctl: use correct compat_ptr() translation in drivers From: Felipe Balbi Message-Id: <871s9x1wy1.fsf@linux.intel.com> Date: Thu, 13 Sep 2018 14:03:18 +0300 To: Arnd Bergmann , viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, Frederic Barrat , Andrew Donnellan , Greg Kroah-Hartman , Frank Haverkamp , "Guilherme G. Piccoli" , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org List-ID: QXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4gd3JpdGVzOgoKPiBBIGhhbmRmdWwgb2YgZHJp dmVycyBhbGwgaGF2ZSBhIHRyaXZpYWwgd3JhcHBlciBhcm91bmQgdGhlaXIgaW9jdGwKPiBoYW5k bGVyLCBidXQgZG9uJ3QgY2FsbCB0aGUgY29tcGF0X3B0cigpIGNvbnZlcnNpb24gZnVuY3Rpb24g YXQgdGhlCj4gbW9tZW50LiBJbiBwcmFjdGljZSB0aGlzIGRvZXMgbm90IG1hdHRlciwgc2luY2Ug bm9uZSBvZiB0aGVtIGFyZSB1c2VkCj4gb24gdGhlIHMzOTAgYXJjaGl0ZWN0dXJlIGFuZCBmb3Ig YWxsIG90aGVyIGFyY2hpdGVjdHVyZXMsIGNvbXBhdF9wdHIoKQo+IGRvZXMgbm90IGRvIGFueXRo aW5nLCBidXQgdXNpbmcgdGhlIG5ldyBnZW5lcmljX2NvbXBhdF9pb2N0bF9wdHJhcmcKPiBoZWxw ZXIgbWFrZXMgaXQgbW9yZSBjb3JyZWN0IGluIHRoZW9yeSwgYW5kIHNpbXBsaWZpZXMgdGhlIGNv ZGUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgoKQWNr ZWQtYnk6IEZlbGlwZSBCYWxiaSA8ZmVsaXBlLmJhbGJpQGxpbnV4LmludGVsLmNvbT4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 429wkW00TwzF3S6 for ; Thu, 13 Sep 2018 21:03:41 +1000 (AEST) From: Felipe Balbi To: Arnd Bergmann , viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, Arnd Bergmann , Frederic Barrat , Andrew Donnellan , Greg Kroah-Hartman , Frank Haverkamp , "Guilherme G. Piccoli" , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers In-Reply-To: <20180912150142.157913-3-arnd@arndb.de> References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-3-arnd@arndb.de> Date: Thu, 13 Sep 2018 14:03:18 +0300 Message-ID: <871s9x1wy1.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arnd Bergmann writes: > A handful of drivers all have a trivial wrapper around their ioctl > handler, but don't call the compat_ptr() conversion function at the > moment. In practice this does not matter, since none of them are used > on the s390 architecture and for all other architectures, compat_ptr() > does not do anything, but using the new generic_compat_ioctl_ptrarg > helper makes it more correct in theory, and simplifies the code. > > Signed-off-by: Arnd Bergmann Acked-by: Felipe Balbi =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAluaQ/YACgkQzL64meEa mQa7Cw//SVIduyNkKUJWE/M6JNaHgPcjaKHvJmfwUbCJ4obLMil5YB5r4CXLcL6c e+sSufRSpae7ea7GG3v7aKqOdA5QqwoK3Nuly7lJv7tfy29lQiXTIvVfW8f52SWM AM4vjGT/TKyMrdFoXBr8KkFlCppAXShYUSayRg7ADNnvR+pZ5aNihNdb1BVb/gfT 4/A9PObPckHwj7v3RxYe1Nj6IOuI276oNXlLOWAbC4L3ijXxTD20K+sP/ZvzzO7V /bTl1rEmyqcD5khWYw/MpJhbuDZN2FRa1lyYcp/zHOXCrkly8jaB94LlSiycajja ylzBVqOSqC3al600dBsxAU2XFlDmVcWgQZCcyubLC1C0cZdo3sshhArgiXy/v8N2 D+3l9iWr8BpC44zbCEQgjNvaqJUF0mMg4Rs7LXVH+IH6KrcZbpOf/pcjLRvqf+zt PXIyEJXDfXjOii/kSugM9EHAF8U9p+/JCxsum93vgv7E1UjZhz0X3pc3vWoIbGN6 yeKN7vkGxiue8ghzscuwJowIdv6wa9erbX0srRruxajFvnm92wp0ajHDOgaUaZAG RhQSqq+JnE9zMWSUyc3rLD7WBiDntLu4DCYNjFqQbi34tbYDUnbiejsdnSywHa6p 8TAIXk+jnn/Em5zalyWoAX4lkpdGhAgQLMySWhnvw3NEpfeX6Gw= =/6h3 -----END PGP SIGNATURE----- --=-=-=--