All of lore.kernel.org
 help / color / mirror / Atom feed
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: add support for SolidRun Clearfog GT 8K
Date: Wed, 29 Aug 2018 18:33:39 +0300	[thread overview]
Message-ID: <871sahxk4s.fsf@tkos.co.il> (raw)
In-Reply-To: <20180829150942.GD22270@lunn.ch>

Hi Andrew,

Andrew Lunn writes:
>> The schematics say "AP Reset Switch". So it is probably meant to be a
>> software controlled "back to default" button. Is there a suitable
>> linux,code for that?
>
> There is a reset code.

I can't find it. The only match for RESET in
include/uapi/linux/input-event-codes.h is KEY_ZOOMRESET, which is most
likely not what you meant.

>> It is not assembled here so I could not test. The schematics say SLB9670.
>
> I think the standard SPI TPM TIS driver should work for that. But if
> it is not populated, you cannot test it.
>
>> >> +			port at 5 {
>> >> +				reg = <5>;
>> >> +				label = "cpu";
>> >> +				ethernet = <&cp1_eth2>;
>> >> +			};
>> >
>> > No fixed-link? It correctly defaults to 2.5G? I've never tested that.
>> 
>> Seems to work here
>
> It would be good to test it really is using 2.5G, not 1G.
>
>> There is also a patch from Rabeeh (which I did not
>> apply while testing) to make it the default:
>> 
>>   https://github.com/SolidRun/openwrt/blob/openwrt-18.06-sr/target/linux/mvebu/patches-4.14/533-fix-88e6141-cpu-max-speed.patch
>
> Which is why i don't think it actually is using 2.5G.

I see this from phylink_mac_config():

[  511.043783] mvpp2 f4000000.ethernet eth2: phylink_mac_config: mode=fixed/2500base-x/2.5Gbps/Full adv=00000,00008200 pause=10 link=1 an=1

Is that enough for a test?

> This patch will need a little rework, but it basically O.K. Change
> mv88e6x41 to mv88e6341. We use the family name in function names.

Thanks again for reviewing this not-yet-posted patch.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2018-08-29 15:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 12:13 [PATCH] arm64: dts: add support for SolidRun Clearfog GT 8K Baruch Siach
2018-08-29 14:11 ` Andrew Lunn
2018-08-29 14:47   ` Baruch Siach
2018-08-29 15:09     ` Andrew Lunn
2018-08-29 15:33       ` Baruch Siach [this message]
2018-08-29 16:38         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871sahxk4s.fsf@tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.