From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-3.0 2/9] migration: loosen recovery check when load vm
Date: Thu, 05 Jul 2018 15:01:12 +0200 [thread overview]
Message-ID: <871sch3kh3.fsf@secure.mitica> (raw)
In-Reply-To: <20180705031755.3254-3-peterx@redhat.com> (Peter Xu's message of "Thu, 5 Jul 2018 11:17:48 +0800")
Peter Xu <peterx@redhat.com> wrote:
> We were checking against -EIO, assuming that it will cover all IO
> failures. But actually it is not. One example is that in
> qemu_loadvm_section_start_full() we can have tons of places that will
> return -EINVAL even if the error is caused by IO failures on the
> network.
>
> Let's loosen the recovery check logic here to cover all the error cases
> happened by removing the explicit check against -EIO. After all we
> won't lose anything here if any other failure happened.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2018-07-05 13:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 3:17 [Qemu-devel] [PATCH for-3.0 0/9] migration: postcopy recovery unit test, bug fixes Peter Xu
2018-07-05 3:17 ` [Qemu-devel] [PATCH for-3.0 1/9] migration: simplify check to use qemu file buffer Peter Xu
2018-07-05 9:01 ` Dr. David Alan Gilbert
2018-07-05 9:11 ` Peter Xu
2018-07-05 12:59 ` Juan Quintela
2018-07-05 3:17 ` [Qemu-devel] [PATCH for-3.0 2/9] migration: loosen recovery check when load vm Peter Xu
2018-07-05 9:15 ` Dr. David Alan Gilbert
2018-07-05 9:31 ` Peter Xu
2018-07-05 13:01 ` Juan Quintela [this message]
2018-07-05 3:17 ` [Qemu-devel] [PATCH for-3.0 3/9] migration: fix incorrect bitmap size calculation Peter Xu
2018-07-05 9:38 ` Dr. David Alan Gilbert
2018-07-05 13:01 ` Juan Quintela
2018-07-05 3:17 ` [Qemu-devel] [PATCH for-3.0 4/9] tests: introduce migrate_postcopy_* helpers Peter Xu
2018-07-05 9:31 ` Balamuruhan S
2018-07-06 2:19 ` Peter Xu
2018-07-06 6:17 ` Balamuruhan S
2018-07-05 9:59 ` Dr. David Alan Gilbert
2018-07-05 13:03 ` Juan Quintela
2018-07-05 3:17 ` [Qemu-devel] [PATCH for-3.0 5/9] tests: allow migrate() to take extra flags Peter Xu
2018-07-05 10:18 ` Dr. David Alan Gilbert
2018-07-05 13:05 ` Juan Quintela
2018-07-06 10:36 ` Balamuruhan S
2018-07-05 3:17 ` [Qemu-devel] [PATCH for-3.0 6/9] tests: introduce migrate_query*() helpers Peter Xu
2018-07-05 10:23 ` Dr. David Alan Gilbert
2018-07-05 13:07 ` Juan Quintela
2018-07-05 10:59 ` Balamuruhan S
2018-07-05 13:06 ` Juan Quintela
2018-07-05 3:17 ` [Qemu-devel] [PATCH for-3.0 7/9] tests: introduce wait_for_migration_status() Peter Xu
2018-07-05 10:27 ` Dr. David Alan Gilbert
2018-07-05 13:07 ` Juan Quintela
2018-07-06 10:41 ` Balamuruhan S
2018-07-05 3:17 ` [Qemu-devel] [PATCH for-3.0 8/9] tests: add postcopy recovery test Peter Xu
2018-07-05 10:30 ` Dr. David Alan Gilbert
2018-07-05 13:08 ` Juan Quintela
2018-07-05 3:17 ` [Qemu-devel] [PATCH for-3.0 9/9] tests: hide stderr for " Peter Xu
2018-07-05 10:36 ` Dr. David Alan Gilbert
2018-07-05 13:09 ` Juan Quintela
2018-07-06 9:17 ` [Qemu-devel] [PATCH for-3.0 0/9] migration: postcopy recovery unit test, bug fixes Dr. David Alan Gilbert
2018-07-06 10:56 ` Dr. David Alan Gilbert
2018-07-06 11:45 ` Balamuruhan S
2018-07-06 12:46 ` Balamuruhan S
2018-07-12 8:50 ` Dr. David Alan Gilbert
2018-07-10 3:27 ` Peter Xu
2018-07-10 8:53 ` Dr. David Alan Gilbert
2018-07-10 1:56 ` Balamuruhan S
2018-07-10 3:07 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sch3kh3.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.