From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keith Packard" Subject: Re: [PATCH 5/7] vulkan: add VK_EXT_display_control [v5] Date: Wed, 20 Jun 2018 15:49:56 -0700 Message-ID: <871sd1xecr.fsf@keithp.com> References: <20180615025256.10657-1-keithp@keithp.com> <20180615025256.10657-6-keithp@keithp.com> <87a7rqqd7c.fsf@keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2083978502==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jason Ekstrand Cc: ML mesa-dev , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============2083978502== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jason Ekstrand writes: > That seems good to me. Unless, of course, DPMS is something we expect to > change over time somehow. Then again, we don't handle that at all right > now so meh. Let's go with what you wrote above for now. It's not even the dpms value, it's the dpms property itself, which DRM never changes. > They shouldn't be and that's why I'm a fan of making them asserts which g= et > compiled out instead of actual checks. Also, I find this pseudo reference > counting to be somewhat confusing and adding asserts informs the reader of > the assumptions made. Ok, I've added this. > What test suite? Honestly, I know of no code anywhere that actually uses > this API for anything other than VR headsets. > > I guess it's kind-of a question of how much effort we want to put into > this. One option would be to add VK_KHR_display support to vkcube and ma= ke > it automatically show up on all your displays using hotplug events. > > If we're going to not care, returning VK_ERROR_FEATURE_NOT_PRESENT is > probably the best thing to do since at least the app has feedback. Not caring seems best to me -- the Vulkan display API isn't capable of supporting a "real" window system; for that, you'd really want to use DRM directly and create some way to share that with Vulkan like the extension I wrote to pass the DRM master FD into the driver at init time. > Awesome. I think we're really close on this one. I'll send out the current series and you can see if you like it. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlsq2hQACgkQ2yIaaQAA ABHlshAArYC1L3nKfxhgroL+ZHc1tytl45iGpYyJYG8K4QDRWz5Dv15Z9GkarGF5 D+db48OMhqR98E9s1AZHWLn1223Y0tOdeoer0XCUlwl6j9A4vlt38vypO1vqouxQ kzVxiaGoOELX/3NvjXTSfL5vCcH7Rq57ifWsco8Aj88rwFKnpLWCmoCslOaOQ08G UA5FltPlKPn0S17ek4hzB5j14Az+Cx7GgaZmmOzJ/KorDR+8hSUHnb6EvUSwKeMS /RhIZbiusSmz0ZXVT/ZgVYp9c3uKOsIbJA6RD4yT91PPVEkNaDGshCrUBFsYe+T4 qntm36VdX6685SgAnvpO3yZm4AzjFLF8qQ2ER55rgMUjHez7I3jBvvISGtDivQDX oC+tMdG10NOO+xdTQccVHM7p2wuA6B605Br4UCX0DGXX6zCi3PveSOgjaXTyITrK Tgysvloc3elplp61WgTcBggpddVZR4UixvFjWF4ahGMyexSlUqW3/E0B2yMbJk4q ednFPFSrh/j9vRtVeQKfJxLo1dB7+NqV33yH4k95hA0fsf29RJEiEXv5QPZsYzN/ sUqFiw2/vitKGALrgdjuD1Fdg39KXdCgxEHBkhsAadBzpCe8bayz0FXoTO9EYdC2 djY8nJ68XXGfnGpC90/PDDqbv7VZxRzyfCJ4cBdXf2X5X27NVXI= =I8+W -----END PGP SIGNATURE----- --=-=-=-- --===============2083978502== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2083978502==--