From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keith Packard" Subject: Re: [Mesa-dev] [PATCH] wsi_common_display: Deal with vscan values Date: Tue, 19 Jun 2018 13:56:58 -0700 Message-ID: <871sd2sdet.fsf@keithp.com> References: <20180615005701.22266-1-keithp@keithp.com> <87k1r0x21g.fsf@keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2122720574==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jason Ekstrand Cc: ML mesa-dev , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============2122720574== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jason Ekstrand writes: > 1) We weren't setting planeReorderPossible at all and we were using 0 > instead of VK_FALSE (they're the same but we should use the enum) for > persistentContent > 2) We weren't advertising disconnected connectors via > GetPhysicalDeviceDisplayProperties but were returning them from > GetPhysicalDeviceDisplayPlaneProperties. > 3) We weren't setting result if the condition variable failed to > initialize (thanks GCC!) > =E2=80=8B > There is one outstanding issue that the CTS is complaining about, namely > that you can't create modes. It tests that mode creation fails for a mode > with a zero width, height, or refresh rate and that's all fine. It then > tries to re-create one of the modes that we've returned to it in > GetDisplayModeProperties and assumes that it will work. We should probab= ly > at least make sure that works by walking the list and looking for a mode > that matches the requested one and returning it. I don't think anything > actually requires us to return a unique pointer so it can be a search > instead of a create. And that seems to at least make CTS happy. I've merged your fixes into the first patch, added support for vkCreateDisplayModeKHR, rebased to master and pushed the results to my repository. It looks like we're done here but I'll wait until I hear from you before pushing to master in case you've got additional concerns. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlspbhsACgkQ2yIaaQAA ABH/dA/+Opizxz9WsyKN4kUGMiehanWGzFY7b97yyKYUY+UAoX61oorH+NZgXeTe 3rtRvZNpDvTTrQaeh9cE+Mdwc5MdlpiusOQhStWMFIuXZFd/G5dPC2DLSJK5VwnP hISsjHQX+7n7AJK05p+IX3ijSbJNrvxLHLYDzUDoVcTOH0NSG1CcV22gg7kNkezW 1RWAnYmOl2245yFTDpHVwCUOVVsln53oesB8ygBxVNwZcPVKG0K6zmVQwU+aXQq/ ZcWFZz4docLhDpYq6xDcoPgrKSn6nv65J4OQTiJqt40+TGJCGaKZiuLXGzyOaed+ gbCD/RMAbxsb1M52LJozRpGTkcZVoTwjKnuwpxcz4VykeM/EPDHAB+jqMcDwZJdA xThr5vCisEjd7nJGpA5ChLZ7ACnNFHWFN9D/4wBNd7Fop1W7YErb9akt48lI1NdM gnsLtII5DCZm/yOYGRI6GyR53X/DiRL02x9PVjDCEB5cFq6/6wDln+ozvvPqyw6r DC8DmlgVWFlzev65DtXGYxca4hfuv7ZVzIOj7uGim1qxoHzpj3ygM6rgXVZVK+mT wzy8gYw4wdvHyKJwgV9DyQtenNblFFDeu2Uy3/24dy7yIGvY+Zj6YoCkP1WPwyj2 cxxTpe28xHGCEb/3ZfUzswlqyx5II9+s+VQy4CZ2H1y2TAtKUpI= =TDam -----END PGP SIGNATURE----- --=-=-=-- --===============2122720574== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2122720574==--