From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Wed, 16 May 2018 14:23:24 +0000 Subject: Re: [PATCH][V2] drm/i915/dp: fix spelling mistakes: "seqeuncer" and "seqeuencer" Message-Id: <871seb1xyb.fsf@intel.com> List-Id: References: <20180509101606.17483-1-colin.king@canonical.com> <87bmdp3y7o.fsf@intel.com> In-Reply-To: <87bmdp3y7o.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 09 May 2018, Jani Nikula wrote: > On Wed, 09 May 2018, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistakes in WARN warning message text and >> in comments: >> >> "seqeuncer", "seqeuencer" -> "sequencer" >> >> Signed-off-by: Colin Ian King > > Reviewed-by: Jani Nikula > > (Waiting for the CI runs before merging.) And pushed to dinq, thanks for the patch. BR, Jani. > >> --- >> >> V2: Also fix seqeuencer in comments >> >> --- >> drivers/gpu/drm/i915/intel_dp.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c >> index dde92e4af5d3..2cc58596ff5a 100644 >> --- a/drivers/gpu/drm/i915/intel_dp.c >> +++ b/drivers/gpu/drm/i915/intel_dp.c >> @@ -513,7 +513,7 @@ vlv_power_sequencer_kick(struct intel_dp *intel_dp) >> uint32_t DP; >> >> if (WARN(I915_READ(intel_dp->output_reg) & DP_PORT_EN, >> - "skipping pipe %c power seqeuncer kick due to port %c being active\n", >> + "skipping pipe %c power sequencer kick due to port %c being active\n", >> pipe_name(pipe), port_name(intel_dig_port->base.port))) >> return; >> >> @@ -554,7 +554,7 @@ vlv_power_sequencer_kick(struct intel_dp *intel_dp) >> /* >> * Similar magic as in intel_dp_enable_port(). >> * We _must_ do this port enable + disable trick >> - * to make this power seqeuencer lock onto the port. >> + * to make this power sequencer lock onto the port. >> * Otherwise even VDD force bit won't work. >> */ >> I915_WRITE(intel_dp->output_reg, DP); >> @@ -3066,11 +3066,11 @@ static void vlv_detach_power_sequencer(struct intel_dp *intel_dp) >> edp_panel_vdd_off_sync(intel_dp); >> >> /* >> - * VLV seems to get confused when multiple power seqeuencers >> + * VLV seems to get confused when multiple power sequencers >> * have the same port selected (even if only one has power/vdd >> * enabled). The failure manifests as vlv_wait_port_ready() failing >> * CHV on the other hand doesn't seem to mind having the same port >> - * selected in multiple power seqeuencers, but let's clear the >> + * selected in multiple power sequencers, but let's clear the >> * port select always when logically disconnecting a power sequencer >> * from a port. >> */ >> @@ -5698,7 +5698,7 @@ intel_dp_init_panel_power_sequencer_registers(struct intel_dp *intel_dp, >> >> /* >> * On some VLV machines the BIOS can leave the VDD >> - * enabled even on power seqeuencers which aren't >> + * enabled even on power sequencers which aren't >> * hooked up to any port. This would mess up the >> * power domain tracking the first time we pick >> * one of these power sequencers for use since >> @@ -5706,7 +5706,7 @@ intel_dp_init_panel_power_sequencer_registers(struct intel_dp *intel_dp, >> * already on and therefore wouldn't grab the power >> * domain reference. Disable VDD first to avoid this. >> * This also avoids spuriously turning the VDD on as >> - * soon as the new power seqeuencer gets initialized. >> + * soon as the new power sequencer gets initialized. >> */ >> if (force_disable_vdd) { >> u32 pp = ironlake_get_pp_control(intel_dp); -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH][V2] drm/i915/dp: fix spelling mistakes: "seqeuncer" and "seqeuencer" Date: Wed, 16 May 2018 17:23:24 +0300 Message-ID: <871seb1xyb.fsf@intel.com> References: <20180509101606.17483-1-colin.king@canonical.com> <87bmdp3y7o.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87bmdp3y7o.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Colin King , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAwOSBNYXkgMjAxOCwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVs LmNvbT4gd3JvdGU6Cj4gT24gV2VkLCAwOSBNYXkgMjAxOCwgQ29saW4gS2luZyA8Y29saW4ua2lu Z0BjYW5vbmljYWwuY29tPiB3cm90ZToKPj4gRnJvbTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtp bmdAY2Fub25pY2FsLmNvbT4KPj4KPj4gVHJpdmlhbCBmaXggdG8gc3BlbGxpbmcgbWlzdGFrZXMg aW4gV0FSTiB3YXJuaW5nIG1lc3NhZ2UgdGV4dCBhbmQKPj4gaW4gY29tbWVudHM6Cj4+Cj4+ICJz ZXFldW5jZXIiLCAic2VxZXVlbmNlciIgLT4gInNlcXVlbmNlciIKPj4KPj4gU2lnbmVkLW9mZi1i eTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4KPgo+IFJldmlld2Vk LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+Cj4gKFdhaXRpbmcgZm9y IHRoZSBDSSBydW5zIGJlZm9yZSBtZXJnaW5nLikKCkFuZCBwdXNoZWQgdG8gZGlucSwgdGhhbmtz IGZvciB0aGUgcGF0Y2guCgpCUiwKSmFuaS4KCj4KPj4gLS0tCj4+Cj4+IFYyOiBBbHNvIGZpeCBz ZXFldWVuY2VyIGluIGNvbW1lbnRzCj4+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHAuYyB8IDEyICsrKysrKy0tLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4+IGlu ZGV4IGRkZTkyZTRhZjVkMy4uMmNjNTg1OTZmZjVhIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwLmMKPj4gQEAgLTUxMyw3ICs1MTMsNyBAQCB2bHZfcG93ZXJfc2VxdWVuY2VyX2tpY2soc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCkKPj4gIAl1aW50MzJfdCBEUDsKPj4gIAo+PiAgCWlmIChX QVJOKEk5MTVfUkVBRChpbnRlbF9kcC0+b3V0cHV0X3JlZykgJiBEUF9QT1JUX0VOLAo+PiAtCQkg InNraXBwaW5nIHBpcGUgJWMgcG93ZXIgc2VxZXVuY2VyIGtpY2sgZHVlIHRvIHBvcnQgJWMgYmVp bmcgYWN0aXZlXG4iLAo+PiArCQkgInNraXBwaW5nIHBpcGUgJWMgcG93ZXIgc2VxdWVuY2VyIGtp Y2sgZHVlIHRvIHBvcnQgJWMgYmVpbmcgYWN0aXZlXG4iLAo+PiAgCQkgcGlwZV9uYW1lKHBpcGUp LCBwb3J0X25hbWUoaW50ZWxfZGlnX3BvcnQtPmJhc2UucG9ydCkpKQo+PiAgCQlyZXR1cm47Cj4+ ICAKPj4gQEAgLTU1NCw3ICs1NTQsNyBAQCB2bHZfcG93ZXJfc2VxdWVuY2VyX2tpY2soc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCkKPj4gIAkvKgo+PiAgCSAqIFNpbWlsYXIgbWFnaWMgYXMgaW4g aW50ZWxfZHBfZW5hYmxlX3BvcnQoKS4KPj4gIAkgKiBXZSBfbXVzdF8gZG8gdGhpcyBwb3J0IGVu YWJsZSArIGRpc2FibGUgdHJpY2sKPj4gLQkgKiB0byBtYWtlIHRoaXMgcG93ZXIgc2VxZXVlbmNl ciBsb2NrIG9udG8gdGhlIHBvcnQuCj4+ICsJICogdG8gbWFrZSB0aGlzIHBvd2VyIHNlcXVlbmNl ciBsb2NrIG9udG8gdGhlIHBvcnQuCj4+ICAJICogT3RoZXJ3aXNlIGV2ZW4gVkREIGZvcmNlIGJp dCB3b24ndCB3b3JrLgo+PiAgCSAqLwo+PiAgCUk5MTVfV1JJVEUoaW50ZWxfZHAtPm91dHB1dF9y ZWcsIERQKTsKPj4gQEAgLTMwNjYsMTEgKzMwNjYsMTEgQEAgc3RhdGljIHZvaWQgdmx2X2RldGFj aF9wb3dlcl9zZXF1ZW5jZXIoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPj4gIAllZHBfcGFu ZWxfdmRkX29mZl9zeW5jKGludGVsX2RwKTsKPj4gIAo+PiAgCS8qCj4+IC0JICogVkxWIHNlZW1z IHRvIGdldCBjb25mdXNlZCB3aGVuIG11bHRpcGxlIHBvd2VyIHNlcWV1ZW5jZXJzCj4+ICsJICog VkxWIHNlZW1zIHRvIGdldCBjb25mdXNlZCB3aGVuIG11bHRpcGxlIHBvd2VyIHNlcXVlbmNlcnMK Pj4gIAkgKiBoYXZlIHRoZSBzYW1lIHBvcnQgc2VsZWN0ZWQgKGV2ZW4gaWYgb25seSBvbmUgaGFz IHBvd2VyL3ZkZAo+PiAgCSAqIGVuYWJsZWQpLiBUaGUgZmFpbHVyZSBtYW5pZmVzdHMgYXMgdmx2 X3dhaXRfcG9ydF9yZWFkeSgpIGZhaWxpbmcKPj4gIAkgKiBDSFYgb24gdGhlIG90aGVyIGhhbmQg ZG9lc24ndCBzZWVtIHRvIG1pbmQgaGF2aW5nIHRoZSBzYW1lIHBvcnQKPj4gLQkgKiBzZWxlY3Rl ZCBpbiBtdWx0aXBsZSBwb3dlciBzZXFldWVuY2VycywgYnV0IGxldCdzIGNsZWFyIHRoZQo+PiAr CSAqIHNlbGVjdGVkIGluIG11bHRpcGxlIHBvd2VyIHNlcXVlbmNlcnMsIGJ1dCBsZXQncyBjbGVh ciB0aGUKPj4gIAkgKiBwb3J0IHNlbGVjdCBhbHdheXMgd2hlbiBsb2dpY2FsbHkgZGlzY29ubmVj dGluZyBhIHBvd2VyIHNlcXVlbmNlcgo+PiAgCSAqIGZyb20gYSBwb3J0Lgo+PiAgCSAqLwo+PiBA QCAtNTY5OCw3ICs1Njk4LDcgQEAgaW50ZWxfZHBfaW5pdF9wYW5lbF9wb3dlcl9zZXF1ZW5jZXJf cmVnaXN0ZXJzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4+ICAKPj4gIAkvKgo+PiAgCSAq IE9uIHNvbWUgVkxWIG1hY2hpbmVzIHRoZSBCSU9TIGNhbiBsZWF2ZSB0aGUgVkRECj4+IC0JICog ZW5hYmxlZCBldmVuIG9uIHBvd2VyIHNlcWV1ZW5jZXJzIHdoaWNoIGFyZW4ndAo+PiArCSAqIGVu YWJsZWQgZXZlbiBvbiBwb3dlciBzZXF1ZW5jZXJzIHdoaWNoIGFyZW4ndAo+PiAgCSAqIGhvb2tl ZCB1cCB0byBhbnkgcG9ydC4gVGhpcyB3b3VsZCBtZXNzIHVwIHRoZQo+PiAgCSAqIHBvd2VyIGRv bWFpbiB0cmFja2luZyB0aGUgZmlyc3QgdGltZSB3ZSBwaWNrCj4+ICAJICogb25lIG9mIHRoZXNl IHBvd2VyIHNlcXVlbmNlcnMgZm9yIHVzZSBzaW5jZQo+PiBAQCAtNTcwNiw3ICs1NzA2LDcgQEAg aW50ZWxfZHBfaW5pdF9wYW5lbF9wb3dlcl9zZXF1ZW5jZXJfcmVnaXN0ZXJzKHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHAsCj4+ICAJICogYWxyZWFkeSBvbiBhbmQgdGhlcmVmb3JlIHdvdWxkbid0 IGdyYWIgdGhlIHBvd2VyCj4+ICAJICogZG9tYWluIHJlZmVyZW5jZS4gRGlzYWJsZSBWREQgZmly c3QgdG8gYXZvaWQgdGhpcy4KPj4gIAkgKiBUaGlzIGFsc28gYXZvaWRzIHNwdXJpb3VzbHkgdHVy bmluZyB0aGUgVkREIG9uIGFzCj4+IC0JICogc29vbiBhcyB0aGUgbmV3IHBvd2VyIHNlcWV1ZW5j ZXIgZ2V0cyBpbml0aWFsaXplZC4KPj4gKwkgKiBzb29uIGFzIHRoZSBuZXcgcG93ZXIgc2VxdWVu Y2VyIGdldHMgaW5pdGlhbGl6ZWQuCj4+ICAJICovCj4+ICAJaWYgKGZvcmNlX2Rpc2FibGVfdmRk KSB7Cj4+ICAJCXUzMiBwcCA9IGlyb25sYWtlX2dldF9wcF9jb250cm9sKGludGVsX2RwKTsKCi0t IApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410AbeEPOUw (ORCPT ); Wed, 16 May 2018 10:20:52 -0400 Received: from mga11.intel.com ([192.55.52.93]:2969 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbeEPOUv (ORCPT ); Wed, 16 May 2018 10:20:51 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,390,1520924400"; d="scan'208";a="55745477" From: Jani Nikula To: Colin King , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] drm/i915/dp: fix spelling mistakes: "seqeuncer" and "seqeuencer" In-Reply-To: <87bmdp3y7o.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180509101606.17483-1-colin.king@canonical.com> <87bmdp3y7o.fsf@intel.com> Date: Wed, 16 May 2018 17:23:24 +0300 Message-ID: <871seb1xyb.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 09 May 2018, Jani Nikula wrote: > On Wed, 09 May 2018, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistakes in WARN warning message text and >> in comments: >> >> "seqeuncer", "seqeuencer" -> "sequencer" >> >> Signed-off-by: Colin Ian King > > Reviewed-by: Jani Nikula > > (Waiting for the CI runs before merging.) And pushed to dinq, thanks for the patch. BR, Jani. > >> --- >> >> V2: Also fix seqeuencer in comments >> >> --- >> drivers/gpu/drm/i915/intel_dp.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c >> index dde92e4af5d3..2cc58596ff5a 100644 >> --- a/drivers/gpu/drm/i915/intel_dp.c >> +++ b/drivers/gpu/drm/i915/intel_dp.c >> @@ -513,7 +513,7 @@ vlv_power_sequencer_kick(struct intel_dp *intel_dp) >> uint32_t DP; >> >> if (WARN(I915_READ(intel_dp->output_reg) & DP_PORT_EN, >> - "skipping pipe %c power seqeuncer kick due to port %c being active\n", >> + "skipping pipe %c power sequencer kick due to port %c being active\n", >> pipe_name(pipe), port_name(intel_dig_port->base.port))) >> return; >> >> @@ -554,7 +554,7 @@ vlv_power_sequencer_kick(struct intel_dp *intel_dp) >> /* >> * Similar magic as in intel_dp_enable_port(). >> * We _must_ do this port enable + disable trick >> - * to make this power seqeuencer lock onto the port. >> + * to make this power sequencer lock onto the port. >> * Otherwise even VDD force bit won't work. >> */ >> I915_WRITE(intel_dp->output_reg, DP); >> @@ -3066,11 +3066,11 @@ static void vlv_detach_power_sequencer(struct intel_dp *intel_dp) >> edp_panel_vdd_off_sync(intel_dp); >> >> /* >> - * VLV seems to get confused when multiple power seqeuencers >> + * VLV seems to get confused when multiple power sequencers >> * have the same port selected (even if only one has power/vdd >> * enabled). The failure manifests as vlv_wait_port_ready() failing >> * CHV on the other hand doesn't seem to mind having the same port >> - * selected in multiple power seqeuencers, but let's clear the >> + * selected in multiple power sequencers, but let's clear the >> * port select always when logically disconnecting a power sequencer >> * from a port. >> */ >> @@ -5698,7 +5698,7 @@ intel_dp_init_panel_power_sequencer_registers(struct intel_dp *intel_dp, >> >> /* >> * On some VLV machines the BIOS can leave the VDD >> - * enabled even on power seqeuencers which aren't >> + * enabled even on power sequencers which aren't >> * hooked up to any port. This would mess up the >> * power domain tracking the first time we pick >> * one of these power sequencers for use since >> @@ -5706,7 +5706,7 @@ intel_dp_init_panel_power_sequencer_registers(struct intel_dp *intel_dp, >> * already on and therefore wouldn't grab the power >> * domain reference. Disable VDD first to avoid this. >> * This also avoids spuriously turning the VDD on as >> - * soon as the new power seqeuencer gets initialized. >> + * soon as the new power sequencer gets initialized. >> */ >> if (force_disable_vdd) { >> u32 pp = ironlake_get_pp_control(intel_dp); -- Jani Nikula, Intel Open Source Technology Center