From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 00/27] Add multi-channel and overheat IRQ support to Armada thermal driver Date: Wed, 16 May 2018 19:28:45 +0200 Message-ID: <871seb33xu.fsf@bootlin.com> References: <20180421151255.29929-1-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180421151255.29929-1-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Sat, 21 Apr 2018 17:12:28 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Nadav Haklai , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , linux-pm@vger.kernel.org, Will Deacon , Maxime Chevallier , Eduardo Valentin , David Sniatkiwicz , Rob Herring , Thomas Petazzoni , Zhang Rui , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgTWlxdWVsLAogCiBPbiBzYW0uLCBhdnJpbCAyMSAyMDE4LCBNaXF1ZWwgUmF5bmFsIDxtaXF1 ZWwucmF5bmFsQGJvb3RsaW4uY29tPiB3cm90ZToKCj4gVGhlIG9ubHkgY2FwYWJpbGl0eSBvZiB0 aGUgQXJtYWRhIHRoZXJtYWwgZHJpdmVyIGlzIGN1cnJlbnRseSBqdXN0IHRvCj4gcmVhZCBvbmUg c2Vuc29yICh0aGUgZGVmYXVsdCBvbmUpIHBlciBBUCBhbmQgb25lIHBlciBDUC4KPgo+IEFjdHVh bGx5LCB0aGVyZSBpcyBvbmUgc2Vuc29yIHBlciBjb3JlIGluIHRoZSBBUDgwNiBwbHVzIG9uZSBz ZW5zb3IgaW4KPiB0aGUgdGhlcm1hbCBJUCBpdHNlbGYuIFRoZSBDUDExMCBqdXN0IGZlYXR1cmVz IG9uZSB0aGVybWFsIHNlbnNvciBpbiBpdHMKPiBvd24gdGhlcm1hbCBJUC4KPgo+IEFsc28sIHRo ZXJlIGlzIG5vIG5lZWQgZm9yIHRoZSB0aGVybWFsIGNvcmUgdG8gcG9sbCB0aGUgdGVtcGVyYXR1 cmUgb2YKPiBlYWNoIHNlbnNvciBieSBzb2Z0d2FyZSBhcyB0aGlzIElQIChhdCBsZWFzdCBmb3Ig QVA4MDYgYW5kIENQMTEwCj4gY29tcGF0aWJsZXMpIGZlYXR1cmVzIGFuIGhhcmR3YXJlIG92ZXJo ZWF0IGludGVycnVwdC4KPgo+IFRoaXMgc2VyaWVzIGZpcnN0IGltcHJvdmVzIHRoZSByZWFkYWJp bGl0eSBvZiB0aGlzIGRyaXZlciwgdGhlbiBhZGRzCj4gc3VwcG9ydCBmb3IgbXVsdGktY2hhbm5l bCB0aGVybWFsIElQcywgYW5kIGZpbmFsbHkgYWRkcyBzdXBwb3J0IGZvciB0aGUKPiBoYXJkd2Fy ZSBvdmVyaGVhdCBpbnRlcnJ1cHQuIFRoZSBiaW5kaW5ncyBhbmQgdGhlIGRldmljZS10cmVlcyBh cmUKPiB1cGRhdGVkIGFjY29yZGluZ2x5Lgo+Cj4gUGxlYXNlIG5vdGUgdGhhdCB0aGUgdGhlcm1h bCBJUCByYWlzZXMgU0VJIGludGVycnVwdHMsIGZyb20gd2hpY2ggdGhlCj4gc3VwcG9ydCBhcyBq dXN0IGJlZW4gY29udHJpYnV0ZWQgYW5kIG5vdCBtZXJnZWQgeWV0LiBBcHBseWluZyB0aGUgbGFz dAo+IERUIHBhdGNoZXMgcmVmZXJyaW5nIHRvIHRoZSAnc2VpJyBhbmQgJ2ljdV9zZWknIG5vZGVz IHdpbGwgcmVxdWlyZSB0aGlzCj4gZmVhdHVyZSBbMV0gdG8gaGF2ZSBiZWVuIGFjY2VwdGVkIGZp cnN0Lgo+Cj4gWzFdIGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL3BpcGVybWFpbC9saW51eC1h cm0ta2VybmVsLzIwMTgtQXByaWwvNTcyODUyLmh0bWwKPgo+IFRoYW5rIHlvdSwKPiBNaXF1w6hs Cj4KPgo+IE1pcXVlbCBSYXluYWwgKDI3KToKPiAgIHRoZXJtYWw6IGFybWFkYTogYWRkIGEgZnVu Y3Rpb24gdGhhdCBzYW5pdGl6ZXMgdGhlIHRoZXJtYWwgem9uZSBuYW1lCj4gICB0aGVybWFsOiBh cm1hZGE6IHJlbW92ZSB1c2VsZXNzIHJlZ2lzdGVyIGFjY2Vzc2VzCj4gICB0aGVybWFsOiBhcm1h ZGE6IHJlbW92ZSBtaXNsZWFkaW5nIGNvbW1lbnRzCj4gICB0aGVybWFsOiBhcm1hZGE6IHJlbmFt ZSB0aGUgaW5pdGlhbGl6YXRpb24gcm91dGluZQo+ICAgdGhlcm1hbDogYXJtYWRhOiBkaXNzb2Np YXRlIGEzODAgYW5kIGNwMTEwIC0+aW5pdCgpIGhvb2tzCj4gICB0aGVybWFsOiBhcm1hZGE6IGF2 ZXJhZ2Ugb3ZlciBzYW1wbGVzIHRvIGF2b2lkIGdsaXRjaGVzCj4gICB0aGVybWFsOiBhcm1hZGE6 IGNvbnZlcnQgZHJpdmVyIHRvIHN5c2NvbiByZWdpc3RlciBhY2Nlc3Nlcwo+ICAgdGhlcm1hbDog YXJtYWRhOiB1c2UgdGhlIHJlc291cmNlIG1hbmFnZWQgcmVnaXN0cmF0aW9uIGhlbHBlcgo+ICAg ICBhbHRlcm5hdGl2ZQo+ICAgdGhlcm1hbDogYXJtYWRhOiBhZGQgbXVsdGktY2hhbm5lbCBzZW5z b3JzIHN1cHBvcnQKPiAgIHRoZXJtYWw6IGFybWFkYTogcmVtb3ZlIHNlbnNvcnMgdmFsaWRpdHkg ZnJvbSB0aGUgSVAgaW5pdGlhbGl6YXRpb24KPiAgIHRoZXJtYWw6IGFybWFkYTogbW92ZSB2YWxp ZGl0eSBjaGVjayBvdXQgb2YgdGhlIHJlYWQgZnVuY3Rpb24KPiAgIHRoZXJtYWw6IGFybWFkYTog Z2V0IHJpZCBvZiB0aGUgLT5pc192YWxpZCgpIHBvaW50ZXIKPiAgIHRoZXJtYWw6IGFybWFkYTog YWRkIG92ZXJoZWF0IGludGVycnVwdCBzdXBwb3J0Cj4gICBkdC1iaW5kaW5nczogY3AxMTA6IHJl bmFtZSBjcDExMCBzeXNjb24gZmlsZQo+ICAgZHQtYmluZGluZ3M6IGFwODA2OiBwcmVwYXJlIHRo ZSBzeXNjb24gZmlsZSB0byBsaXN0IG90aGVyIHN5c2NvbnMKPiAgICAgbm9kZXMKPiAgIGR0LWJp bmRpbmdzOiBjcDExMDogcHJlcGFyZSB0aGUgc3lzY29uIGZpbGUgdG8gbGlzdCBvdGhlciBzeXNj b25zCj4gICAgIG5vZGVzCj4gICBkdC1iaW5kaW5nczogYXA4MDY6IGFkZCB0aGUgdGhlcm1hbCBu b2RlIGluIHRoZSBzeXNjb24gZmlsZQo+ICAgZHQtYmluZGluZ3M6IGNwMTEwOiB1cGRhdGUgZG9j dW1lbnRhdGlvbiBzaW5jZSBEVCBkZS1kdXBsaWNhdGlvbgo+ICAgZHQtYmluZGluZ3M6IGNwMTEw OiBhZGQgdGhlIHRoZXJtYWwgbm9kZSBpbiB0aGUgc3lzY29uIGZpbGUKPiAgIGR0LWJpbmRpbmdz OiB0aGVybWFsOiBhcm1hZGE6IGFkZCByZWZlcmVuY2UgdG8gbmV3IGJpbmRpbmdzCj4gICBhcm02 NDogZHRzOiBtYXJ2ZWxsOiByZW5hbWUgYXA4MDYgc3lzY29uIG5vZGUKPiAgIGFybTY0OiBkdHM6 IG1hcnZlbGw6IG1vdmUgQVA4MDYvQ1AxMTAgdGhlcm1hbCBub2RlcyBpbnRvIGEgbmV3IHN5c2Nv bgo+ICAgYXJtNjQ6IGR0czogbWFydmVsbDogYWRkIHRoZXJtYWwtem9uZSBub2RlIGluIGFwODA2 IERUU0kgZmlsZQo+ICAgYXJtNjQ6IGR0czogbWFydmVsbDogYWRkIG1hY3JvIHRvIG1ha2UgZGlz dGluY3Rpb24gYmV0d2VlbiBub2RlIG5hbWVzCj4gICBhcm02NDogZHRzOiBtYXJ2ZWxsOiBhZGQg dGhlcm1hbC16b25lIG5vZGUgaW4gY3AxMTAgRFRTSSBmaWxlCj4gICBhcm02NDogZHRzOiBtYXJ2 ZWxsOiBhZGQgaW50ZXJydXB0IHN1cHBvcnQgdG8gYXA4MDYgdGhlcm1hbCBub2RlCj4gICBhcm02 NDogZHRzOiBtYXJ2ZWxsOiBhZGQgaW50ZXJydXB0IHN1cHBvcnQgdG8gY3AxMTAgdGhlcm1hbCBu b2RlCj4KPiAgLi4uL2FybS9tYXJ2ZWxsL2FwODA2LXN5c3RlbS1jb250cm9sbGVyLnR4dCAgICAg ICAgfCAgNTUgKy0KPiAgLi4uY29udHJvbGxlcjAudHh0ID0+IGNwMTEwLXN5c3RlbS1jb250cm9s bGVyLnR4dH0gfCAgNjYgKy0KPiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvdGhlcm1hbC9hcm1h ZGEtdGhlcm1hbC50eHQgfCAgIDUgKwo+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJt YWRhLWFwODA2LmR0c2kgICAgICB8ICA4NSArLQo+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZl bGwvYXJtYWRhLWNvbW1vbi5kdHNpICAgICB8ICAgMSArCj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMv bWFydmVsbC9hcm1hZGEtY3AxMTAuZHRzaSAgICAgIHwgIDQ1ICstCj4gIGRyaXZlcnMvdGhlcm1h bC9hcm1hZGFfdGhlcm1hbC5jICAgICAgICAgICAgICAgICAgIHwgODc1ICsrKysrKysrKysrKysr KysrKy0tLQo+ICA3IGZpbGVzIGNoYW5nZWQsIDk3NiBpbnNlcnRpb25zKCspLCAxNTYgZGVsZXRp b25zKC0pCj4gIHJlbmFtZSBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvYXJtL21h cnZlbGwve2NwMTEwLXN5c3RlbS1jb250cm9sbGVyMC50eHQgPT4gY3AxMTAtc3lzdGVtLWNvbnRy b2xsZXIudHh0fSAoODMlKQoKV2hhdCBpcyB0aGUgc3RhdHVzIG9mIHRoaXMgc2VyaWVzPwpJIGFt IGVzcGVjaWFsbHkgaW50ZXJlc3RlZCBpbiB0aGUgZHQgcGFydC4KRG8geW91IGV4cGVjdCBzZW5k aW5nIGEgbmV3IHNlcmllcyBtb2RpZnlpbmcgdGhlbT8KCkdyZWdvcnkKCj4KPiAtLSAKPiAyLjE0 LjEKPgoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9vdGxpbiAoZm9ybWVybHkgRnJlZSBFbGVjdHJv bnMpCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cDovL2Jvb3RsaW4u Y29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@bootlin.com (Gregory CLEMENT) Date: Wed, 16 May 2018 19:28:45 +0200 Subject: [PATCH 00/27] Add multi-channel and overheat IRQ support to Armada thermal driver In-Reply-To: <20180421151255.29929-1-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Sat, 21 Apr 2018 17:12:28 +0200") References: <20180421151255.29929-1-miquel.raynal@bootlin.com> Message-ID: <871seb33xu.fsf@bootlin.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Miquel, On sam., avril 21 2018, Miquel Raynal wrote: > The only capability of the Armada thermal driver is currently just to > read one sensor (the default one) per AP and one per CP. > > Actually, there is one sensor per core in the AP806 plus one sensor in > the thermal IP itself. The CP110 just features one thermal sensor in its > own thermal IP. > > Also, there is no need for the thermal core to poll the temperature of > each sensor by software as this IP (at least for AP806 and CP110 > compatibles) features an hardware overheat interrupt. > > This series first improves the readability of this driver, then adds > support for multi-channel thermal IPs, and finally adds support for the > hardware overheat interrupt. The bindings and the device-trees are > updated accordingly. > > Please note that the thermal IP raises SEI interrupts, from which the > support as just been contributed and not merged yet. Applying the last > DT patches referring to the 'sei' and 'icu_sei' nodes will require this > feature [1] to have been accepted first. > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-April/572852.html > > Thank you, > Miqu?l > > > Miquel Raynal (27): > thermal: armada: add a function that sanitizes the thermal zone name > thermal: armada: remove useless register accesses > thermal: armada: remove misleading comments > thermal: armada: rename the initialization routine > thermal: armada: dissociate a380 and cp110 ->init() hooks > thermal: armada: average over samples to avoid glitches > thermal: armada: convert driver to syscon register accesses > thermal: armada: use the resource managed registration helper > alternative > thermal: armada: add multi-channel sensors support > thermal: armada: remove sensors validity from the IP initialization > thermal: armada: move validity check out of the read function > thermal: armada: get rid of the ->is_valid() pointer > thermal: armada: add overheat interrupt support > dt-bindings: cp110: rename cp110 syscon file > dt-bindings: ap806: prepare the syscon file to list other syscons > nodes > dt-bindings: cp110: prepare the syscon file to list other syscons > nodes > dt-bindings: ap806: add the thermal node in the syscon file > dt-bindings: cp110: update documentation since DT de-duplication > dt-bindings: cp110: add the thermal node in the syscon file > dt-bindings: thermal: armada: add reference to new bindings > arm64: dts: marvell: rename ap806 syscon node > arm64: dts: marvell: move AP806/CP110 thermal nodes into a new syscon > arm64: dts: marvell: add thermal-zone node in ap806 DTSI file > arm64: dts: marvell: add macro to make distinction between node names > arm64: dts: marvell: add thermal-zone node in cp110 DTSI file > arm64: dts: marvell: add interrupt support to ap806 thermal node > arm64: dts: marvell: add interrupt support to cp110 thermal node > > .../arm/marvell/ap806-system-controller.txt | 55 +- > ...controller0.txt => cp110-system-controller.txt} | 66 +- > .../devicetree/bindings/thermal/armada-thermal.txt | 5 + > arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 85 +- > arch/arm64/boot/dts/marvell/armada-common.dtsi | 1 + > arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 45 +- > drivers/thermal/armada_thermal.c | 875 ++++++++++++++++++--- > 7 files changed, 976 insertions(+), 156 deletions(-) > rename Documentation/devicetree/bindings/arm/marvell/{cp110-system-controller0.txt => cp110-system-controller.txt} (83%) What is the status of this series? I am especially interested in the dt part. Do you expect sending a new series modifying them? Gregory > > -- > 2.14.1 > -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com